Date:   Thu, 16 Feb 2023 11:49:35 +0100
From:   Johan Hovold <johan@kernel.org>
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Corentin Labbe <clabbe@baylibre.com>, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org
Subject: Re: [PATCH v5 1/2] usb: serial: add support for CH348
Message-ID: <Y+4KP/WdObzJTwOj@hovoldconsulting.com>
References: <20230106135338.643951-1-clabbe@baylibre.com>
 <20230106135338.643951-2-clabbe@baylibre.com>
 <Y+30EYVTiAuhj1iK@hovoldconsulting.com>
 <Y+4Fpd0lcJkQrXef@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y+4Fpd0lcJkQrXef@kroah.com>
Precedence: bulk

On Thu, Feb 16, 2023 at 11:29:57AM +0100, Greg Kroah-Hartman wrote:
> On Thu, Feb 16, 2023 at 10:14:57AM +0100, Johan Hovold wrote:
> > > +	if (urb->actual_length < 2) {
> > > +		dev_dbg(&port->dev, "%s:%d empty rx buffer\n", __func__, __LINE__);
> > 
> > I'm sure I've asked you drop __LINE__. Please be more careful when
> > considering review comments.
> 
> FYI, __func__ and __LINE__ are included automatically in dev_dbg() calls
> so any addition in the string for them is redundant and should never be
> there (it's also a hint that no one used this debug statement as the
> redundancy would be kind of obvious...)

Not exactly automatically since you need to explicitly request that they
are included, but yes, they are redundant.

__func__ may sometimes be useful for compact debug messages, though. As
an example, "get_chars - 5" is self-contained, while simply printing "5"
doesn't make any sense unless you also enable function prefixes.

Johan