From:   Benjamin Tissoires <benjamin.tissoires@redhat.com>
To:     Jiri Kosina <jikos@kernel.org>, Hanno Zulla <abos@hanno.de>,
        Pietro Borrello <borrello@diag.uniroma1.it>
Cc:     Jiri Kosina <jkosina@suse.cz>, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org
In-Reply-To: <20230211-bigben-oob-v1-1-d2849688594c@diag.uniroma1.it>
References: <20230211-bigben-oob-v1-1-d2849688594c@diag.uniroma1.it>
Subject: Re: [PATCH] hid: bigben_probe(): validate report count
Message-Id: <167654718338.255038.8270814886921394655.b4-ty@redhat.com>
Date:   Thu, 16 Feb 2023 12:33:03 +0100
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On Sun, 12 Feb 2023 00:01:44 +0000, Pietro Borrello wrote:
> bigben_probe() does not validate that the output report has the
> needed report values in the first field.
> A malicious device registering a report with one field and a single
> value causes an head OOB write in bigben_worker() when
> accessing report_field->value[1] to report_field->value[7].
> Use hid_validate_values() which takes care of all the needed checks.
> 
> [...]

Applied, thanks!

[1/1] hid: bigben_probe(): validate report count
      commit: b94335f899542a0da5fafc38af8edcaf90195843

Best regards,
-- 
Benjamin Tissoires <benjamin.tissoires@redhat.com>