From:   Pawel Laszczak <pawell@cadence.com>
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "Daisy.Barrera@siriusxm.com" <Daisy.Barrera@siriusxm.com>,
        "Cliff.Holden@siriusxm.com" <Cliff.Holden@siriusxm.com>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "tony@atomide.com" <tony@atomide.com>,
        "jdelvare@suse.de" <jdelvare@suse.de>,
        "neal_liu@aspeedtech.com" <neal_liu@aspeedtech.com>,
        "linus.walleij@linaro.org" <linus.walleij@linaro.org>,
        "egtvedt@samfundet.no" <egtvedt@samfundet.no>,
        "biju.das.jz@bp.renesas.com" <biju.das.jz@bp.renesas.com>,
        "herve.codina@bootlin.com" <herve.codina@bootlin.com>
Subject: RE: [PATCH 3/4] usb: cdns2: Add tracepoints for CDNS2 driver
Thread-Topic: [PATCH 3/4] usb: cdns2: Add tracepoints for CDNS2 driver
Thread-Index: AQHZQfUqM/9qMSrzAEub/2fGw+LRhq7RbhaAgAABznA=
Date:   Thu, 16 Feb 2023 11:36:14 +0000
Message-ID: <BYAPR07MB53814D13CAF0AC674AD00317DDA09@BYAPR07MB5381.namprd07.prod.outlook.com>
References: <20230216105411.364157-1-pawell@cadence.com>
 <20230216105411.364157-4-pawell@cadence.com> <Y+4SCXeMUgQhpADE@kroah.com>
In-Reply-To: <Y+4SCXeMUgQhpADE@kroah.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jgnHxvgfwgWSo9Nj3SOuxpU431OC/CVio57Mx7F/qx9gZ/cNMV0SOyv+gcww?=
 =?us-ascii?Q?JWOyMEaA0BaBozKTlCgfNC52gLw81+J0rtNHP78EbbzQsqo/jeH5rJVhD6ql?=
 =?us-ascii?Q?hHx1sls4HPyWZR3dcspsI83Nv501ewIa2X/oaoPHV35zoQkNOf/snDNXxJlZ?=
 =?us-ascii?Q?Gt/WZK2tAGW7Kz+erTQNt8yRdo567h4dS+XpXfh1jhUuB2pg4sOIzcVFw4JG?=
 =?us-ascii?Q?gWllDbJsVA51AvuCC6Ew/TA9mncBg8i/sEmEY+qFSXW2F5LrtGx7bbu2uMpJ?=
 =?us-ascii?Q?AN/RqDHNLA5z8Xby+0V/aWcNlS/sKlcX1cevXYc3r87PATbNTakowJFAjyNV?=
 =?us-ascii?Q?BXnWyUb19L8gkTjsfspCJm7MFkIQQLat29v7//hV4e7/7VN1axzw7w+p6kSv?=
 =?us-ascii?Q?PasKMn2DAOgjZBYMheiUjx/Llueeww+kB2zoKLsKCTd8nfq+HJNPlK2ixmMG?=
 =?us-ascii?Q?z0IowuZXsoNqElSLm5WNaH7s9XPC+9FmU5ZoHZXVWt13V/scil8qmQfkqrKh?=
 =?us-ascii?Q?xm1yxwplISySUOaIm8uDgFwzwCg+sW5UeVTHb9jCnL9bndgMCAwEWTl7oLVH?=
 =?us-ascii?Q?gXs6mxaweN7iIeYHVXdb0F/eUnIMMB+OyrTySreE0fNQlsPhWQ3ZDqtcKdk/?=
 =?us-ascii?Q?JlU/tKTlgegiOukK+Tg959/qfP4GNPvZApLwivWexN898XwTSslpa3nqYrVP?=
 =?us-ascii?Q?uc+YcW4LNoyF8aCDsO/pvMbeVnj8ISOCFM6dzfk8Mm+DDHGj03WRUWjtYJ/J?=
 =?us-ascii?Q?tJt7wZ0naHpbiL2g3aIcSQ7hvJ4suvJQFFsgQFdTy9vuLrsWduBJrrYdpegD?=
 =?us-ascii?Q?3AKGhCXER++UuqO2U16IZNLLZdUOrtnP/xj1tYAN8jO4gAMWoDIz9O4B3Gyw?=
 =?us-ascii?Q?vbSMYJW8FYhJLQCvr8PUabOe8TSpegcz/4noK4wNxOfKGS5gEorafRgvtlFT?=
 =?us-ascii?Q?F2tODRdwjHh3cQLKMM0w54vZkr5In2G4XwJkyWfuHpIvIFpvrBZMu3VAp8n5?=
 =?us-ascii?Q?5dOa59IFVa2S9syYLR8ZSYSFGs+0fjVd4roSedhKF8eiiLX+bZBDCa8VHk5D?=
 =?us-ascii?Q?MZ+nSggN+k43xtqfh0VXsM/5J1yAcc/R/uOgVJ0RilIulgTkqKRpAyoub1dH?=
 =?us-ascii?Q?bjHA0Ac03XXRvQDfLQ5y3q4xavAiv0AQ7c8JA7zhOfaH0q0Ez9eFUYIj9cgi?=
 =?us-ascii?Q?HzF1uyfk30hw+Mw9M3/+FNTuDx1I01qcBlIl6dyYGGjjmhyQC4GEPbYRR7Rc?=
 =?us-ascii?Q?XLnB6CNl8FLE5KGpa60U+0ZGsSusZHc8glh2/sjUntNef3OuwBihEfzMCVcB?=
 =?us-ascii?Q?R3VX7R+jo1KGTjwGPRBdB9H7KIKHEMCcMxJVKUKTDawn3whppcmu3KMGdaIR?=
 =?us-ascii?Q?tebgAaaUfMv+3HqY3I1Abml0EuuZbrjqdnhQIbTAgPNw5qrtu84Dl+AlOb0F?=
 =?us-ascii?Q?0c0q6BdSPZpSP5JL89b8Y2nmBkXPcLnLi/GZS7RZv313h8fce0lMY8sMzpqv?=
 =?us-ascii?Q?UmCPmLERkw/JImhY9dOMvvNSVTfE2wogzIkAnuEwM6utbvhgd/wvgdTV/3ud?=
 =?us-ascii?Q?RrC7biVWK9FUB9BhKlPgxjF4f23Is4aiS+eWlMhy?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: cadence.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR07MB5381.namprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 24e305f8-1f7b-4f37-4178-08db101202ee
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Feb 2023 11:36:14.7525
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5O6f7+YjnSG725qCVDN4JZpv7JregdOSkB7U0MfOHZd5Gu+gb4GjyTL/g3Gw9uDj3k1+ohw5mcsdCTJQVeI5BkhzQ1xFs9DVBihqxWu7vms=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR07MB5619
X-Proofpoint-GUID: Ovwt18vLNTQmeVtVWmaLi_Zm_PNWuLI5
X-Proofpoint-ORIG-GUID: Ovwt18vLNTQmeVtVWmaLi_Zm_PNWuLI5
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22
 definitions=2023-02-16_08,2023-02-16_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0
 priorityscore=1501 suspectscore=0 spamscore=0 bulkscore=0 impostorscore=0
 mlxscore=0 lowpriorityscore=0 mlxlogscore=571 phishscore=0 malwarescore=0
 adultscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2302160098
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>
>On Thu, Feb 16, 2023 at 05:54:10AM -0500, Pawel Laszczak wrote:
>> Patch adds the series of tracepoints that can be used for debugging
>> issues detected in driver.
>>
>> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
>> ---
>>  drivers/usb/gadget/udc/cdns2/Makefile       |   2 +
>>  drivers/usb/gadget/udc/cdns2/cdns2-debug.h  | 200 +++++++
>>  drivers/usb/gadget/udc/cdns2/cdns2-ep0.c    |  26 +-
>>  drivers/usb/gadget/udc/cdns2/cdns2-gadget.c |  52 +-
>> drivers/usb/gadget/udc/cdns2/cdns2-trace.c  |  11 +
>> drivers/usb/gadget/udc/cdns2/cdns2-trace.h  | 609 ++++++++++++++++++++
>>  6 files changed, 897 insertions(+), 3 deletions(-)  create mode
>> 100644 drivers/usb/gadget/udc/cdns2/cdns2-debug.h
>>  create mode 100644 drivers/usb/gadget/udc/cdns2/cdns2-trace.c
>>  create mode 100644 drivers/usb/gadget/udc/cdns2/cdns2-trace.h
>>
>> diff --git a/drivers/usb/gadget/udc/cdns2/Makefile
>> b/drivers/usb/gadget/udc/cdns2/Makefile
>> index 7c746e6d53c2..a1ffbbe2e768 100644
>> --- a/drivers/usb/gadget/udc/cdns2/Makefile
>> +++ b/drivers/usb/gadget/udc/cdns2/Makefile
>> @@ -1,5 +1,7 @@
>>  # SPDX-License-Identifier: GPL-2.0
>>  # define_trace.h needs to know how to find our header
>> +CFLAGS_cdns2-trace.o		:=3D -I$(src)
>>
>>  obj-$(CONFIG_USB_CDNS2_UDC)		+=3D cdns2-udc-pci.o
>>  cdns2-udc-pci-$(CONFIG_USB_CDNS2_UDC)	+=3D cdns2-pci.o cdns2-gadget.o
>cdns2-ep0.o
>> +cdns2-udc-pci-$(CONFIG_TRACING)	+=3D cdns2-trace.o
>> diff --git a/drivers/usb/gadget/udc/cdns2/cdns2-debug.h
>> b/drivers/usb/gadget/udc/cdns2/cdns2-debug.h
>> new file mode 100644
>> index 000000000000..3a80f3fbdcd3
>> --- /dev/null
>> +++ b/drivers/usb/gadget/udc/cdns2/cdns2-debug.h
>> @@ -0,0 +1,200 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
>> +/*
>> + * Cadence USBHS-DEV Driver.
>> + * Debug header file.
>> + *
>> + * Copyright (C) 2023 Cadence.
>> + *
>> + * Author: Pawel Laszczak <pawell@cadence.com>  */
>> +
>> +#ifndef __LINUX_CDNS2_DEBUG
>> +#define __LINUX_CDNS2_DEBUG
>> +
>> +static inline const char *cdns2_decode_usb_irq(char *str, size_t size,
>> +					       u8 usb_irq, u8 ext_irq)
>
><snip>
>
>Why are all of these big functions declared as inline?  Do they really wor=
k as
>inline functions if you only reference them in a trace callback?
>

Yes, driver reference them only in trace callback.
The big function are used only once in code, so it seems reasonable to use =
them as inline.
I don't know how they will be used by compiler.=20

Thanks,

Pawel Laszczak