MIME-Version: 1.0
References: <20230216041224.4731-1-orlandoch.dev@gmail.com>
 <20230216041224.4731-3-orlandoch.dev@gmail.com> <20230216181050.52a31247@redecorated-mbp>
In-Reply-To: <20230216181050.52a31247@redecorated-mbp>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Thu, 16 Feb 2023 13:49:21 +0200
Message-ID: <CAHp75VeX0j8ZX+j0i7qPe97NcyFLvhmETFCbRVYiVCFQWk8Akg@mail.gmail.com>
Subject: Re: [PATCH 2/2] HID: apple-magic-backlight: Add driver for keyboard
 backlight on internal Magic Keyboards
To:     Orlando Chamberlain <orlandoch.dev@gmail.com>
Cc:     linux-input@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
        Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        Pavel Machek <pavel@ucw.cz>,
        Aditya Garg <gargaditya08@live.com>,
        Aun-Ali Zaidi <admin@kodeit.net>,
        Kerem Karabay <kekrby@gmail.com>,
        Andy Shevchenko <andy@infradead.org>,
        =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= <thomas@t-8ch.de>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Feb 16, 2023 at 10:15 AM Orlando Chamberlain
<orlandoch.dev@gmail.com> wrote:
> On Thu, 16 Feb 2023 15:12:28 +1100
> Orlando Chamberlain <orlandoch.dev@gmail.com> wrote:

...

> >  drivers/hid/apple-magic-backlight.c | 125
>
> A general question to the hid/input folks:
>
> Is it alright that this doesn't start with "hid-"? All the other
> drivers start with that so I'm not sure if its an issue.

What makes apple so special?

> If it is, then
> I can rename it to "hid-apple-magic-backlight".

If there is a good justification of not doing that, put it into the
commit message.

-- 
With Best Regards,
Andy Shevchenko