Date:   Thu, 16 Feb 2023 14:20:53 +0100
Message-ID: <877cwh7nm2.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Orlando Chamberlain <orlandoch.dev@gmail.com>
Cc:     alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, Evan Quan <evan.quan@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        linux-kernel@vger.kernel.org, Aditya Garg <gargaditya08@live.com>,
        Aun-Ali Zaidi <admin@kodeit.net>,
        Kerem Karabay <kekrby@gmail.com>
Subject: Re: [PATCHv2] hda/hdmi: Register with vga_switcheroo on Dual GPU Macbooks
In-Reply-To: <20230216103450.12925-1-orlandoch.dev@gmail.com>
References: <20230216103450.12925-1-orlandoch.dev@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Thu, 16 Feb 2023 11:34:51 +0100,
Orlando Chamberlain wrote:
> 
> Commit 586bc4aab878 ("ALSA: hda/hdmi - fix vgaswitcheroo detection for
> AMD") caused only AMD gpu's with PX to have their audio component register
> with vga_switcheroo. This meant that Apple Macbooks with apple-gmux as the
> gpu switcher no longer had the audio client registering, so when the gpu is
> powered off by vga_switcheroo snd_hda_intel is unaware that it should have
> suspended the device:
> 
> amdgpu: switched off
> snd_hda_intel 0000:03:00.1:
>     Unable to change power state from D3hot to D0, device inaccessible
> snd_hda_intel 0000:03:00.1: CORB reset timeout#2, CORBRP = 65535
> 
> To resolve this, we use apple_gmux_detect() and register a
> vga_switcheroo audio client when apple-gmux is detected.
> 
> Fixes: 586bc4aab878 ("ALSA: hda/hdmi - fix vgaswitcheroo detection for AMD")
> Link: https://lore.kernel.org/all/20230210044826.9834-9-orlandoch.dev@gmail.com/
> Signed-off-by: Orlando Chamberlain <orlandoch.dev@gmail.com>
> ---
> v1->v2: Use apple_gmux_detect(), split this patch out of the patch
> series

Thanks, applied now.


Takashi