Message-ID: <47ca27c8-b1c4-1566-c6e2-e3323babb2b1@nvidia.com>
Date:   Thu, 16 Feb 2023 21:28:32 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.2
Subject: Re: [PATCH net-next v2 1/3] vxlan: Expose helper vxlan_build_gbp_hdr
Content-Language: en-US
To:     Paolo Abeni <pabeni@redhat.com>, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, roopa@nvidia.com,
        eng.alaamohamedsoliman.am@gmail.com, bigeasy@linutronix.de
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Gavi Teitz <gavi@nvidia.com>, Roi Dayan <roid@nvidia.com>,
        Maor Dickman <maord@nvidia.com>,
        Saeed Mahameed <saeedm@nvidia.com>
References: <20230215094102.36844-1-gavinl@nvidia.com>
 <20230215094102.36844-2-gavinl@nvidia.com>
 <3f874bb8638258d131fcb764714b12b5a4c9eb39.camel@redhat.com>
From:   Gavin Li <gavinl@nvidia.com>
In-Reply-To: <3f874bb8638258d131fcb764714b12b5a4c9eb39.camel@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NytoQURVeTFJWCsyak95dGNpMnVHSCs2RU1RT1RUSVNFU3h0Q1pqT3ViMVBM?=
 =?utf-8?B?aGZzVWw3NmxCb1RMUGczUVVLbDUvVFZLeGZSSU5aVDVYZEJydEdySUxEVDFm?=
 =?utf-8?B?UGNTdzVHQWlFdTNwUk9DR040aWVwbGI3LzNVVkhvV3QyRjlpdUVSQVBIN2lI?=
 =?utf-8?B?enZFT3VXb1BUM3lsSTJtUjY0K0RiWG8xU1JjVzUyVVZ5NlJOSW81bU5SYXZD?=
 =?utf-8?B?aStVMEhiZDl3OGVHMUlPREJwZVBDWmUzOGNaR1lmaU5pRkhBRFFJckdZVFBK?=
 =?utf-8?B?OUt1QjJKSTZTZ3hDL00vakJta0JlMXArakRTeVpuYnVvYWtSUjF5ZnZXM3Uv?=
 =?utf-8?B?T1RuMm0vREtkRlBlYkZVVk4wM3hKUHBmdVZvRXVYQjNpNjAySU96NWFFNzhQ?=
 =?utf-8?B?c2ZtdVkyWXhzenJXTDJvLzA4dU96Uk5zZDlBcGtUc3NUSWZya01kWGpYOHFi?=
 =?utf-8?B?d1RuNkQyVmh6cS9aNXJDUVB6aHIzSGptZnhQK3F0OU1zclhHdzBrOUEveDdh?=
 =?utf-8?B?NTJQV25VS3NBMWNXT2hvTzVZVnZENE9RQ0YzNS9sQU5wSk54RWlxeWRzUjIx?=
 =?utf-8?B?d204VzhuczBiVVZ1amdXTUJoWEVmaDB3ZThmTVo2OFJUYmMwUG1pTnNlQUhE?=
 =?utf-8?B?cWoxa1hPekdOT2FZMnI3clZDeDYxWjlsV2t6N01TN3VockdQV05QTFV2Yk9L?=
 =?utf-8?B?VmhhU2N4ZmFSQjNWOFozSEUrYXJjRTRIcUxuY1ovQmlnOUJMNmJDUTJPV3di?=
 =?utf-8?B?WVg2VnNLbkJKNzV0cHp2WjQxRmx1WGtKQ1pXcFNPM2o0ZjRiZjNuVHk1ZFNi?=
 =?utf-8?B?bXlOL3RhL0cwa0xBQklWc2RwVzgvN2VFU29ScmhseFNySlBRVW4ycXZTd3p5?=
 =?utf-8?B?NDhnQmszMllzQXowNUcyNTB6bkFKM0hlRnlnU3gzNjQ1YWlQaVQzMUVSZWpy?=
 =?utf-8?B?OEJnRVBWQmZXckI1OVgyMVlFME9LMWQ4Tm15ckwza09MK0xST2dmZm9aSmRh?=
 =?utf-8?B?K05HS20yL0hxUzUvdHJDRkRwYkMycXVkQ1JiK2JxSjVPTXpGWEo3RDRLbDJH?=
 =?utf-8?B?TmNmamU5cUxZQ1dRcWJaM2RTNUVBVk1BL1VLT2xjWjZ5NmtPc0FzaFVpLzNV?=
 =?utf-8?B?eVpFQk5CYVFoMFVEUG5qQnN6cVdCcHBXS3Z3WWptWUNPcVlWQ1VNbEk1ZC8y?=
 =?utf-8?B?SEpjczBTKzIzSWQ2eWpVTXExY3ZCek5USkxaclBqQU5wanMvT0oxb2plNVQr?=
 =?utf-8?B?YUMwTDhlVU5VdDRGSXM2aHkzcjByS2dnY1NIZVpMQzJwWExKZ1pXVkl3MHBH?=
 =?utf-8?B?WTZmV0M1cVBzK0YyeG1QYW9yd21Jc3lDaEtxRUlzQ2tKbG5FSTM5bi9HQ2FM?=
 =?utf-8?B?ZDRvUkdVQTN3TzlyOHhlRlFCR1RDL3B2UU96QUtOQ0RGdEhvVUIwTUtFUzN4?=
 =?utf-8?B?R1hXblZFNHlYYXIzSGZzM21aS1BZMGNpdUphMGdYUDBQSkZPRkVDTlYvSlMx?=
 =?utf-8?B?NzRBNm0rVXVVRUZMNjhnRnJINWk0cWNVMXhVdUlKdytuLytRQ0xqWHYrbmVN?=
 =?utf-8?B?bWxyUEhLL1VsYmhDS3RKV1lISWRRc1pKemdad25VZ1Rtd3MvWi9nQ2JFUEdU?=
 =?utf-8?B?NURIU2JuVkhCa2x4L2pOSit0WTM3YXRQTXRMT0ZyVGNpUTRoTktFakxiZUxz?=
 =?utf-8?B?bjJUdjJNdzd2L2g3RGRDVzZRMUgxZ0M2N3BBQUtzMU4rYVBBTnYrVjE0RjZv?=
 =?utf-8?B?QnI0REtyVkoxV3o1R3I4SlVSTlpPSUQzbUVZYm00Sk9DT2tGc2x3a2lIWGhp?=
 =?utf-8?B?YXlTVFUrTGdKejhMSnV2TDh1S09lL0FRTVZEU1RUbitwakNhMERkOWtISmlw?=
 =?utf-8?B?Njg4QmpGLzNwQ01iTW5mYm4rSVNUQzF5SEhqZDVHUWlWcUpGbFlDbDdMM0dl?=
 =?utf-8?B?MHpIYWNRWHhzdU9XRWxyck1KejJBd1doYnNReUhwbElrekFValV4UDJVemNO?=
 =?utf-8?B?N1BxOWpFOFJxNU1VSVp1Z3ZyeEtqMzNFUG5QT1JiNkR3Z2xtTGxBV2tqRTJj?=
 =?utf-8?B?OWJUYk1hbDExS1drS1lpZGpLejZRTHlVUEhXdGt1WVhsejV2bUl0OUF1ZVBs?=
 =?utf-8?Q?kXovRv1BwhjhfbDnZoOnVLSNs?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e770d58f-46a2-454a-236b-08db1021ba96
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3835.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 13:28:45.6861
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rcKu9Xjl9vWo2xYlIZABruu8IsNIvIfICf0q5Q8IIJqYX6xy4tvxoMpAC5o3v+MOvhy97KqjlMzJ64mjTUwtuA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7414
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2/16/2023 7:57 PM, Paolo Abeni wrote:
> External email: Use caution opening links or attachments
>
>
> On Wed, 2023-02-15 at 11:41 +0200, Gavin Li wrote:
>> vxlan_build_gbp_hdr will be used by other modules to build gbp option in
>> vxlan header according to gbp flags.
>>
>> Signed-off-by: Gavin Li <gavinl@nvidia.com>
>> Reviewed-by: Gavi Teitz <gavi@nvidia.com>
>> Reviewed-by: Roi Dayan <roid@nvidia.com>
>> Reviewed-by: Maor Dickman <maord@nvidia.com>
>> Acked-by: Saeed Mahameed <saeedm@nvidia.com>
>> ---
>>   drivers/net/vxlan/vxlan_core.c | 20 --------------------
>>   include/net/vxlan.h            | 20 ++++++++++++++++++++
>>   2 files changed, 20 insertions(+), 20 deletions(-)
>>
>> diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c
>> index b1b179effe2a..bd44467a5a39 100644
>> --- a/drivers/net/vxlan/vxlan_core.c
>> +++ b/drivers/net/vxlan/vxlan_core.c
>> @@ -2140,26 +2140,6 @@ static bool route_shortcircuit(struct net_device *dev, struct sk_buff *skb)
>>        return false;
>>   }
>>
>> -static void vxlan_build_gbp_hdr(struct vxlanhdr *vxh, u32 vxflags,
>> -                             struct vxlan_metadata *md)
>> -{
>> -     struct vxlanhdr_gbp *gbp;
>> -
>> -     if (!md->gbp)
>> -             return;
>> -
>> -     gbp = (struct vxlanhdr_gbp *)vxh;
>> -     vxh->vx_flags |= VXLAN_HF_GBP;
>> -
>> -     if (md->gbp & VXLAN_GBP_DONT_LEARN)
>> -             gbp->dont_learn = 1;
>> -
>> -     if (md->gbp & VXLAN_GBP_POLICY_APPLIED)
>> -             gbp->policy_applied = 1;
>> -
>> -     gbp->policy_id = htons(md->gbp & VXLAN_GBP_ID_MASK);
>> -}
>> -
>>   static int vxlan_build_gpe_hdr(struct vxlanhdr *vxh, u32 vxflags,
>>                               __be16 protocol)
>>   {
>> diff --git a/include/net/vxlan.h b/include/net/vxlan.h
>> index bca5b01af247..02b01a6034a2 100644
>> --- a/include/net/vxlan.h
>> +++ b/include/net/vxlan.h
>> @@ -566,4 +566,24 @@ static inline bool vxlan_fdb_nh_path_select(struct nexthop *nh,
>>        return true;
>>   }
>>
>> +static inline void vxlan_build_gbp_hdr(struct vxlanhdr *vxh, u32 vxflags,
>> +                                    const struct vxlan_metadata *md)
> Calling this helper causes a warning on patch 3 due to different types
> for the 2nd argument. The warning could be addressed there with an
> explicit cast but it looks like 'vxflags' is not used at all here.
>
> I suggest to add a preparation patch dropping such argument (and the
> same for vxlan_build_gpe_hdr(), still in the same patch), should be
> cleaner.
ACK
>
> Thanks,
>
> Paolo
>