From:   Nick Alcock <nick.alcock@oracle.com>
To:     Bjorn Helgaas <helgaas@kernel.org>
Cc:     mcgrof@kernel.org, linux-modules@vger.kernel.org,
        linux-kernel@vger.kernel.org, Rob Herring <robh@kernel.org>,
        linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/8] kbuild, PCI: generic,versatile: comment out
 MODULE_LICENSE in non-modules
References: <20230214172053.GA3044917@bhelgaas>
Emacs:  ed  ::  20-megaton hydrogen bomb : firecracker
Date:   Thu, 16 Feb 2023 13:34:30 +0000
In-Reply-To: <20230214172053.GA3044917@bhelgaas> (Bjorn Helgaas's message of
        "Tue, 14 Feb 2023 11:20:53 -0600")
Message-ID: <87r0upvimx.fsf@esperi.org.uk>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1.91 (gnu/linux)
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vtwwsJaqbznD5G+HDw/9JnHkw998tVfU+8k/JUcLwF5xqG+lDB50FN5rTAef?=
 =?us-ascii?Q?thRY/T9y82WGYNQhVq7U0gNnhrdheSjbsKXRD6RyXujDncpor45fd3v/FDJ2?=
 =?us-ascii?Q?kauo7zEL0ynFv1qyvxBAHS9Oe0DTP9Euv6iIglLY8psxO6lKrK1yeYwKB89T?=
 =?us-ascii?Q?bRKC5qiqs7wKz7fi8XKRZxRobkvNNdGLmpS1/5fo4sf16QXcgyOE1zgRG5Fd?=
 =?us-ascii?Q?+GWaZIiuGEKTW8hH1OoZPomLyV9BaIl7TqLvK35u3Yhsq74yvxjpsY2mLo9S?=
 =?us-ascii?Q?Juz8+BSz/r58mXtvkE1kYY0PfykF/ZFG7nmb71vg1jTuueMNRcExpV/xUk/M?=
 =?us-ascii?Q?nAZfr6bigKfIkpm64X6YiEYnNKVjurvT5kKh9mVj/mol+ozHsXG8xXe+isgp?=
 =?us-ascii?Q?gaxK9Ar/BWko81j8AdPpIIwnY3VBC/0wJBOIn/em3XJRaI/epl6ug6yr2qPp?=
 =?us-ascii?Q?IP49DQtT+yzmcvxO9nxGp5k7QgmHCLMtvz3qZR5Y1Oo7SawiXKS3DVlwf+rg?=
 =?us-ascii?Q?y0PURT5wCGUumn1pDRS/PcLCUw8cF9QwkrQz2KOJKvzAn+N6NtekW/a0P+ww?=
 =?us-ascii?Q?ZN25DdoqFcXLjnkrLD4AeKDiCkCEdCS4oaRas7rmZevwpvik4uP+ndoMS+03?=
 =?us-ascii?Q?miurLEX2j+5tyFprKBMUFaoJAMoqvnPXXxRIfTv3t7ZtNs1OS8ORyyZX0KOX?=
 =?us-ascii?Q?hBqpgWhrP5IRDWyvKbDfC0ydoBCeQzspuI5XKW2nKNfGrWcx8qWrLkzz4AgP?=
 =?us-ascii?Q?mGGdIHXDExEFlwgXRgMUcR0gZ1pebPFs1bQ7R9k5aCa5Gm7pz8Z7QOf8M9uQ?=
 =?us-ascii?Q?1WCcnOkPXjZg9vUQE/mhUA6j4dJrQgPuRiBzcNUZXI4KU2EflACcUFbNg/YS?=
 =?us-ascii?Q?4mgoNuSSzK53k8L41f22P5Dc1d5DKM8CADZN+9f2No0icDCLz0gIpMP2cp44?=
 =?us-ascii?Q?8R5cwVKDaIYYq6xmxQw6BO7w1NsnVgHHfNUZ5SG4TUT2cxkT3q4D9ciNopuR?=
 =?us-ascii?Q?ltiSrFmWJn5CuILsxzMK1Ybpi6xc/8yKV25Z0WDGvfp+/FwNAEkJBhA7DaHy?=
 =?us-ascii?Q?D5wvWtbdWdSN4Re4AT8uQDDb50GEjPxYri8SSIUBOuieSJHUI+cxQMLdG7ic?=
 =?us-ascii?Q?UQrh3wvmWvMABYeTv1n+8xMAXwBUqNuGpLKwR+Xd/YlTBjHHy5x8LT/G6QKy?=
 =?us-ascii?Q?JQSfHqiMY7ouXMsRoS0VhzCR3HVJjqcln96oNc5vjD94iGv6+LdbpzgcIT7t?=
 =?us-ascii?Q?CuWyjXilnhHIhq4gl1zP5RWsvxsRTmZ9xBOYzENu4gCiwJ79I+qx2KyPJajC?=
 =?us-ascii?Q?uyNd921DeJTRiIl20R2ZmwvldNB8TawwUbWnALHPqkZ1+6u3FFeZGebtbPZn?=
 =?us-ascii?Q?KBVqhot4cxuUl3BVsiCNzwitDFG3cmRYpNTg6kZSMEPWTus5CrkRewd/gs4f?=
 =?us-ascii?Q?NpQ40KtE4KdoYhpI3gRSsPthimp7CrYDY9H0Jw8HHPI7lP8DSQBEaT7iPmP/?=
 =?us-ascii?Q?+VC1ke9ALYjcnJLhSlDqQospiDeGQrDLgwqPeEKzoFZt60dvZXB8FYVqwCLz?=
 =?us-ascii?Q?qeH+0eXByxbIcPx89xYwXLAquzshMzUmYAE3N70VWQtJb7doZ44ppMtj8EBq?=
 =?us-ascii?Q?aQ=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 9rF2qPwB3TZGqmELBWD05flO+pcIH28zjvDbMf4R1RkM3/jUcXPd2b95BGpXQBhGdpj9KzU6zI4SLiyg9k50+lEqfruljMlxQqMr+uqjvVbxVJoxlpl/nr438ymKvVpc8NzIDo4pkCivRfQ7eKv6H9+8fpV2SUlwWBvEcNj8rhzqx9WTZ5x+rdPkXMx2dYlapedCLlClhjm4/WWbLBXjYnp5yf1zLNvRjwl+0/hWUuj1S17/kRaAKzD2zAu1xCUPxNzZWWUq6JnrvYefGe6M2FXd2TIAFmplP37rWHfzIqAc3ggZ9wEgIFSWrLn/Njn8gd40lI9O8GSukHOwkbtntZL5GLZSkVl7Nhj+wLZ4AJWfRtnEtVfO7GEY/HezaieoOIGovS2Lxu825NT1INWMaUrgcqbomz0ulWWE9W8nGlZ0Gt3M+vPFvuyDBFMUSM3GR4j5gHNFrvyBpFBGdegp5Zy4cRGrV9V0XhD/El7csqMan2P18yFSUVrENvciW9duBP1bMloZYNabM5ymLRZvapx4rS93fE1pQzckccajUSnDHWesPfEg5u+xq1EnJ53gXJ8g7GC2CoB/VQ6Npcbcu5DCgo6UMexOuM1w7MQhnK4ULcSmAgvkH3v6y/4uLHBf6BQkAnSWdOc4gLCQjXwnAiLUoJBe8gsjwozT7r0wYFHZNJRpQqVvrSUIDNOGlueZJhnwW6LpFaewu8ureKn9RDWDz/Mktz9SpImE3XAHjwHhsD+86gv3qCkHefBYCNmbSC6Vf+lxWkRq4A/W4UfsOPKCY6vwVv2ICBgJ9+x527vEhnIeaRlC3ua9eocvKSPbhorsg/5Q2T1bQi3k3NaVjA==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0933debc-3334-49f9-fd3d-08db10228c1e
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB6798.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 13:34:37.1926
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MwfJI61OtD3NRns1l96+Zvf1ebtHAzX6etFCxoiFH3T8ZJFy04SP1JAtK7gB54Dw23MZ1kXvswnb598km+FPsg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5336
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22
 definitions=2023-02-16_10,2023-02-16_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0 mlxscore=0
 bulkscore=0 malwarescore=0 phishscore=0 mlxlogscore=999 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2302160116
X-Proofpoint-GUID: UzHdZ-80IUnWMizFt62cVuABqMZq3Dz6
X-Proofpoint-ORIG-GUID: UzHdZ-80IUnWMizFt62cVuABqMZq3Dz6
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 14 Feb 2023, Bjorn Helgaas uttered the following:

> On Tue, Feb 14, 2023 at 03:41:32PM +0000, Nick Alcock wrote:
>> On 13 Feb 2023, Bjorn Helgaas spake thusly:
>> > On Fri, Feb 10, 2023 at 04:47:42PM +0000, Nick Alcock wrote:
>
>> >   - Please follow the subject line convention for each file.  They're
>> >     mostly there after dropping "kbuild", but do capitalize the
>> >     sentence that follows the prefix.  The prefix should always be
>> >     "PCI/<driver-tag>: "
>
> I misspoke about "PCI/<driver-tag>".  I use "PCI/<feature>" for things
> like MSI, AER, ASPM, etc.  "PCI: <driver-tag>" is the usual pattern
> for things specific to a driver, and it sounds like this is what
> you've already done:
>
>   $ git log --oneline drivers/pci/controller/pci-versatile.c
>   6086987bdeb5 PCI: versatile: Remove redundant variable retval
>   b64aa11eb2dd PCI: Set bridge map_irq and swizzle_irq to default functions
>   669cbc708122 PCI: Move DT resource setup into devm_pci_alloc_host_bridge()
>   d3bb94d06aae PCI: Drop unnecessary zeroing of bridge fields
>   6a589900d050 PCI: Set default bridge parent device
>   79cbde56f98b PCI: versatile: Drop flag PCI_ENABLE_PROC_DOMAINS
>   3cf0eead9fb8 PCI: controller: Convert to devm_platform_ioremap_resource()
>   a4b21b858b56 PCI: versatile: Use pci_host_probe() to register host
>   331f63457165 PCI: of: Add inbound resource parsing to helpers
>   2999dea8e94a PCI: versatile: Remove usage of PHYS_OFFSET
>   f9f4fdaa3509 PCI: versatile: Use pci_parse_request_of_pci_ranges()
>   0018b265adf7 PCI: versatile: Fix I/O space page leak

Oh good, that's what I was hoping.

After a bunch more bugfixing It's coming out as 'kbuild, PCI: versatile"
now. (This seems better than 'kbuild: PCI: versatile' because 'PCI:
versatile' isn't a subsystem of 'kbuild'.)

>> ... If the rules for generating prefixes vary by subsystem this means
>> I'll have to fight through God knows how many annoyed maintainers to get
>> this incredibly trivial change in.)
>
> I think your script generally does the right thing, and it's already
> far more than most folks do, so thank you for that!

Heh, I knew it wouldn't be time totally wasted: I've saved time already
on account of having had to redo the individual patches in some way
eight or nine times by now, and being able to make the changes in one go
and split it out into separate commits after that was definitely easier
than the alternative.

FYI: the splitting script's improved a bit. it's still an undocumented,
uncommented horror, but it now supports arbitrary regex-replacements of
"bad prefixes" in a file prefix-transforms.yaml, for this run containing

treewide: ''
fix spelling mistake: ''
task_get_unused_fd_flags: ''
x86/mm/dump_pagetables: 'mm'

I stuffed the splitting script in
https://github.com/nickalcock/linux.git mass-split (as
scripts/kernel-mass-split) just in case it's useful to someone else.
Definitely absolutely not for upstreaming!

(Next tranche coming soon, the previous set again -- improved as
suggested, removing MODULE_LICENSE instead of commenting out, etc -- and
then another, bigger tranche inflicted on a different subset of
maintainers.)

-- 
NULL && (void)