Date:   Thu, 16 Feb 2023 14:54:05 +0100
From:   Larysa Zaremba <larysa.zaremba@intel.com>
To:     Horatiu Vultur <horatiu.vultur@microchip.com>
CC:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH net-next v2] net: lan966x: Use automatic selection of
 VCAP rule actionset
Message-ID: <Y+41fTUfz8Kx6ujH@lincoln>
References: <20230216122907.2207291-1-horatiu.vultur@microchip.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230216122907.2207291-1-horatiu.vultur@microchip.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1ZeMh6w2/pLqPpxGYm7CBdWPqlg4BCERyRIDv+q7GAsOaBadla24x93HkjQt?=
 =?us-ascii?Q?q3b+Bq15/TnnY2F7p3K7AYEzU0uqsdJNfoENmuoHYZQCfIBSoXGJWq4EDi4W?=
 =?us-ascii?Q?widCtpqGAZq0A6npT6TL0hwPVkbAOnry/b4BY3Gp0ZSI4KQrOr/tr9YB37pn?=
 =?us-ascii?Q?OXumJqDZVlwBRQV5+Fo5LV7gT4+x8FC5rvkvolz5fJiws0Gj46FEktGx2Vy3?=
 =?us-ascii?Q?1JqUaLMx15TZEv61JFV3EIsqqwBEx28YWDV0RiAhFwp9DaxduYFzDPjjmihM?=
 =?us-ascii?Q?cHezUuQo30Wict2I7JQe5howKVaKcv4X1cYK7HGe+5F7QsjpVJuRZlBcQPv9?=
 =?us-ascii?Q?CzNK8vO1t+RTDwmu60ZJ/JAkATt23dylvF69Ex+W0P9vkd0KQlOUUpy4WspD?=
 =?us-ascii?Q?g9h8BPHMdoqsgH2kf/u67KiNG0+xcJLasjqYq0A1I9kU3q+V9SuybV0/+q1N?=
 =?us-ascii?Q?+PueMCjGkjERi5qWQr8+BXu/jkC837fbooNTTMHX6Ad0b6o5fG2cTkYtYVVv?=
 =?us-ascii?Q?1rJ4ryfIvORvJygtJjms/UwPnixhss274uoNR5jqy0YVHc9jSJS2Sa96cV1y?=
 =?us-ascii?Q?TQpoJkkrEt8eYEgTsXPON3eaj5ZIu9sec2wynMIumx37L9ccmuqgkrvkslz2?=
 =?us-ascii?Q?eJBHeU8pfp8+OQdEHjkgXm8Df6Fd+PhhoTFWDNn7Gxa9ZIDRcack8E/c9x+E?=
 =?us-ascii?Q?eOvyfa9GO8T8UHz4On7RE6w6K+sJkPiF8XAkEw+PdUIFBmmM5SEgXloVFwKw?=
 =?us-ascii?Q?VxXK9QXGo0LIORKuhZVkPqKJhrCUvexwG6oMv49VEoMO9ACI3lCtTb0IONCB?=
 =?us-ascii?Q?QilO1871x8pWk/ckcRZWed7vhlaIdlGQk8migsy0v97qnojGdkyfCFvMgesS?=
 =?us-ascii?Q?IP6atN0fihdLwcoteAxUpD2E3Gt51YqMljnelYKsTPh9TA7hjUzM7Z6qXjN0?=
 =?us-ascii?Q?itnDp/k8UhGOmFXTZlHMnuHTjZ20J8w2yyH+jCn6Y5eaTV9Q35Rt/I4GfHO3?=
 =?us-ascii?Q?fdMOx/4qjl7Cp5FuGJAaOeZaStLEQR+PnKg+mEW0vzQ90wvPdp2jMUQ6/j2S?=
 =?us-ascii?Q?JLm+wFOp89CBx/M+D8p7RQlARAKmi5hDzKp2eSO0Oxz9lmP0UBuL5jup+Y4N?=
 =?us-ascii?Q?SoEznrXGbgkcQv+5/Uu6+gPr0bZqMnioPqxQY9COc5x04tZb3+rgG5+oS/fc?=
 =?us-ascii?Q?9WMaDzXYUml4hgcabWfhw/grhqJSSkUk/oVc9wSXa1cdaJT6wrMk7quS2da+?=
 =?us-ascii?Q?tyPOix2b4j4OQtfVEoo2ufBNe5cejpT5JRkGtj1RALRxM2ElJaBj/Bm7rhvT?=
 =?us-ascii?Q?LP32DRTShPAitd7eLxp9/dpjWtm31JIhsfPtU3XCD3QjLtg5lCC+Ut9bGOqF?=
 =?us-ascii?Q?y09fTFBwsLfC66LpI2Hl4UvNQZ7yWRcVM+ZfkKPNAXNqFs1dmNOB4uNw36kn?=
 =?us-ascii?Q?FfLJEm+Fukr0KzmLH0F6V4xyF2UziUF/wTdNdnfIQmqTnLi75b01DY3H7pYH?=
 =?us-ascii?Q?4pjdjJCPyQnKm4Y0TmeRsIGN4YpzmtRLF/0rA7YAMp5DEI3tvQfodfiP3Lgg?=
 =?us-ascii?Q?meZMmjBqEf7cM8Q199rik7wdFMGtFglwkA+Yjr1/6G0hXLIwpWm256vxqn24?=
 =?us-ascii?Q?Fg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 95f5e75b-d5c3-46f5-589d-08db1027d650
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5471.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 14:12:29.0290
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: o5ngmOanKbxOg5btCuun7OeU0CBHG1vyBSjmRmzfUz5eBLGuagVld2McOvDNFny/hl4zPGzQN2RQ8FlogmqpUQ5BCsuBrYozsckah3g4usY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8210
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 16, 2023 at 01:29:07PM +0100, Horatiu Vultur wrote:
> Since commit 81e164c4aec5 ("net: microchip: sparx5: Add automatic
> selection of VCAP rule actionset") the VCAP API has the capability to
> select automatically the actionset based on the actions that are attached
> to the rule. So it is not needed anymore to hardcore the actionset in the

I am sure, you've meant 'hardcode'

> driver, therefore it is OK to remove this.
> 
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---
> v1->v2:
> - improve the commit message by mentioning the commit which allows
>   to make this change
> ---
>  drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c b/drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c
> index bd10a71897418..f960727ecaeec 100644
> --- a/drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c
> +++ b/drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c
> @@ -261,8 +261,6 @@ static int lan966x_tc_flower_add(struct lan966x_port *port,
>  							0);
>  			err |= vcap_rule_add_action_u32(vrule, VCAP_AF_MASK_MODE,
>  							LAN966X_PMM_REPLACE);
> -			err |= vcap_set_rule_set_actionset(vrule,
> -							   VCAP_AFS_BASE_TYPE);

Is this the only location, where this can be done? I'm not very familiar with 
this driver, would it maybe make sense to check out lan966x_ptp_add_trap() too?

>  			if (err)
>  				goto out;
>  
> -- 
> 2.38.0
>