Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5FE5C61DA4 for ; Thu, 16 Feb 2023 14:32:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229648AbjBPOcg (ORCPT ); Thu, 16 Feb 2023 09:32:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229512AbjBPOce (ORCPT ); Thu, 16 Feb 2023 09:32:34 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 948794B532 for ; Thu, 16 Feb 2023 06:32:06 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E4D4FB82849 for ; Thu, 16 Feb 2023 14:31:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D9EEC433D2; Thu, 16 Feb 2023 14:31:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676557918; bh=RUTZEaMXXSTE1GT36fjGbfFAAaOaFr35Mks+H/aGDfE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oahkp9pPF91gXoqeFN9aUQrixT4Uf9JJrri3jwp0wpOW2OQh6rLKgVY3B2g8CBeod QIuVZABpVfsdyLFH01kP1La+H5RopAQxIdHcqCiH8jpuxZC35R/g5JC+AI0PClnNOe +6mvIVR76tYzE0fJR6sGZJQStPYcaiDXTdxZHIuQZ+kepo0n57E+YjXQGEGdF3ZleN oTq08p0GvPx4J7vYqKmZosBtzLxHyCHBzfpLkzgpRMO0Qhur3bZE5yki02E4RLdSk4 U8G1npYRjITXl5YWkCEmloPLC3/rNVHgVgCpb4ilHXQm4yfrAyYTf69u+vYfyaXRpo 99rVJNNrqvOdg== Date: Thu, 16 Feb 2023 14:31:55 +0000 From: Mark Brown To: Frieder Schrempf Cc: Frieder Schrempf , Liam Girdwood , linux-kernel@vger.kernel.org, Marek Vasut , ChiYuan Huang , Mauro Carvalho Chehab Subject: Re: [PATCH 4/6] regulator: Add operation to let drivers select vsel register Message-ID: References: <20230213155833.1644366-1-frieder@fris.de> <20230213155833.1644366-5-frieder@fris.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zq0zQGjCg+m9ShoP" Content-Disposition: inline In-Reply-To: X-Cookie: Serving suggestion. Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --zq0zQGjCg+m9ShoP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Feb 16, 2023 at 10:05:49AM +0100, Frieder Schrempf wrote: > Just to be sure: you are suggesting to to leave the core untouched, use > the existing [get/set]_voltage() ops in the driver and reimplement the > logic of regulator_[get/set]_voltage_sel_regmap() there, right? Yes, exactly. If we get a lot of drivers doing this we can always factor out later but it feels premature right now. --zq0zQGjCg+m9ShoP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmPuPloACgkQJNaLcl1U h9CG1wf/TlkZzHFnohsUQT9/jn6taLmpwSpxo2zFAFflRm8kpwEpEL1Q84cFiaFn hLlO740komrW3DhgK7aGxO8NV00xQR3wUTiDCtEKWr1K2oUow/24OiyK8zdRAwBI WsaWJqQc9Rrf04PJcHEKgoPGhhzHX6B2JpSS+G0TPewdO0VmtpqFJRVoWbGWanIr /T0FCPR3/+LcZFR5DAjC+aJDbHZnkD8k+qC4ROZlwnD3jjgVyLu+SXnPXg/7hkfE 6bkPqWGUYJZxBirSo5W0ue7sXZuAkygBthnF9t2aEjc3gVp1wDTx8DbN++RF6Brm p6DddlTx/kPozN3krCU7Vd/y3ayiFQ== =Sl3c -----END PGP SIGNATURE----- --zq0zQGjCg+m9ShoP--