MIME-Version: 1.0
References: <20230208155450.1941608-1-trix@redhat.com> <20230213071241.GA2799422@linux.intel.com>
In-Reply-To: <20230213071241.GA2799422@linux.intel.com>
From:   Oded Gabbay <ogabbay@kernel.org>
Date:   Thu, 16 Feb 2023 16:40:40 +0200
Message-ID: <CAFCwf132HuNbXjQfLe9QjotE6FnwOxUKi99bytp0BbL5GyL0-g@mail.gmail.com>
Subject: Re: [PATCH] habanalabs: change unused extern decl of hdev to forward
 decl of hl_device
To:     Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
Cc:     Tom Rix <trix@redhat.com>, nathan@kernel.org,
        ndesaulniers@google.com, kelbaz@habana.ai, llvm@lists.linux.dev,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Feb 13, 2023 at 9:12 AM Stanislaw Gruszka
<stanislaw.gruszka@linux.intel.com> wrote:
>
> On Wed, Feb 08, 2023 at 07:54:50AM -0800, Tom Rix wrote:
> > Building with clang W=3D2 has several similar warnings
> > drivers/accel/habanalabs/common/decoder.c:46:51: error: declaration sha=
dows a variable in the global scope [-Werror,-Wshadow]
> > static void dec_error_intr_work(struct hl_device *hdev, u32 base_addr, =
u32 core_id)
> >                                                   ^
> > drivers/accel/habanalabs/common/security.h:13:26: note: previous declar=
ation is here
> > extern struct hl_device *hdev;
> >                          ^
> >
> > There is no global definition of hdev, so the extern is not needed.
> > Searched with
> > grep -r '^struct' . | grep hl_dev
> >
> > Change to an forward decl to resolve these issues
> > drivers/accel/habanalabs/common/mmu/../security.h:133:40: error: =E2=80=
=98struct hl_device=E2=80=99 declared inside parameter list will not be vis=
ible outside of this definition or declaration [-Werror]
> >   133 |         bool (*skip_block_hook)(struct hl_device *hdev,
> >       |                                        ^~~~~~~~~
> >
> > Signed-off-by: Tom Rix <trix@redhat.com>
> Reviewed-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
>
> > ---
> >  drivers/accel/habanalabs/common/security.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/accel/habanalabs/common/security.h b/drivers/accel=
/habanalabs/common/security.h
> > index 234b4a6ed8bc..d7a3b3e82ea4 100644
> > --- a/drivers/accel/habanalabs/common/security.h
> > +++ b/drivers/accel/habanalabs/common/security.h
> > @@ -10,7 +10,7 @@
> >
> >  #include <linux/io-64-nonatomic-lo-hi.h>
> >
> > -extern struct hl_device *hdev;
> > +struct hl_device;
> >
> >  /* special blocks */
> >  #define HL_MAX_NUM_OF_GLBL_ERR_CAUSE         10
> > --
> > 2.26.3
> >
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Thanks, applied to -next.
Oded