MIME-Version: 1.0
References: <20230213144814.2225707-1-trix@redhat.com>
In-Reply-To: <20230213144814.2225707-1-trix@redhat.com>
From:   Oded Gabbay <ogabbay@kernel.org>
Date:   Thu, 16 Feb 2023 16:43:46 +0200
Message-ID: <CAFCwf10pZbtrVkLEjH07KMcMU7giF8Z-ok8vX5mYGaGf-iGxfQ@mail.gmail.com>
Subject: Re: [PATCH] habanalabs: set hl_capture_*_err storage-class-specifier
 to static
To:     Tom Rix <trix@redhat.com>
Cc:     ttayar@habana.ai, gregkh@linuxfoundation.org, dliberman@habana.ai,
        osharabi@habana.ai, dhirschfeld@habana.ai,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Feb 13, 2023 at 4:48 PM Tom Rix <trix@redhat.com> wrote:
>
> smatch reports
> drivers/accel/habanalabs/common/device.c:2619:6: warning:
>   symbol 'hl_capture_hw_err' was not declared. Should it be static?
> drivers/accel/habanalabs/common/device.c:2641:6: warning:
>   symbol 'hl_capture_fw_err' was not declared. Should it be static?
>
> both are only used in device.c, so they should be static
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/accel/habanalabs/common/device.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/accel/habanalabs/common/device.c b/drivers/accel/habanalabs/common/device.c
> index fefe70bbbede..a5f5ee102823 100644
> --- a/drivers/accel/habanalabs/common/device.c
> +++ b/drivers/accel/habanalabs/common/device.c
> @@ -2616,7 +2616,7 @@ void hl_handle_page_fault(struct hl_device *hdev, u64 addr, u16 eng_id, bool is_
>                 *event_mask |=  HL_NOTIFIER_EVENT_PAGE_FAULT;
>  }
>
> -void hl_capture_hw_err(struct hl_device *hdev, u16 event_id)
> +static void hl_capture_hw_err(struct hl_device *hdev, u16 event_id)
>  {
>         struct hw_err_info *info = &hdev->captured_err_info.hw_err;
>
> @@ -2638,7 +2638,7 @@ void hl_handle_critical_hw_err(struct hl_device *hdev, u16 event_id, u64 *event_
>                 *event_mask |= HL_NOTIFIER_EVENT_CRITICL_HW_ERR;
>  }
>
> -void hl_capture_fw_err(struct hl_device *hdev, struct hl_info_fw_err_info *fw_info)
> +static void hl_capture_fw_err(struct hl_device *hdev, struct hl_info_fw_err_info *fw_info)
>  {
>         struct fw_err_info *info = &hdev->captured_err_info.fw_err;
>
> --
> 2.26.3
>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Thanks, applied to -next.
Oded