Date:   Thu, 16 Feb 2023 15:15:39 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Lucas Tanure <lucas.tanure@collabora.com>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Vijendar Mukunda <Vijendar.Mukunda@amd.com>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        kernel@collabora.com
Subject: Re: [PATCH 2/9] ASoC: amd: vangogh: Update code indentation
Message-ID: <Y+5Im/6wsqNQ8FYo@sirena.org.uk>
References: <20230216103300.360016-1-lucas.tanure@collabora.com>
 <20230216103300.360016-3-lucas.tanure@collabora.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="5riVcraAeE+0JMsT"
Content-Disposition: inline
In-Reply-To: <20230216103300.360016-3-lucas.tanure@collabora.com>
Precedence: bulk


--5riVcraAeE+0JMsT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 16, 2023 at 10:32:53AM +0000, Lucas Tanure wrote:
> Make use of 100 character limit and modify indentation so code is
> easier to read.

I'm having a hard time seeing this as a helpful=20

> While at it:
>  - sort includes in alphabetical order
>  - sort variables declarations by line length
>  - use smaller variables names
>  - remove unnecessary "struct snd_soc_card *card" lines
>  - insert blank lines before return
>  - align defines

This isn't helping make things easier to review :/

> -static int acp5x_8821_startup(struct snd_pcm_substream *substream)
> +static int acp5x_8821_startup(struct snd_pcm_substream *sub)

We do usually refer to substreams as such, I'm not sure this is
really helping.

> -	snd_pcm_hw_constraint_list(runtime, 0, SNDRV_PCM_HW_PARAM_CHANNELS,
> -				   &constraints_channels);
> +	snd_pcm_hw_constraint_list(runtime, 0, SNDRV_PCM_HW_PARAM_CHANNELS, &co=
nstraints_channels);

I'm having a *really* hard time seeing this as helping with
legibility, it just makes things worse when viewed at 80 columns
but it's hard to see what it helps.  The 100 column limit is
flexibility we can use to avoid contortions but this is fairly
natural.

--5riVcraAeE+0JMsT
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmPuSJsACgkQJNaLcl1U
h9Bkpgf9He+GgisvMXfHzovOeUmaexSlr7cC8udBT98h0ba00jKK6TKSwlhxQbC9
P42L20e/Zorz014nCe42Srv9gRCllVenYG0lQZbIJ567xRuW02yP5pPHIcxJunRE
3JNtDONZ5pxl/rJC1A/wGpPTQRVCYcudtimB3jYTTx29/8Brfv+HzWNOCHOgQvn5
9Zw6Xo1wXSOhC3qQBHs3N8iQfyL6RJ2KRZ18twgw3aWTNs1yu9rBA2/hQEfSDJk1
JEvlWx+q3uIta3UFMmLiaIYScpW1S7KkIOdQNN1x/0kMiVSvszC94L2eo+K/OS+c
Ka2Q4PN+/taP2AnLQSmn1FhyqZ7DjA==
=onrk
-----END PGP SIGNATURE-----

--5riVcraAeE+0JMsT--