Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DEC2C64ED6 for ; Thu, 16 Feb 2023 15:16:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230148AbjBPPQ3 (ORCPT ); Thu, 16 Feb 2023 10:16:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230017AbjBPPQ1 (ORCPT ); Thu, 16 Feb 2023 10:16:27 -0500 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC32F48E32; Thu, 16 Feb 2023 07:16:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676560582; x=1708096582; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=hyvrL3VPiM3hBe27Vo+7YLaXTY2ZmoTK1UQfWn9rojw=; b=Crwo6lbsQ3nzD/dPh9DlsBMtw4SFwK/9HB1bBR2fQbwO1goeZ1vuXDZL a+m4aGSKljNeQ/YN8jZZXqXVC+SBqo6LIO00XLWNydsDA6rr8CcWVXEi3 g++tAZH9+JCLyqKEfqkCFNlEk3c0IgSg990achUcYwZwpsFEGjk+UDCyZ mSvPzrh0v4xr4rRAQpXRiepwwdnQQYT4GVfPVeltOLnD2UX6CxWsbi3Cx zX8VaHaBVfPEB9V9mnouFab5P3wgqlIqNRQpJBV9h5QH+sRcOBy3MVPaP +9U9yr1SFBQA2GOQTJgtW1l60KC7ityvgvUx3rNYZIfqcvN9paZ4mIpxE w==; X-IronPort-AV: E=McAfee;i="6500,9779,10623"; a="312101385" X-IronPort-AV: E=Sophos;i="5.97,302,1669104000"; d="scan'208";a="312101385" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Feb 2023 07:16:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10623"; a="663496371" X-IronPort-AV: E=Sophos;i="5.97,302,1669104000"; d="scan'208";a="663496371" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga007.jf.intel.com with ESMTP; 16 Feb 2023 07:16:11 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pSfzT-007ppX-2j; Thu, 16 Feb 2023 17:16:07 +0200 Date: Thu, 16 Feb 2023 17:16:07 +0200 From: Andy Shevchenko To: Pawel Chmielewski Cc: Jonathan.Cameron@huawei.com, baohua@kernel.org, bristot@redhat.com, bsegall@google.com, davem@davemloft.net, dietmar.eggemann@arm.com, gal@nvidia.com, gregkh@linuxfoundation.org, hca@linux.ibm.com, jacob.e.keller@intel.com, jesse.brandeburg@intel.com, jgg@nvidia.com, juri.lelli@redhat.com, kuba@kernel.org, leonro@nvidia.com, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, linux@rasmusvillemoes.dk, mgorman@suse.de, mingo@redhat.com, netdev@vger.kernel.org, peter@n8pjl.ca, peterz@infradead.org, rostedt@goodmis.org, saeedm@nvidia.com, tariqt@nvidia.com, tony.luck@intel.com, torvalds@linux-foundation.org, ttoukan.linux@gmail.com, vincent.guittot@linaro.org, vschneid@redhat.com, yury.norov@gmail.com Subject: Re: [PATCH v2 1/1] ice: Change assigning method of the CPU affinity masks Message-ID: References: <20230208153905.109912-1-pawel.chmielewski@intel.com> <20230216145455.661709-1-pawel.chmielewski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 16, 2023 at 05:14:33PM +0200, Andy Shevchenko wrote: > On Thu, Feb 16, 2023 at 03:54:55PM +0100, Pawel Chmielewski wrote: ... > > + for_each_cpu_andnot(cpu, aff_mask, last_aff_mask) { > > + if (v_idx >= vsi->num_q_vectors) > > > + goto out; > > Useless. You can return 0; here. > > > + } Btw, I briefly checked the other functions nearby in the code and none of them is using goto for OK cases. -- With Best Regards, Andy Shevchenko