Date:   Thu, 16 Feb 2023 17:14:32 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Pawel Chmielewski <pawel.chmielewski@intel.com>
Cc:     Jonathan.Cameron@huawei.com, baohua@kernel.org, bristot@redhat.com,
        bsegall@google.com, davem@davemloft.net, dietmar.eggemann@arm.com,
        gal@nvidia.com, gregkh@linuxfoundation.org, hca@linux.ibm.com,
        jacob.e.keller@intel.com, jesse.brandeburg@intel.com,
        jgg@nvidia.com, juri.lelli@redhat.com, kuba@kernel.org,
        leonro@nvidia.com, linux-crypto@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
        linux@rasmusvillemoes.dk, mgorman@suse.de, mingo@redhat.com,
        netdev@vger.kernel.org, peter@n8pjl.ca, peterz@infradead.org,
        rostedt@goodmis.org, saeedm@nvidia.com, tariqt@nvidia.com,
        tony.luck@intel.com, torvalds@linux-foundation.org,
        ttoukan.linux@gmail.com, vincent.guittot@linaro.org,
        vschneid@redhat.com, yury.norov@gmail.com
Subject: Re: [PATCH v2 1/1] ice: Change assigning method of the CPU affinity
 masks
Message-ID: <Y+5IWLpC1uTaa4Ks@smile.fi.intel.com>
References: <20230208153905.109912-1-pawel.chmielewski@intel.com>
 <20230216145455.661709-1-pawel.chmielewski@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230216145455.661709-1-pawel.chmielewski@intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Thu, Feb 16, 2023 at 03:54:55PM +0100, Pawel Chmielewski wrote:
> With the introduction of sched_numa_hop_mask() and for_each_numa_hop_mask(),
> the affinity masks for queue vectors can be conveniently set by preferring the
> CPUs that are closest to the NUMA node of the parent PCI device.

...

> +	v_idx = 0;

> +

Redundant blank line.

> +	for_each_numa_hop_mask(aff_mask, numa_node) {
> +		for_each_cpu_andnot(cpu, aff_mask, last_aff_mask) {
> +			if (v_idx >= vsi->num_q_vectors)

> +				goto out;

Useless. You can return 0; here.

> +			if (cpu_online(cpu)) {
> +				cpumask_set_cpu(cpu, &vsi->q_vectors[v_idx]->affinity_mask);
> +				v_idx++;
> +			}
> +		}
> +
> +		last_aff_mask = aff_mask;
> +	}
> +
> +out:
>  	return 0;

-- 
With Best Regards,
Andy Shevchenko