Date:   Thu, 16 Feb 2023 15:37:20 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Lucas Tanure <lucas.tanure@collabora.com>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Vijendar Mukunda <Vijendar.Mukunda@amd.com>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        kernel@collabora.com
Subject: Re: [PATCH 8/9] ASoC: amd: vangogh: Centralize strings definition
Message-ID: <Y+5NsB/Z5P+rVGbX@sirena.org.uk>
References: <20230216103300.360016-1-lucas.tanure@collabora.com>
 <20230216103300.360016-9-lucas.tanure@collabora.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="qdQDcYIyMx1V5VX8"
Content-Disposition: inline
In-Reply-To: <20230216103300.360016-9-lucas.tanure@collabora.com>
Precedence: bulk


--qdQDcYIyMx1V5VX8
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Feb 16, 2023 at 10:32:59AM +0000, Lucas Tanure wrote:

> Replace occurrences of strings by their definition, avoiding bugs where
> the string changed, but not all places have been modified

>  #define DRV_NAME			"acp5x_mach"
>  #define DUAL_CHANNEL			2
> -#define ACP5X_NUVOTON_CODEC_DAI		"nau8821-hifi"
>  #define VG_JUPITER			1
> -#define ACP5X_NUVOTON_BCLK		3072000
> -#define ACP5X_NAU8821_FREQ_OUT		12288000
> +#define NAU8821_BCLK			3072000
> +#define NAU8821_FREQ_OUT		12288000
> +#define NAU8821_DAI			"nau8821-hifi"
> +#define CS35L41_LNAME			"spi-VLV1776:00"
> +#define CS35L41_RNAME			"spi-VLV1776:01"
> +#define CS35L41_DAI			"cs35l41-pcm"

These changes don't obviously correspond to the description of
the patch.  It looks like there's at least some renaming and
reindentation of things not related to DAI names here.  TBH I'm
not sure the removal of namespacing is a good idea, it's probably
not *super* likely but we might run into collisions.

--qdQDcYIyMx1V5VX8
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmPuTbAACgkQJNaLcl1U
h9CM/wgAhRWIiQuG2HbuVN3no2Nu6aNxDlLnUyWqA56pB1z0yMBH8FUpGknpjCN2
gdXiAARXV9SzsasDJuDR7j1K7XDGV0HzQfmkRTsr7tFdvcmGqcX1VJpfPZHUaYLT
TbrM3xmhCxJl0b4q9SErRcVnXigBqliQdQKP059F3S6QqSn0TfMu6be5Dem5AhS1
BMuk64l4HKZkpn6zEJqmGzDv2gM+goq4gEZpo7MCwYdpSehUUT0xY1eR0T8/tUfr
HC50ADfLeWqb3iMCN0kuUVPh/8lEELOY5dxpUSzb+B8oZ+i6lrDJQWWjUXEDw0iE
b7W3A65dk2wwRFiL8K18FpSMdj3D9w==
=xmrC
-----END PGP SIGNATURE-----

--qdQDcYIyMx1V5VX8--