Date:   Thu, 16 Feb 2023 13:32:14 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Jiri Olsa <olsajiri@gmail.com>
Cc:     Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>,
        Ian Rogers <irogers@google.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        Song Liu <song@kernel.org>,
        Stephane Eranian <eranian@google.com>,
        Ravi Bangoria <ravi.bangoria@amd.com>,
        Leo Yan <leo.yan@linaro.org>,
        James Clark <james.clark@arm.com>, Hao Luo <haoluo@google.com>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-perf-users@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH 4/7] perf record: Record dropped sample count
Message-ID: <Y+5ajnitOAxjdn2C@kernel.org>
References: <20230214050452.26390-1-namhyung@kernel.org>
 <20230214050452.26390-5-namhyung@kernel.org>
 <Y+5YaQt7Fme65a78@krava>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y+5YaQt7Fme65a78@krava>
Precedence: bulk

Em Thu, Feb 16, 2023 at 05:23:05PM +0100, Jiri Olsa escreveu:
> On Mon, Feb 13, 2023 at 09:04:49PM -0800, Namhyung Kim wrote:
> 
> SNIP
> 
> > @@ -1929,12 +1923,27 @@ static void record__read_lost_samples(struct record *rec)
> >  
> >  		for (int x = 0; x < xyarray__max_x(xy); x++) {
> >  			for (int y = 0; y < xyarray__max_y(xy); y++) {
> > -				__record__read_lost_samples(rec, evsel, lost, x, y);
> > +				struct perf_counts_values count;
> > +
> > +				if (perf_evsel__read(&evsel->core, x, y, &count) < 0) {
> > +					pr_err("read LOST count failed\n");
> > +					goto out;
> > +				}
> > +
> > +				if (count.lost) {
> > +					__record__save_lost_samples(rec, evsel, lost,
> > +								    x, y, count.lost, 0);
> > +				}
> >  			}
> >  		}
> > +
> > +		lost_count = perf_bpf_filter__lost_count(evsel);
> > +		if (lost_count)
> > +			__record__save_lost_samples(rec, evsel, lost, 0, 0, lost_count,
> > +						    PERF_RECORD_MISC_LOST_SAMPLES_BPF);
> 
> hi,
> I can't see PERF_RECORD_MISC_LOST_SAMPLES_BPF in the tip/perf/core so can't compile,
> what do I miss?

Humm, but you shouldn't need kernel headers to build tools/perf/, right?

- Arnaldo