Message-ID: <765313c2-c2d7-9450-aabd-29c471f82ce5@arinc9.com>
Date:   Thu, 16 Feb 2023 19:32:13 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH v2 2/2] pinctrl: add mt7981 pinctrl driver
To:     Daniel Golle <daniel@makrotopia.org>
Cc:     linux-gpio@vger.kernel.org, linux-mediatek@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Sean Wang <sean.wang@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Chen-Yu Tsai <wenst@chromium.org>,
        Miles Chen <miles.chen@mediatek.com>,
        Edward-JW Yang <edward-jw.yang@mediatek.com>,
        Johnson Wang <johnson.wang@mediatek.com>,
        Fabien Parent <fparent@baylibre.com>,
        Sam Shih <sam.shih@mediatek.com>,
        Jianhui Zhao <zhaojh329@gmail.com>
References: <cover.1674693008.git.daniel@makrotopia.org>
 <ef5112946d16cacc67e65e439ba7b52a9950c1bb.1674693008.git.daniel@makrotopia.org>
 <88ef812b-b8e8-f640-f9f7-a1579ea69d31@arinc9.com>
 <Y+5ZSUURaK/hq1iq@makrotopia.org>
Content-Language: en-US
From:   =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= <arinc.unal@arinc9.com>
In-Reply-To: <Y+5ZSUURaK/hq1iq@makrotopia.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 16.02.2023 19:26, Daniel Golle wrote:
> On Thu, Feb 16, 2023 at 04:50:57PM +0300, Arınç ÜNAL wrote:
>> Hi Daniel,
>>
>> On 26.01.2023 03:34, Daniel Golle wrote:
>>> Add pinctrl driver for the MediaTek MT7981 SoC, based on the driver
>>> which can also be found the SDK.
>>>
>>> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
>>> ---
>>>    drivers/pinctrl/mediatek/Kconfig          |    5 +
>>>    drivers/pinctrl/mediatek/Makefile         |    1 +
>>>    drivers/pinctrl/mediatek/pinctrl-mt7981.c | 1048 +++++++++++++++++++++
>>>    3 files changed, 1054 insertions(+)
>>>    create mode 100644 drivers/pinctrl/mediatek/pinctrl-mt7981.c
>>>
>>> diff --git a/drivers/pinctrl/mediatek/Kconfig b/drivers/pinctrl/mediatek/Kconfig
>>> index fed02c6fea062..f20c28334bcbf 100644
>>> --- a/drivers/pinctrl/mediatek/Kconfig
>>> +++ b/drivers/pinctrl/mediatek/Kconfig
>>> @@ -127,6 +127,11 @@ config PINCTRL_MT7622
>>>    	default ARM64 && ARCH_MEDIATEK
>>>    	select PINCTRL_MTK_MOORE
>>> +config PINCTRL_MT7981
>>> +	bool "Mediatek MT7981 pin control"
>>> +	depends on OF
>>> +	select PINCTRL_MTK_MOORE
>>> +
>>
>> Is there a reason why you removed these lines from v1?
> 
> Oh, that seemed to have happened by accident. Imho it'd be better
> to have these two lines there as well.

Agreed. I'm preparing some patches to move the pinctrl driver for the 
MediaTek MIPS SoCs here, this driver appears on the menuconfig even 
though it shouldn't. Will you fix this yourself, or I can do it and add 
it to my upcoming patch series.

Arınç