From:   SeongJae Park <sj@kernel.org>
To:     David Hildenbrand <david@redhat.com>
Cc:     SeongJae Park <sj@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Oscar Salvador <osalvador@suse.de>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] mm/memory_hotplug: return nothing from do_migrate_range()
Date:   Thu, 16 Feb 2023 16:51:02 +0000
Message-Id: <20230216165102.64115-1-sj@kernel.org>
In-Reply-To: <9c274928-1118-1b31-9aff-07cd246cbbcf@redhat.com>
References: 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi David,

On Thu, 16 Feb 2023 10:46:59 +0100 David Hildenbrand <david@redhat.com> wrote:

> On 16.02.23 00:02, SeongJae Park wrote:
> > Return value mechanism of do_migrate_range() is not very simple, while
> > no caller of the function checks the return value.  Make the function
> > return nothing to be more simple.
> > 
> > Suggested-by: David Hildenbrand <david@redhat.com>
> > Signed-off-by: SeongJae Park <sj@kernel.org>
> > ---
> >   mm/memory_hotplug.c | 5 +----
> >   1 file changed, 1 insertion(+), 4 deletions(-)
> > 
> > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> > index bcb0dc41c2f2..6c615ba1a5c7 100644
> > --- a/mm/memory_hotplug.c
> > +++ b/mm/memory_hotplug.c
> > @@ -1620,8 +1620,7 @@ static int scan_movable_pages(unsigned long start, unsigned long end,
> >   	return 0;
> >   }
> >   
> > -static int
> > -do_migrate_range(unsigned long start_pfn, unsigned long end_pfn)
> > +static void do_migrate_range(unsigned long start_pfn, unsigned long end_pfn)
> >   {
> >   	unsigned long pfn;
> >   	struct page *page, *head;
> > @@ -1721,8 +1720,6 @@ do_migrate_range(unsigned long start_pfn, unsigned long end_pfn)
> >   			putback_movable_pages(&source);
> >   		}
> >   	}
> > -
> > -	return ret;
> >   }
> 
> I think this patch should also stop initializing ret = 0 inside that 
> function.

The second patch does it, and I read your reply to the patch asking squashing
it in this one.  I will send the new version soon.

> 
> With that
> 
> Acked-by: David Hildenbrand <david@redhat.com>

Thanks you.


Thanks,
SJ

> 
> -- 
> Thanks,
> 
> David / dhildenb
> 
>