Message-ID: <fb29db5d-645b-86c7-c31c-738df55687ab@intel.com>
Date:   Thu, 16 Feb 2023 17:56:05 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH -next] can: ctucanfd: Use devm_platform_ioremap_resource()
Content-Language: en-US
To:     Yang Li <yang.lee@linux.alibaba.com>
CC:     <kuba@kernel.org>, <davem@davemloft.net>, <edumazet@google.com>,
        <pisa@cmp.felk.cvut.cz>, <ondrej.ille@gmail.com>,
        <wg@grandegger.com>, <mkl@pengutronix.de>, <pabeni@redhat.com>,
        <linux-can@vger.kernel.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20230216090610.130860-1-yang.lee@linux.alibaba.com>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <20230216090610.130860-1-yang.lee@linux.alibaba.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MWNFNVNtOWZnaFU1cEJFa0xMNkMwRFJCQkxMOS9QK3YrbWhDZEE0MUgvQUZl?=
 =?utf-8?B?eUVzV3BvUWRSdElRM2Q2RWlUL1hYQkZrQkMvZkcwK0c3Qks3SG9KMFVIWXNk?=
 =?utf-8?B?a3NUZnh4ampINUx6L0crUmFLclVYVHRzTm11a0ozT052WDJNdnFEU3dpRWhy?=
 =?utf-8?B?SVZ4RTZraXpVMURvZEE5SWRLeDZIQ292b3RFbnJnSStFRTVhVVc2bm5rWTZL?=
 =?utf-8?B?VDY5QVJza1N4bjhZdVhaeVZ3SlZvS2pxNjZjSUpUTktnendJa2Z3WVZHdTBN?=
 =?utf-8?B?S2VsZkdma1FLUHdyUnlYR3lNRnVTblBDek9wOWlWS0diYWpHTlpvMExOTkhE?=
 =?utf-8?B?T3dxWkhmNjJWSHcyWGp0b2FtNk5QOCtkMmY2UEV0ZjVjYlluejlBTFdSR0VY?=
 =?utf-8?B?UmZxdGJpck9WTExOTDlWa3AvT2lJakRnbGUybGI1ekNzRmRlMlVkMGErWHda?=
 =?utf-8?B?WE1LK01FSi9FaSttWjBaejJMOEZPcXBtM0plbTlwZHpiL2Z0QzVXK2dJcVBX?=
 =?utf-8?B?YUdMclZpa1VJcHhJUTFoNUFNU1B5V1o4VEVEbGd2bUdCZXh1VFJ2TzErUXdS?=
 =?utf-8?B?UmFTZkhwZnFMNzVQVGM4Mi9XRzFsUDdoUHhNTnVVVWtkYjZOZWpSWEpScXcw?=
 =?utf-8?B?aVRaV0NQZ1FtZUlOZEFLbnJVTEVabk9ZNERBTkEvSGlqNTNzQThweW9kOXhy?=
 =?utf-8?B?enhFZmlSRzh5TkRGL0dFZzhKNVJtY3YwUzFUL1RISTdQNmJDQ3UySzJ4RHY2?=
 =?utf-8?B?c1BreE5rWEE0QXlTUjk3SmsxSGNBTnAraHVYMVkvbmNSakpLRXNGS0thNzJo?=
 =?utf-8?B?SFY1SHk5UUppTXlhT0RNcXRoZ1ZpWXMxamNtQUVsTjRRTXRHeTdNMHphUndF?=
 =?utf-8?B?cTFSamRlZXNXbUpQMUZWSjZwT0x0V2dUWTV4YkFpZnFET3NJM3VlUHdad25p?=
 =?utf-8?B?ZnlNcWhDQ294c1pMWStrbUtETmhXSldJQm1nV0s5czNWZzJtVTdBQ1hJdVls?=
 =?utf-8?B?REd0c09qdks2UXYzYkkyMVNQdG53eFFPNDBXYzNMcExoWGNVdnhPeTJiMHln?=
 =?utf-8?B?WmRQWEJ6OHpZdXh3MXdDNXkxZ2d0cHZyUTlxZGVMb1BrNGxOYTZ3MmJUUW5M?=
 =?utf-8?B?Wm9NVXZ6TWxLT1paN1p6WUhmU2x5M0lqREpDUlJTeWM5N2lUTWxtd1hzV2dh?=
 =?utf-8?B?T2xDYmo4L2JtbGQ2WUdMSGpodkFjWFVqbFIrY0JoOW1rWEZFaFFzLzBJK0Jx?=
 =?utf-8?B?dmtmalBQWHdlT1B3TnBFUU9HUlFWVFRuSnYwOXRWOGlyL055Uys4b3dVMnNK?=
 =?utf-8?B?VzJ0NUxOOU9zMEJVb0Fzc1NpWGZWcjNEYU1Yb3JNYjY1Nzg4clU1ZXZVeHMz?=
 =?utf-8?B?MUhBU25BWkpUdHpOVTlaNzYyYU1LR1JYMElXS2FSV3RZM0xJdWZOQzlvb2Rm?=
 =?utf-8?B?QlhNNnNvTzIwaXpVUG9Yb1hoRk9uWXUxNTQ2ZVFublBlOFpzNC80bmk0NWdT?=
 =?utf-8?B?bTlpQmFhb2w4R1NsMkRVeEZzRkZ3eitVeTVQdy9VY0pCb2VLRjNLUjFHK0Jk?=
 =?utf-8?B?d21YMWMrWGQzR2lsZVVtdWFlOHZQSDRiemQ3S3NmTDZVbUFSUkUvR08yNS9B?=
 =?utf-8?B?UjNVUmZuSHg4VjhWRU1KSm9kWXA2Vjg3SFJ6bEZqVFRTOUpiWTY4MGN4U21Z?=
 =?utf-8?B?YVlWZFFPWFBQc1hjeGxlMUNMdzl4R204SkhRT21leTFXaDliREVGOHYwd2VZ?=
 =?utf-8?B?eC9XNXphSVpsRzkzRzNSY0dQcDBjWkdsYWtHTzRLT3ViV3RIWTA3QXRCVDZZ?=
 =?utf-8?B?c25BQjBiNExKamtkRUI4eXdrY3Y4UTd4eGdjWk1NMkFEUS9MNXBhT1E2WW9t?=
 =?utf-8?B?VFg3SVNGSGdRSlZKeENEU0pLakdxWXZ1MzU5VW92Ly9GZlRSS1JJYVh6bDFV?=
 =?utf-8?B?eS96ci85Z2p5a3orekRoYVhIRUpRMFUvY2Nmd0xlTzNDNUFNNGJ4VnI0QXdL?=
 =?utf-8?B?OWZjcE5BZ2FIVEdXU0NBR2JjZ1JjZHZhL0hWWUtQT29ETDFHZE5JcEdtRVJV?=
 =?utf-8?B?bGdGdkJYZmNzN3laQ3VJeHJuUHI0Y1p1VWhxZzRESnlEb0VJdlA1Nnl4dk44?=
 =?utf-8?B?aTR3VUtPcVlPNWVrYnkvZHRFVk91cFRBeU10dTFzZFFXL2Z1NHRyVzNpZ1Fl?=
 =?utf-8?Q?75E+nTq0Bnx2bolov9E5sm0=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ad923a93-89ae-4dbe-9e87-08db103ee63e
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 16:57:34.2593
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vO1ZxIbKGGzxVrY7g0fhuwIgq3nHyU7HspRDy2Rlg3L3I/FmNhGcyb9TvOKXM7SRs7eFfK7vK6ccqVa3utdMYyQ2zyQ+5ain/NATVgzA7Sg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7302
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Yang Li <yang.lee@linux.alibaba.com>
Date: Thu, 16 Feb 2023 17:06:10 +0800

> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to Use devm_platform_ioremap_resource(), as this is exactly
> what this function does.
> 
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>

> ---
>  drivers/net/can/ctucanfd/ctucanfd_platform.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/net/can/ctucanfd/ctucanfd_platform.c b/drivers/net/can/ctucanfd/ctucanfd_platform.c
> index f83684f006ea..a17561d97192 100644
> --- a/drivers/net/can/ctucanfd/ctucanfd_platform.c
> +++ b/drivers/net/can/ctucanfd/ctucanfd_platform.c
> @@ -47,7 +47,6 @@ static void ctucan_platform_set_drvdata(struct device *dev,
>   */
>  static int ctucan_platform_probe(struct platform_device *pdev)
>  {
> -	struct resource *res; /* IO mem resources */
>  	struct device	*dev = &pdev->dev;
>  	void __iomem *addr;
>  	int ret;
> @@ -55,8 +54,7 @@ static int ctucan_platform_probe(struct platform_device *pdev)
>  	int irq;
>  
>  	/* Get the virtual base address for the device */
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	addr = devm_ioremap_resource(dev, res);
> +	addr = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(addr)) {
>  		ret = PTR_ERR(addr);
>  		goto err;
Thanks,
Olek