Message-ID: <597822c9-b859-7a08-6987-1d8a552f6f32@intel.com>
Date:   Thu, 16 Feb 2023 18:05:53 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [Patch] [testing][wireguard] Remove unneeded version.h include
 pointed out by 'make versioncheck'
Content-Language: en-US
To:     Jesper Juhl <jesperjuhl76@gmail.com>
CC:     <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
        <netdev@vger.kernel.org>, <wireguard@lists.zx2c4.com>,
        "Jason A. Donenfeld" <Jason@zx2c4.com>,
        Shuah Khan <shuah@kernel.org>, Jakub Kicinski <kuba@kernel.org>
References: <83474b0e-9e44-642f-10c9-2e0ff94b06ca@gmail.com>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <83474b0e-9e44-642f-10c9-2e0ff94b06ca@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q05wSEQzT2w5VHFISCt5SjdOT1JCaFlGcittcFhsWUp4SHR5ZUN2Z2RSTDE1?=
 =?utf-8?B?enJiOG55a1BVaVlwV3dTSkVBRzFjUTZYclBJU3dZWG5EaS9YSVNwQ3BHQm40?=
 =?utf-8?B?ekpQQ2JVNlJZY1FzS0VpckJERitNZFh6cXc5TlpHeWYxdWYzSkxEZjZEbHVr?=
 =?utf-8?B?OHdKdEZZaEt6OXFxWFJCY2hzeEdRRE11VHp4MjhRVEpkMzNXSzNOVTQrQ1FF?=
 =?utf-8?B?RDBvY3ZHcGlHZmlvNFVmSW10d091VzFHcDl4Wndzejhnc3A4d2pWOTdhUDBw?=
 =?utf-8?B?cGhFMlVGRU5ML2FsSTY2MmZ2RHArY0hRbncvWWNmTTVmdXo0V3pNR0tleFp2?=
 =?utf-8?B?VFByRTdWT2hqc2pLUC9hQUNaTE41WWo5ZjBkTlFnVGxSS0huY1IybW03bU83?=
 =?utf-8?B?Q3ZTMVJoVmtHZk4wcGlIRzlqSWgvTGRCeFBDL1VIT2JPRkhQaFYxaWN2VGJD?=
 =?utf-8?B?MHErTGhqYU9HblQrYjFzWXpWY0tzZldQNHRQeDhMUlk0WHdEMDZsWXRRbERn?=
 =?utf-8?B?ZnBGWXNlSTNkWmszQTRoT2ROcE1qcWZLbm9FUWp1QWwrR1BKdFpScHZZMkdh?=
 =?utf-8?B?dDRjU2RORTVOQnVENU1MbVpXczR6SGpqaHNWWXh4YVIzN2pTM1k1eUZBZkhO?=
 =?utf-8?B?TGdrcFZKMVFiSURzOUg1SDFnbmFZL0tQTXlWTmFWWWRGYWg5TlRqYzRqYzRl?=
 =?utf-8?B?Unpkek1zMkJObE1IV1FSZ29mNThBekdreTlaTU5haFZKcmV0NXIrUzV6RmFT?=
 =?utf-8?B?Q0hBSzZOZjVGU0dKWmVKVnFTR0R4bzFGNWFRV25abStXVitremdJL1REdEJF?=
 =?utf-8?B?TmJubXZ3cVRlNHg4WmRQUjM2RENQbkdTbHFZNVdBZHRvWGYvNGJ5Um9WclJp?=
 =?utf-8?B?Q3R2MVFWYkVtSXgvUS9yZm9uVkVWREdLWTdZUzYwSUtHVjFScllHL05qYlFj?=
 =?utf-8?B?YnZ0L0daYTdiY2tjK3ZHRVdNcUZMbVhRRzUzMWZDY2Z5NDBvYTZFcDMwMVFN?=
 =?utf-8?B?cXQ4R2xoUUxzNmcvQ0QyV29CbGVHdWFSbzdKTitoVnNjdU5iMEhudHdWTk5E?=
 =?utf-8?B?YlB5dUJEemRoL09zUFJ4WC92UkgwSGM4dG9rMFd1MUN1ejd0dUdzTEZwSS91?=
 =?utf-8?B?QkJtUGRERUJSOHRFa3RkSE5nN3ZwVXFmY0hrc0dYSExPcVp4WXlJOHZzTEVW?=
 =?utf-8?B?L1BINE9wNWdGbVVZOHFJUXkxc3YxS3QvNk4wa3Zkd3daQW5hWHZoU2JGOCs5?=
 =?utf-8?B?RXNaeS9mbVNoS214eUFnbTZIbjNheW9mWjhxcUVQd1FWdnN4R2ZpTDM2cVUw?=
 =?utf-8?B?TVUxMEJRNlVZZXlzZFpTMWxxQnR6Qnc5SDJGK25KYnFHd3VrN3hsWmdWSHR6?=
 =?utf-8?B?empHTjF6ZFhQT25sU3V2QzFJTmpEaXN3Y3RSSUZlbjZpdkZuUktLQlkwS2pS?=
 =?utf-8?B?VWZjTVFoaWs3UjRrSy9TaHNCb0lQd3NlV3V5c3oxcXRJbDRYS2EybUhVN1Z0?=
 =?utf-8?B?TzZodlRMVE02YUlDMjF1Z2FHbVQ4clhQOXF4SnVsRWlnRlBHR2tobVBtSFda?=
 =?utf-8?B?bi9KMjRUTDB5d1N3T0pzaUpIL2R2U1JzUEJMc0FzVUhFQVVZUnZ1eWFHYVBR?=
 =?utf-8?B?c0I4U0JoR2w2U2RqRE1WZjNKeHNXQldtL00rNkJaY3hqMUtPQy9uNzA3Zmh6?=
 =?utf-8?B?MXFJc2NrVnlPMTc2aFhUUWhrVE1tS0pWUjE0QVBmeXFtMXpFalhHaDdPNUxH?=
 =?utf-8?B?YnJVd3NHVG8xOHBtRnZNaXpNR29ybG5EOEh1SjdQR1pUK1RNV0tBbjlYcW43?=
 =?utf-8?B?OXBkSDJrbk1lNEY4bllkOUxkWFAwZW1RT2t3YkV6ZkNzZmtzMVZWYjZzSGVJ?=
 =?utf-8?B?NzdzT0hWeU1NUWRWaHMxNzE4aEU0TVd3VTdIT2xqdCtWc1kwUWJRQ0lZVVhI?=
 =?utf-8?B?U3NWRlhTcDE2WkI4QmRpWHhxQzFqdkZEMktrRHdNQlIyQldyTEpMTEJqUzJK?=
 =?utf-8?B?a2ZBYklObjh1KytLNUZRdzFTdFYydHVMZXlCZld4dk0rN2JOaStlRStGQ1VZ?=
 =?utf-8?B?c2VaNHB4dXl6L1RHZEtKMXY0V3FUOFB2RWlEOXBYQjRyRGxSVnJPNFZ2emRT?=
 =?utf-8?B?MWU3amo2MlVzd2xqVlRIYis5amEyUjY0L2JwR1NSYi9DU2duL0REdGdFRkJZ?=
 =?utf-8?Q?9B3mUh2jKHNYNBofHl/vTuo=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 733c2a48-f8eb-4d66-dfbd-08db10404462
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 17:07:21.7151
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +urx6KwRvnQTPv9q28rxxuiOSkK5uCLbXvxBMgb/gnXWMm2cljZyyrBMayPK0hvUweJvzZCe7V2LOgPCewXq71prhXfzegQrIGzZZVmibjs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR11MB5785
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Jesper Juhl <jesperjuhl76@gmail.com>
Date: Thu, 16 Feb 2023 02:01:05 +0100 (CET)

>> From e2fa4955c676960d0809e4afe8273075c94451c9 Mon Sep 17 00:00:00 2001
> From: Jesper Juhl <jesperjuhl76@gmail.com>
> Date: Mon, 13 Feb 2023 02:58:36 +0100
> Subject: [PATCH 06/12] [testing][wireguard] Remove unneeded version.h
> include
>  pointed out by 'make versioncheck'

Your patch is broken, pls resend.
Also I've no idea about the subject/prefix, shouldn't it be like:

[PATCH net-next] wireguard: selftests: remove unneeded version.h

?

> 
> Signed-off-by: Jesper Juhl <jesperjuhl76@gmail.com>
> ---
>  tools/testing/selftests/wireguard/qemu/init.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/wireguard/qemu/init.c
> b/tools/testing/selftests/wireguard/qemu/init.c
> index 3e49924dd77e..20d8d3192f75 100644
> --- a/tools/testing/selftests/wireguard/qemu/init.c
> +++ b/tools/testing/selftests/wireguard/qemu/init.c
> @@ -24,7 +24,6 @@
>  #include <sys/sysmacros.h>
>  #include <sys/random.h>
>  #include <linux/random.h>
> -#include <linux/version.h>
> 
>  __attribute__((noreturn)) static void poweroff(void)
>  {

Thanks,
Olek