MIME-Version: 1.0
References: <20230215214724.3798917-1-linux@roeck-us.net>
In-Reply-To: <20230215214724.3798917-1-linux@roeck-us.net>
From:   Joe Tessler <jrt@google.com>
Date:   Thu, 16 Feb 2023 12:22:21 -0500
Message-ID: <CAJPkMDTDU-UK35hrx4=c26VmBVSuZO6usr9Omiq2dtyTjHsZLg@mail.gmail.com>
Subject: Re: [PATCH v2] media: cec: i2c: ch7322: Drop of_match_ptr
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        Joshua Pius <joshuapius@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hey Guenter,

Thank you for this fix.

On Wed, Feb 15, 2023 at 4:47 PM Guenter Roeck <linux@roeck-us.net> wrote:
>
> The driver does not instantiate on ACPI based systems if OF is disabled.
> Fix the problem by dropping of_match_ptr.
>
> Cc: Joshua Pius <joshuapius@google.com>
> Tested-by: Joshua Pius <joshuapius@google.com>
> Fixes: 21b9a47e0ec7 ("media: cec: i2c: ch7322: Add ch7322 CEC controller driver")
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Reviewed-by: Joe Tessler <jrt@google.com>

> ---
> v2: Added Joshua's Tested-by: tag
>
>  drivers/media/cec/i2c/ch7322.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/cec/i2c/ch7322.c b/drivers/media/cec/i2c/ch7322.c
> index 34fad7123704..3c6e6496a001 100644
> --- a/drivers/media/cec/i2c/ch7322.c
> +++ b/drivers/media/cec/i2c/ch7322.c
> @@ -589,7 +589,7 @@ MODULE_DEVICE_TABLE(of, ch7322_of_match);
>  static struct i2c_driver ch7322_i2c_driver = {
>         .driver = {
>                 .name = "ch7322",
> -               .of_match_table = of_match_ptr(ch7322_of_match),
> +               .of_match_table = ch7322_of_match,
>         },
>         .probe_new      = ch7322_probe,
>         .remove         = ch7322_remove,
> --
> 2.39.1
>

Joe