Message-ID: <15a893b3-e6d4-5bfa-85e9-1f5210173073@amd.com>
Date:   Thu, 16 Feb 2023 12:05:51 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Reply-To: babu.moger@amd.com
Subject: Re: [RFC v2 PATCH 0/7] x86/resctrl: Miscellaneous resctrl features
To:     fenghua.yu@intel.com, reinette.chatre@intel.com
Cc:     tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
        corbet@lwn.net, linux-kernel@vger.kernel.org,
        linux-doc@vger.kernel.org, eranian@google.com,
        peternewman@google.com
References: <167537433143.647488.9641864719195184123.stgit@bmoger-ubuntu>
Content-Language: en-US
From:   "Moger, Babu" <babu.moger@amd.com>
In-Reply-To: <167537433143.647488.9641864719195184123.stgit@bmoger-ubuntu>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NVJoY2UzazdLaEVxaytoaldqTzNHVFBUTTl2Q1k1NldXZ2duaVBEM0dnQTd6?=
 =?utf-8?B?MFN6cThCUjM1RFgxelRoYzh5MThuTStnSXRCcEdsektvV3g5ejBrekIxRHpw?=
 =?utf-8?B?QXY3S1hma2RaMjh6VnZSRDN4ckg1VmxlaTJGaS9FTGNXUENobXRyMC9IdUh2?=
 =?utf-8?B?UGhWOGd0anAwWmROM1hwU1RXVmhZcUZiZmRpcWVDSW9JRyt5aGNxQ0N6bEZh?=
 =?utf-8?B?NjJKdlFrSlZZTll5Rms1dDhpb3FiSWcvdWxISS9lcDZ1TStTeWdvbWdUUzdo?=
 =?utf-8?B?NHJWL3ZyMHZWNndJd0xMT1I4MVlrRGpxcHlYQTkxWE16cmw2RVVtWG9GcGNS?=
 =?utf-8?B?SlYyVG10ak1JOTV6dVZ4R2I2bHh5c2YxMnFqZVVDNmpIT0dQb0dsMTFQNGli?=
 =?utf-8?B?TFkrQmNmcUt3VktXM2YzcjJWQWNsMDlLZ0tFbDlnbEdMK3RHbzkwMGhidVND?=
 =?utf-8?B?a0ZuYWU4bTdua01HMHR2dVNRY2tIRHpKSVlWd0tFektjWEhzWFlZcGpJYmoy?=
 =?utf-8?B?VWYxODRzbXloekd5aXRDcytEbzQrbkh1V3JzTFZKU2FZcFV1Q3UyYTlDQ3pm?=
 =?utf-8?B?d3dzOHBjTWxMQ3IyUVFDN0orLzdRRDlCaTZkMlcyY2RDMkdFMzN6VElhYVEz?=
 =?utf-8?B?NVVwMEh3ZVBUQU1wTkVhVjZoRlVpdWR6OVpieVR1RmMwMUhNamV6dmRncktj?=
 =?utf-8?B?ckdXOE45UXBTdzNjZkNSZnRFMnJhUkdQbHJ4YjdrYlNic2hZVjBzQjVxYU9t?=
 =?utf-8?B?b3pkbHJDWW16SnB5UVUrQ0ZQN2FKNjREaXFucW1qdTZ1MlNNUjVwYmlXVXZp?=
 =?utf-8?B?Rno3cWtsR01hSXJhTDYzMWhMS0tsRDhhYk8rVmxCNmNOR3JpVWhNZm4wMTl1?=
 =?utf-8?B?WVptMU9INEZENkQyaUNBNWxveWtua1UvbERYZERjb3RrZ1pocFJkQXFhc0lL?=
 =?utf-8?B?RlUvdnBQWUx5cE5VejZha3NET283WEpaKzZjaTdjVC80d04zS1JFSjJ5eUtL?=
 =?utf-8?B?TzFjRjI2MHBQc3J6QW5wcGhNWUF6MHQyNGc3cVlkbWVGUE1VNlpzUUd5eTVa?=
 =?utf-8?B?NmsrREtLNHdobytQWU1FLzBHZ1poeWZmSjROcS9PQlhvUFZjZ0J0dS9ja2U2?=
 =?utf-8?B?aDdNblJxa1ZQejJkZ3JvUVZoKytwSlZpVnNjc1RTbzE2UGREWkNQamVZNFUw?=
 =?utf-8?B?b2pnSDZjSFBlQjFLVUtyM0VyaGFadHlUVWs5WStzbHZjempWY3RmNXAwcVRR?=
 =?utf-8?B?YSt5a2M3TUczSnJ5MGZJS1JuUjhldUw3ZlFUR1ppU3lCeDBKdkx5RXRSLzZs?=
 =?utf-8?B?aWIzOWZaTHRyd1BHTXc4NEVETFhNbGpMRzB4VXhvQkZnWlNrYkJQS1pRaDlQ?=
 =?utf-8?B?alQ4MitGWWZGTHU3MzRFV1diWGVZVEV2d0FsOUtKVDlqQ0dkZWxUTFVHeXpq?=
 =?utf-8?B?QjdtMGM4ZTdkWk1JYlBCanowWTRTMmwyQnh2eFpxWjN4MHU5Ti82R0sxRURW?=
 =?utf-8?B?ZHRFb0FoTkVJTmVQVlRLY1pZV1RDTCtNN0VKNUc5TDFPMk1oZi9PcTRGUWs3?=
 =?utf-8?B?NlRJdGVMOSswdDNSSlpZR3RLYk51TTJhQ1hGZjExeUxub2gwbTdhcTAwTUxj?=
 =?utf-8?B?SVYvcitodnpoRDVuZGhvdlpEMUwrclVlRy81ZFl4NGVHV0Faa2plSFBFSjNz?=
 =?utf-8?B?WXFxMHBOUnJ4SXJyZnRrcm02V25RSzVtR25hekZ0N1c1YTQvc25QN2JZYTBV?=
 =?utf-8?B?eHVsSGpOZHJVSVNqcjFOTXRBbi85ZDdiVnR5ZFBDeENLSlhJZlZDamlocXpr?=
 =?utf-8?B?U2oxQ29SMkpOZ1QvbGw4K2QvUXJ6akx0ZjJSRHJPRElOT0xwV0tVbitIa1A4?=
 =?utf-8?B?aDdBMDhNdWt0NlRlaEU1cDRsdUpGaHYxT2t6N2hyWFBTeUpKOG4ybkdiTHlD?=
 =?utf-8?B?a2hiM0xyaDJ0T2h5Sm52bzNNTnFnNnFkZjcvOStONzJEd2hmYnJWV0hMcFQz?=
 =?utf-8?B?MWlwdW1ZYWp0dE1JVW5zUmcwV1liQW42UlR6VHZZUHNTTGdwOXFaRGJyenBo?=
 =?utf-8?B?NEtYVWJwMTlCcW9vVlpoRWdwdVNKbVRFU3VVa08rSnEzNkNoamd0cWZ5TFl5?=
 =?utf-8?Q?6svewE/evoIFAGT2v7TJnxyWT?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7acd36ed-7334-42cd-b15e-08db1048724f
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 18:05:54.6113
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VElG3q51nbCKUtzOPvNmG9/YqNylXGjypdvp9kV/HBsXm4tTenB9JlkT9K9h+d90
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5856
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Gentle ping. Any comments on this!

Thanks

Babu

On 2/2/23 15:46, Babu Moger wrote:
> These series adds support few minor features.
> 1. Support assigning multiple tasks to control/mon groups in one command.
> 2. Add debug mount option for resctrl interface.
> 3. Add RMID and CLOSID in resctrl interface when mounted with debug option.
> 4. While doing these above changes, found that rftype flags needed some cleanup.
>    They were named inconsistently. Re-arranged them much more cleanly now.
>    Hope it can help future additions.
>
> Code is built on top of tip branch x86/cache.
>
> ---
> v2: Changes since v1
>   a. Removed the changes to add the task's threads automatically. It required
>      book keeping to handle the failures and gets complicated. Removed that change
>      for now.
>   b. Added -o debug option to mount in debug mode(comment from Fenghua)
>   c. Added debug files rmid and closid. Stephane wanted to rename them more
>      generic to accommodate ARM. It kind of loses meaning if is renamed differently.
>      Kept it same for now. Will change if he feels strong about it. 
>
> Babu Moger (7):
>       x86/resctrl: Add multiple tasks to the resctrl group at once
>       x86/resctrl: Remove few unnecessary rftype flags
>       x86/resctrl: Rename rftype flags for consistency
>       x86/resctrl: Re-arrange RFTYPE flags based on hierarchy
>       x86/resctrl: Introduce -o debug mount option
>       x86/resctrl: Display the RMID and COSID for resctrl groups
>       x86/resctrl: Add debug files when mounted with debug option
>
>
>  Documentation/x86/resctrl.rst          |  28 ++++-
>  arch/x86/kernel/cpu/resctrl/core.c     |   8 +-
>  arch/x86/kernel/cpu/resctrl/internal.h |  68 +++++++++--
>  arch/x86/kernel/cpu/resctrl/rdtgroup.c | 154 +++++++++++++++++++++----
>  4 files changed, 215 insertions(+), 43 deletions(-)
>
> --
>
-- 
Thanks
Babu Moger