Date:   Thu, 16 Feb 2023 14:18:41 -0500
From:   Peter Xu <peterx@redhat.com>
To:     Linux regressions mailing list <regressions@lists.linux.dev>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        David Hildenbrand <david@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Nick Bowler <nbowler@draconx.ca>
Subject: Re: [PATCH] mm/migrate: Fix wrongly apply write bit after mkdirty on
 sparc64
Message-ID: <Y+6BkcrLBKJyGZUn@x1n>
References: <20230216153059.256739-1-peterx@redhat.com>
 <611c1202-1978-8886-eec3-929933ee75cd@leemhuis.info>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <611c1202-1978-8886-eec3-929933ee75cd@leemhuis.info>
Precedence: bulk

On Thu, Feb 16, 2023 at 05:59:16PM +0100, Linux regression tracking (Thorsten Leemhuis) wrote:
> On 16.02.23 16:30, Peter Xu wrote:
> > Nick Bowler reported another sparc64 breakage after the young/dirty
> > persistent work for page migration (per "Link:" below).  That's after a
> > similar report [2].
> 
> Thx for handling this.
> 
> > [...]
> >
> > Note: this is based on mm-unstable, because the breakage was since 6.1 and
> > we're at a very late stage of 6.2 (-rc8), so I assume for this specific
> > case we should target this at 6.3.
> > 
> > [1] https://lore.kernel.org/all/20221021160603.GA23307@u164.east.ru/
> > [2] https://lore.kernel.org/all/20221212130213.136267-1-david@redhat.com/
> > 
> > Cc: regressions@leemhuis.info
> 
> Not that it matters much, but feel free to use this instead:
> 
> CC: regressions@lists.linux.dev
> 
> Then things don't depend on me (in case I ever get help with my cat
> herding job). And it also make it even more obvious that this patch
> fixes a regression to anyone who handles it downstream.

Sure.

> 
> > Fixes: 2e3468778dbe ("mm: remember young/dirty bit for page migrations")
> 
> That's a commit from 6.1, hence this should likely have:
> 
> Cc: stable@vger.kernel.org # 6.1.y
> 
> [no, a fixes tag alone does not suffice, see docs]

Oops, I just forgot that.  We definitely need to cc:stable.  I'll make sure
it's there if there's a new version, or I hope Andrew could help to attach
otherwise.

Thanks,

-- 
Peter Xu