Message-ID: <cc106460-01b5-abfb-8856-6d65ee7bb866@amd.com>
Date:   Thu, 16 Feb 2023 14:58:10 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH v9 1/8] x86/apic/x2apic: Allow CPU cluster_mask to be
 populated in parallel
Content-Language: en-US
To:     Usama Arif <usama.arif@bytedance.com>, dwmw2@infradead.org,
        tglx@linutronix.de
Cc:     arjan@linux.intel.com, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, hpa@zytor.com, x86@kernel.org,
        pbonzini@redhat.com, paulmck@kernel.org,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        rcu@vger.kernel.org, mimoja@mimoja.de, hewenliang4@huawei.com,
        thomas.lendacky@amd.com, seanjc@google.com, pmenzel@molgen.mpg.de,
        fam.zheng@bytedance.com, punit.agrawal@bytedance.com,
        simon.evans@bytedance.com, liangma@liangbit.com,
        David Woodhouse <dwmw@amazon.co.uk>
References: <20230215145425.420125-1-usama.arif@bytedance.com>
 <20230215145425.420125-2-usama.arif@bytedance.com>
From:   Kim Phillips <kim.phillips@amd.com>
Organization: AMD
In-Reply-To: <20230215145425.420125-2-usama.arif@bytedance.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Tm80WFl4N3ZXUkdGQTJQSlR1WXZuMDRhQzk2ZWN4R0haeDcwQW9lczR6bEFE?=
 =?utf-8?B?a1hlRXV3ZVR6MXB2eDh2cUY2NWMzc0ZnS1NwL3JTc3A3L0ZlTVFlR3V1RVAy?=
 =?utf-8?B?OEZTd0lVNS81RlBiblhCcitVODJGRHB5aVo0UFNrcDRrWG5lR08xL2NCQ0Rr?=
 =?utf-8?B?UVpvR1pTeUF1Nk50eGVEQkFDcTZxYnNjU1RJYzdQL2t6N3d5ckNmM2x4Y1c4?=
 =?utf-8?B?bmZrdFd1ZDN4bjRJcXJxb1dCeTZHdU15bCs4eVVhQkhVelplZ3ZWVHZsQWFy?=
 =?utf-8?B?NFVoWGVEYmtEUHVoT3p3R25Wc0ZJb09FNkVNMk9vK0RTMkc0V00zK3ZHTVZW?=
 =?utf-8?B?c0NrbWFWVHVuMEpZR2R2T3BkR00xWUNvTHNINUtpQUdnNUU4UTVBQXl1UjJp?=
 =?utf-8?B?dHFVS25CbjY1OXhkSFBqTEJWek11YnlUbnAzRnRoamxxbEJPTXN5ZUh5M1BV?=
 =?utf-8?B?VEJNcE1GUVByS1NsR3V4Y1g2OFFadW5MM1hHbUhacmxGVHlpZThJZ3p0TjhU?=
 =?utf-8?B?LzJwSjBZUjJCNE1BTzlWNkdsb0gvQ2UvN1ppaGdxR0NPOE05eGJlMnVsNUsr?=
 =?utf-8?B?aHkyam10R3c5Y09Na2tjelZTYko1TGQwNWZtWEtsMEVRN3VLOFpvSzlXTkln?=
 =?utf-8?B?bFp5OXVWRUFUbTFzR1p0Y0s2OG9ZcWVwZDB3OWtVczcrRWpMejZIalI5Q1pZ?=
 =?utf-8?B?YXk3QmNwejFsUzNGWG9Md2ZFOXJtUDFGL29kV1JxZE0rOStMT29YNmVaWnZo?=
 =?utf-8?B?L3dEKzZ0MDlYMHNnUVNNNzdxblNONHBLblErMTZlR0lXREhsVTdiTFd1cEVh?=
 =?utf-8?B?eDZIVjdVcnd5eEVnNllrbHl5WkhOMVlYWGY0STEzdHNsQS9pcEdFZ2JhdzE2?=
 =?utf-8?B?ZUtYRHJmdUE4Vm5xR25GOUlCRTdxQzc0aVd4U0IzbUwzYjVnbVcxT0ZWTVRI?=
 =?utf-8?B?WHF5UVBCdHpTQXJtamxmNHZ2SGZBbDdnZjJVVTQ0WTQydXF5ZWpGSWVRVFkz?=
 =?utf-8?B?a1RkQnI0MnpNNEptVVRDTTdpOU1mQXh5eTVwNGRWWkQ0UC9XNVdtaUdXS2Fo?=
 =?utf-8?B?U29BSmlSclNBdVIvOG4zU25laXFNWWxnZHdPQ2xPR2dNZXFOWkJYcW45U0hm?=
 =?utf-8?B?bEUzdTVRYkZWdkYwaGExRnNncEluSjRLZVZJc0pYMWVBU2JIQzR4K1hFWGho?=
 =?utf-8?B?Q1hqaldWSnRoMHlqa3d1aWkwVmtwTWRueFNsTm9NK0V5Smg3QllYd2N4OHRr?=
 =?utf-8?B?TEVBcmsydElJclF4UXQwKzZ4THRKc2N2a2xEV2xweXpDbUtiVFJsVWRiOFhh?=
 =?utf-8?B?MS9YK3pxUnV5a0dzeG93bE9mdkhJQ2oxV2cyRmtvUmcwS0RBeDhwWlhmYnB1?=
 =?utf-8?B?NGhoZzBmcjhzbEt6SXltZXN4R1A1QUllUWo1bDRJYzRacjNYakovazc3YnEr?=
 =?utf-8?B?dS9NMng5ai9tajM4TlJEY0tSb3k1MitkeFpkcDRKOXVZalV2dDZpU1dlNzlL?=
 =?utf-8?B?S093V285bXEvbEZNZ3pwNlNzdnhyUGFaNkw5NTdkL2tKWks5S2czNzBrK3lI?=
 =?utf-8?B?dGpnR1JLb1NESVNvcGNxNlgwNjJjd1BFV2R4dUFsZHI4OW9PbWZMK1ZZaTRh?=
 =?utf-8?B?RnhjV2QyYnB3RmVxUmdtcWVMUXZ3NUx4L0VEMGltcGkwZzNDenZGMzE4RlE2?=
 =?utf-8?B?OTYwaGM2N3owZ0FRMmNXVWw5OFZmRWtrSWpTdjNnaFU1VE1hbHpUa3g0dkh1?=
 =?utf-8?B?SlYvNWZKdTkyOWNTU2lmdmlOcm5ENHc4VEljRmJpeWQwUmdHWmllMUY0RWF6?=
 =?utf-8?B?V3BqNUhNTE1PaC95Z3QzWGt5cENwR0JJOURXc29TNnpXVmR5TkhwcElGVzVU?=
 =?utf-8?B?aUFyVExpZkxzOTF2a05rRkxFMFdqRFhjbXcrazdHTU5LNEhxd2V6WktxYzll?=
 =?utf-8?B?SUVhOFFPVEZoVXVJaGYvTm55YS9sRnlSMGV5eG5tWThoMjhkMmpQakdHeFFj?=
 =?utf-8?B?VWtLVFNZUW9rTzZxUmg0T1ZQdnJYREVCdC9xa0JZcTVVeHk5eHhaZFQvK2ND?=
 =?utf-8?B?Q1Vxb1phNUM0dmhFL2ZTZ0ZER2NubHlnZUZhR284Yk0wV0VCdTVlMEJSSmlH?=
 =?utf-8?B?cjJldy91YW8xWHZISFhGdDYxSkZDRzRxa1UrblJGU1RIODFVaWs3Q3ZyOW9F?=
 =?utf-8?Q?1gJKd02MEmT74KFC1aSXqxcsoYz8bIS3jDJZ61iOM8hh?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dabdce10-9f46-481d-2a86-08db10608666
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6263.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 20:58:16.3304
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: w0HVcrLYvhY4RlVsNB1C2HLNI2xUm5XplK+QUWcGJWPq8w/Q89xRJZWTgcx/PIASAjfP1T5BdLIRHFhb3dNoUw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8525
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2/15/23 8:54 AM, Usama Arif wrote:
> -
> -	cluster_hotplug_mask = kzalloc_node(sizeof(*cluster_hotplug_mask),
> -					    GFP_KERNEL, node);
> -	if (!cluster_hotplug_mask)
> -		return -ENOMEM;
> -	cluster_hotplug_mask->node = node;
> -	return 0;
> +	/*
> +	 * No CPU in the cluster has ever been initialized, so fall through to
> +	 * the boot time code which will also populate the cluster mask for any
> +	 * other CPU in the cluster which is (now) present.
> +	 */
> + alloc:
> +	cmsk = kzalloc_node(sizeof(*cmsk), GFP_KERNEL, node);
> +	if (!cmsk)
> + 		return -ENOMEM;

.git/rebase-apply/patch:167: space before tab in indent.
  		return -ENOMEM;

> +	per_cpu(cluster_masks, cpu) = cmsk;
> +	prefill_clustermask(cmsk, cpu, cluster);
> +
> + 	return 0;

.git/rebase-apply/patch:171: space before tab in indent.
  	return 0;
warning: 2 lines add whitespace errors.

Other than that:

Tested-by: Kim Phillips <kim.phillips@amd.com>

Thanks,

Kim