Date:   Thu, 16 Feb 2023 14:48:08 -0800
From:   Dan Williams <dan.j.williams@intel.com>
To:     Ira Weiny <ira.weiny@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        "Ben Widawsky" <bwidawsk@kernel.org>,
        Dan Williams <dan.j.williams@intel.com>
CC:     <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Ira Weiny <ira.weiny@intel.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Dave Jiang <dave.jiang@intel.com>
Subject: RE: [PATCH v2 0/3] cxl: Enhance trace point information
Message-ID: <63eeb2a8c9e3f_32d612941f@dwillia2-xfh.jf.intel.com.notmuch>
References: <20230208-cxl-event-names-v2-0-fca130c2c68b@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230208-cxl-event-names-v2-0-fca130c2c68b@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fmih5SeT39SVHP+cSAOlxApKtOdLqfPNWVRGOI52yWgsGxJLnIg10X2lFrCI?=
 =?us-ascii?Q?jeu67RgTGRwlwttT2P/IHpjdKdI16+rG1Z46gDpT3OGTN2sttM1uNgBUkoVK?=
 =?us-ascii?Q?WHu9COK6pxP80yP3iEyLrEInt5hBuJlyPUz4N2QD8I4yGYW5+is3PonpvIr+?=
 =?us-ascii?Q?3H7wOqSk+aKHRxGpdJ0U7enT2MeEXNI/E//DciXhbfPeJza0KkxYnj2ZfRvn?=
 =?us-ascii?Q?NH5M9ag6L0wzelTmWaolMxZnulsb9QaxPAynbWydK6eJJKBIBGtMhByo23hA?=
 =?us-ascii?Q?uSr0CI7BqIHLougSPjaeRV1y3gyB0zVhE5km1P1XuOkXmbXFosUG1FvfSnGG?=
 =?us-ascii?Q?ffxT7QOF0j329ps87MqcWwSiJutXeVA/dUvcsLuBqLI+2kEWzQPcTOodyxkc?=
 =?us-ascii?Q?QTUZ1ohmMBqfM134+fKw8bfV1AB7MSaqRyYUdjew+C6f0fdLUWQWb2CsUJwl?=
 =?us-ascii?Q?kH8vAZjkpYZJFPCqh2RETq25D37LllbCGsDFhx7ALUz9OKS/iIwzBg8nhxHy?=
 =?us-ascii?Q?MbQTNjxOLf9dxpJEndrLesIfBIdZaH9B5xXJANG/K/qCpen+UHCidK5yiP2a?=
 =?us-ascii?Q?PhrVfPTUSaEgH82C17k4OrTljAMxqDzssOtr3sDmpKnqBg1kHv+HtJt4gvgw?=
 =?us-ascii?Q?Dfxv+levQZ+8RzikaYxNuW6wCehBpVXyEG067TsFL2dP1AckLRWODPafXk6X?=
 =?us-ascii?Q?G++Xays0NTDaTs59NJ9SgKCmUAP383+QaHRNJncJJsZXdSFeeNdMpcJlphIf?=
 =?us-ascii?Q?8bVC5IcfdEqcJ9fgqx4133r0L2rDKkdrksCMCTHJW0PuvxSqv4hkIvLwHNlL?=
 =?us-ascii?Q?zaugyf/bBhHzPBnEanmXFxhSLKApQWka7Ni0vlJbQNZOlYNH8dzvSBgKtK99?=
 =?us-ascii?Q?u3ypRkhB9ZX7fZAZiILytGUVFpcKJTuQPpOienYVPtxyyOx0GHbQafaGtgpb?=
 =?us-ascii?Q?14sb3Jqf9arg7t3aHirWfrt/Vwg62z30dBSFqQP58POjpcH7tk53DRmr21jF?=
 =?us-ascii?Q?COIqJD/9ggIDWQs99uL5tzzpY7GJst/kalZL5i0cmoKRq3HX7wsScbOl/KO8?=
 =?us-ascii?Q?FreYCXICo/4z6KC3xKn9+M8JFMJ9pbGOnFczS/caLucs93Oo8gPP5JpNilwm?=
 =?us-ascii?Q?LsUkPCGZQJFa6TPBwrPrMPY9U2+jSlfTLLnBwWqndene5utxDg5nfB7WdeFu?=
 =?us-ascii?Q?EcDLzDf80ppj8XWnVRxR7PKDBz5QO/9Fy84A64o5TzRVUzE2/rQlKHZk6e74?=
 =?us-ascii?Q?VlmJIkZ58HBUYxzjX1qCxhZLLMH4v2FSlBrPFbRtQUvVy0S7Xwv4wox6sa5Z?=
 =?us-ascii?Q?kCe2V1BEJ/ccq2EpU7Yg8Al2mgUTKlKLUTZvW/ECUKCb1oGuCbgTxfP1THHf?=
 =?us-ascii?Q?utRbity+gnZqD8VA7M7cRSo/SdAvljO0Ti4cWiGjqE+HlalceXaPBwiptNnG?=
 =?us-ascii?Q?fuXcGouuO7iYbhMTUdGGy99dwvJgbn5H6EGY0WHrCXlt1XPcOLFw6ASTM7iz?=
 =?us-ascii?Q?1o/6PF/Js/nZG31Cl2SmhTcNRZvoViub4n/NoPmVqtLKNH2IIBEpFU4AUCli?=
 =?us-ascii?Q?1YkgwzIFTvbGc52srsUTbqY2+rElGNQ8Pcj6wKcLtNQNMfo3GmYVhQXFHgGa?=
 =?us-ascii?Q?pQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f142142e-0241-452e-af25-08db106fe17e
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 22:48:11.5522
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AZbevozvMxYOGG716E4RDEQ0vAfQOEyP4CVkggBONw6+GYIf9bJ3dJERGli3yfN8xZZXLwCxI0i06kgx68GctJ2RiTWDEDrINis9u/zayO0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5674
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Ira Weiny wrote:
> Trace point definitions are reporting different linux devices for the
> same CXL hardware device.  Clean this up.  Add additional parent device
> and serial number to all the trace points for easier user space
> identification.
> 
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> ---
> Changes in v2:
> - Dan: Add patch for serial number
> - Fix macro parameter isolation
> - Minor formatting change
> - Link to v1: https://lore.kernel.org/r/20230208-cxl-event-names-v1-0-73f0ff3a3870@intel.com
> 
> ---
> Ira Weiny (3):
>       cxl/trace: Standardize device information output
>       cxl/trace: Add host output to trace points
>       cxl/trace: Add serial number to trace points
> 
>  drivers/cxl/core/mbox.c  | 14 +++----
>  drivers/cxl/core/pci.c   |  8 +---
>  drivers/cxl/core/trace.h | 95 +++++++++++++++++++++++++++++-------------------
>  3 files changed, 66 insertions(+), 51 deletions(-)
> ---
> base-commit: b8b9ffced017528bcdd262730ab10bc5084c3bb4
> change-id: 20230208-cxl-event-names-9372fb72a607
> 
> Best regards,
> -- 
> Ira Weiny <ira.weiny@intel.com>
> 

Looks good, applied.