From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     netdev@vger.kernel.org
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Gerhard Engleder <gerhard@engleder-embedded.com>,
        Amritha Nambiar <amritha.nambiar@intel.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Ferenc Fejes <ferenc.fejes@ericsson.com>,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        linux-kernel@vger.kernel.org
Subject: [PATCH net-next 04/12] net: ethtool: fix __ethtool_dev_mm_supported() implementation
Date:   Fri, 17 Feb 2023 01:21:18 +0200
Message-Id: <20230216232126.3402975-5-vladimir.oltean@nxp.com>
In-Reply-To: <20230216232126.3402975-1-vladimir.oltean@nxp.com>
References: <20230216232126.3402975-1-vladimir.oltean@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?q5GKpGFej0wUG0BKBx/0Pt4RjxHg4371mzAzY/igz5FEJMMlFOs1K4rVrs5w?=
 =?us-ascii?Q?8N2O01+pgVi3qMblXoUPTr9RURB24z7ibta0Lb2XbgmcBWqayhefiKqueeVy?=
 =?us-ascii?Q?AOCF0SDXqZfmCJiphiWBHrVfy4fALZgegobRxrjapzt0rruihN2sBxt7+DMQ?=
 =?us-ascii?Q?1N7OmPKz2Yi6asdTuFaJl9LS+nJPi7LFh2W2hBWDcOvJW5eM8vjlPoun/u/O?=
 =?us-ascii?Q?Lin2uZ9Vm242hjHPguZXAfivvMyhrz6kYZ/DgR93ALMxcqdU8f3WPSI4Oeu/?=
 =?us-ascii?Q?CLAgc1Ddx1xk6b48bqDXsQRq4UqryV3WEceCuHN5tQlub7mHwcA6dfek1x1m?=
 =?us-ascii?Q?tNpsr5oQrij5IC5nwp/qvZcLoN83JBvrKU696LTW2c1MH9JCUMbZ5EzGbWBl?=
 =?us-ascii?Q?gUD2JJE+TaF8hVNJ5I2Bw2jlEd1wVhyfHX61XXESDJ9OuKKTvHp6zTQCV0MW?=
 =?us-ascii?Q?vY1xUg50f1KrByckbAs+PIaVkj6QurqP1hYWdTuWnMW5Lg390+I+LqsWcwcS?=
 =?us-ascii?Q?MAlFwcUT0nsqXSZXr0OaEDQpd52M/kM/GkEF5WX4dT+i08L+vE4uJNDGg0Ne?=
 =?us-ascii?Q?7Vea+EmA8uk2r+m+yLwMEqzZ9qOqr8PW0XfnPsxNT9vlKKfz+f5ncmlN0aZ7?=
 =?us-ascii?Q?P6mJcyxxoWS2CydhW2OBc3u4VltmkG3v5jED/NT0tVEo7yiRWaI5FkWB+0HD?=
 =?us-ascii?Q?9I21JKKSgeJcwkwr8aRbXKDPESBk1m2tgxOuTkRxJ09oa+yZhFzG3gtEPNUl?=
 =?us-ascii?Q?JlP5PzV1ale6YCvJXMzzMolzWfW9aGu0J6Z/m+t9qVmNKV3QmZ2DJJuxuvd4?=
 =?us-ascii?Q?Zs/WuIwUrZtuQhf3848TY3pfr+OF84NhUPtZ+lKniu0OhI/bwNWJQaFRggzq?=
 =?us-ascii?Q?0bNTCwuZ+7vsQIApHS6IvQ+mVPFDyLZ1ZGkYpWMzXaii2zPS5O3ZntpJHdjp?=
 =?us-ascii?Q?aAoQGr17Piqvm4Bp5HgwIuRiqvfansjalw1MmMlE2uHoMZZFrzCejpKAALPN?=
 =?us-ascii?Q?z0VY1IB1GDD4gOmPDyYRDC9A0E84z8hflqrpgVb86Utc7jrnmTeA0N9zG/0y?=
 =?us-ascii?Q?z6o4TX1rqKgQzmUKlQ5NjCMaERPTOrMgn7HDmXYzG7TaQ+pmop4qoE8KNBWb?=
 =?us-ascii?Q?2bFzI0bjzhwT+mT4hzdot0mYMkClSyr/Nv0Gri0N1rntfit7czd4A/WYz1bw?=
 =?us-ascii?Q?NIHORwc2eZnR16+ZTJ+iPnl5YrpF1fA9bJzhH4wW0xm2jrBXCQ1vRS449f3j?=
 =?us-ascii?Q?znu6sFCFJUSBtEg/Vk8HxB8dI5cBpoMPYuBQ6P2s6r0IUT6wvLqGICP3oIlg?=
 =?us-ascii?Q?hjZgb8fHj2771kHESV0dRhjD2mLff3NFHExhe8GRWFiYb39hwbFuri8XjPhB?=
 =?us-ascii?Q?RxrgynxvJLGYALybEKMxvkLrGaiHwcLKhVow8Ky46ihhET2aP/DazfE5yneX?=
 =?us-ascii?Q?spNbVZ09RfSoFzAbrY88h4D+Px5/AiCJF4OhugKrHQ+UV+tPRvX52AZ/XgX+?=
 =?us-ascii?Q?BB50CwUgqHcepPAU3tooe6L53vhURY7is70FYKAEppjztCSbfWhGBGcimdnE?=
 =?us-ascii?Q?2eUyak7xdAmsAsjisApCjJ1K8B3utN5w6EOtD1EYf6MwQ5eoVlx0IIX3k2ms?=
 =?us-ascii?Q?Zw=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bf211a17-582e-4b54-1267-08db107491e8
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 23:21:45.4931
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WyiAG/xLy48Wpmf0m2pjgpD2VB4BIvrad2585H7mxPgc8ZVkoQxX8XZ0JDLp8lUdNp7Zby3mJvrs53zSMubO6g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7436
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The MAC Merge layer is supported when ops->get_mm() returns 0.
The implementation was changed during review, and in this process, a bug
was introduced.

Link: https://patchwork.kernel.org/project/netdevbpf/patch/20230111161706.1465242-5-vladimir.oltean@nxp.com/
Fixes: 04692c9020b7 ("net: ethtool: netlink: retrieve stats from multiple sources (eMAC, pMAC)")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 net/ethtool/mm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ethtool/mm.c b/net/ethtool/mm.c
index e612856eed8c..fce3cc2734f9 100644
--- a/net/ethtool/mm.c
+++ b/net/ethtool/mm.c
@@ -247,5 +247,5 @@ bool __ethtool_dev_mm_supported(struct net_device *dev)
 	if (ops && ops->get_mm)
 		ret = ops->get_mm(dev, &state);
 
-	return !!ret;
+	return !ret;
 }
-- 
2.34.1