From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     netdev@vger.kernel.org
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Gerhard Engleder <gerhard@engleder-embedded.com>,
        Amritha Nambiar <amritha.nambiar@intel.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Ferenc Fejes <ferenc.fejes@ericsson.com>,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        linux-kernel@vger.kernel.org
Subject: [PATCH net-next 08/12] net/sched: mqprio: add an extack message to mqprio_parse_opt()
Date:   Fri, 17 Feb 2023 01:21:22 +0200
Message-Id: <20230216232126.3402975-9-vladimir.oltean@nxp.com>
In-Reply-To: <20230216232126.3402975-1-vladimir.oltean@nxp.com>
References: <20230216232126.3402975-1-vladimir.oltean@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?EED9sLfd8PfFjkI7QWCphD0nShZdLDQsqAFFtCIejKFMwsSBiY4Xz27P+arv?=
 =?us-ascii?Q?p17rvTlVIKFmRwc10j8Yp3iOr4k9atEq+SS+8IVjXQMWdtJLeUlOExgfAVea?=
 =?us-ascii?Q?HVA8aC5PtOQrcyw9p5BKz+2ThQQqPaSpXO60h7fK5VvVsrWoNP/IVPrgjFTk?=
 =?us-ascii?Q?C2e8qSaCDI6TU0e8evdhAQWds6YuqMmjAAktYgB8JupM7hJ4a1EARK85pN7O?=
 =?us-ascii?Q?SGLnDkkBMtQ6rLOupze6HlvlQoBSImbmyIWCsQLYkpGv9vYmOdq/rY4LPtl3?=
 =?us-ascii?Q?YfFOzYqDkGHRJDtO5nhnO1/VUQoeaIAc3swA0WKG47Gclpt3NKEuA7/WZmJ9?=
 =?us-ascii?Q?vTr2B2No/qCPJRX0UwwbIrX3noUzM/zOwswgo0ls68JXDxXCqqdOJMTLtU7A?=
 =?us-ascii?Q?TGFAbvIsVlU13+o/Ocr6zNpSg0Mj3PN0OzE21mQoxPjXCzEI6hNqwO80AXRG?=
 =?us-ascii?Q?s5OxtGFI+k+ZXmAhoyLUBCg9kO7sGYyk0YPHWFGX0IAw/p6zAdwmOsDHE+o2?=
 =?us-ascii?Q?/p4r6mPvIOsdtf+HtbbVyBNiNiMUKLACBlgVlEhRbaB3xXp9zvOEtJM9fubA?=
 =?us-ascii?Q?gAkBLGitVrdESBq1D7HuWYjEF4plswD4ZRGI64aVb4ICvnbm63q4eUruPfGp?=
 =?us-ascii?Q?2aZvET3DKOkeQAnAGxadcncU2b4689KpTn9ftvhGbglPpkjhjlQHlIWBfcMv?=
 =?us-ascii?Q?OqPQ63+WbDEMGznlSLUbc42Yik5lTZJYR9h2+/Ag0n3lXjZ90PKrPwflTrhJ?=
 =?us-ascii?Q?YwYOlMP/6JSWi+xwG6UfrAjJIGdQH8cNt1Kuip3vvcHsnZXG4Odfjuwlaz2N?=
 =?us-ascii?Q?GHFOY6JVc3+rekIrmGmuxYMOir3J0r7+xDAJ4bswInMsqU2yVEGesqgJq5l7?=
 =?us-ascii?Q?m+BiN30PZ6mrieEgOvy8c2fVkIRI5d94U/M928aJTA6gRiy97IhPsSUt18lD?=
 =?us-ascii?Q?Ywc51Ccr5+XA3shOJ94fWnEbKqVjlBuv7U/05JHIVeMABq574xOcUDH+fTDT?=
 =?us-ascii?Q?rZ/GV7ItB3iH5LdyoN5CR03eJBrsI/atLljqtg9EXf6CMz42UAdzIsCeNxSk?=
 =?us-ascii?Q?zm+fpE5BLMorD2T7l9ljpzAiRNZ5zpE2+GEZLr50VTmhZV63I7wMy8IYGT0H?=
 =?us-ascii?Q?yvL/yaVXFcLyvhRtDIuFLGSXCzkYR4kWeAD5Ae3uLBWjWGTEpBiDnNmwR6PP?=
 =?us-ascii?Q?mZol29sjbjZaGa7fgH9vypt4KJ9iSl3MUixZwVaAhjMwvrNJCq/zJhd6k6Wz?=
 =?us-ascii?Q?1+5Fg8bpoQe1w3Bvi69mKZiAl9fhN8fW8shA6uDmwGz00KtBbBT/fmnNvO3l?=
 =?us-ascii?Q?jEbNBm+BIVJjjoCQRNdAALcOr7nu1dZODelh8zMphhKp9jW/7g3c4ul3DnFr?=
 =?us-ascii?Q?mbNFSLivJ8MSuaAAT/ISSh23Soh6e34kVgVQcjkh2Y6c+1V4xO+9q/FCs9OZ?=
 =?us-ascii?Q?5a/071GlC4DLkhuliSGQ4NGH0Km1ur8Cv6tMhHaMuC3DtBv8iogDwr6qy7x3?=
 =?us-ascii?Q?1vAw/Z6uxqZB14mzv6C67hn5jmtTokUnrHyCSIfGUsAB7cXjQGIrildmz8bh?=
 =?us-ascii?Q?TtFTx0iLQIxRtJchpYSQ1SUbrxbWxvarcw/KlqWewVq758EorclwnlSnLRRv?=
 =?us-ascii?Q?dA=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ab0c7b92-7090-4cf2-c3b8-08db1074944c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 23:21:49.5710
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XON40SMMTeM+FxisnyXbs5yoCniowuIGtUqisJ/FHB1YsWgv3MFTC0lJ36003TYy4HhIoeeSvV/uhZ3OdMjHeg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7436
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Ferenc reports that a combination of poor iproute2 defaults and obscure
cases where the kernel returns -EINVAL make it difficult to understand
what is wrong with this command:

$ ip link add veth0 numtxqueues 8 numrxqueues 8 type veth peer name veth1
$ tc qdisc add dev veth0 root mqprio num_tc 8 map 0 1 2 3 4 5 6 7 \
        queues 1@0 1@1 1@2 1@3 1@4 1@5 1@6 1@7
RTNETLINK answers: Invalid argument

Hopefully with this patch, the cause is clearer:

Error: Device does not support hardware offload.

This was rejected because iproute2 defaults to "hw 1" if the option is
not specified.

Link: https://patchwork.kernel.org/project/netdevbpf/patch/20230204135307.1036988-3-vladimir.oltean@nxp.com/#25215636
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 net/sched/sch_mqprio.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/net/sched/sch_mqprio.c b/net/sched/sch_mqprio.c
index 18eda5fade81..52cfc0ec2e23 100644
--- a/net/sched/sch_mqprio.c
+++ b/net/sched/sch_mqprio.c
@@ -134,8 +134,11 @@ static int mqprio_parse_opt(struct net_device *dev, struct tc_mqprio_qopt *qopt,
 	/* If ndo_setup_tc is not present then hardware doesn't support offload
 	 * and we should return an error.
 	 */
-	if (qopt->hw && !dev->netdev_ops->ndo_setup_tc)
+	if (qopt->hw && !dev->netdev_ops->ndo_setup_tc) {
+		NL_SET_ERR_MSG(extack,
+			       "Device does not support hardware offload");
 		return -EINVAL;
+	}
 
 	return 0;
 }
-- 
2.34.1