Date:   Thu, 16 Feb 2023 19:58:29 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc:     LKML <linux-kernel@vger.kernel.org>, iommu@lists.linux.dev,
        Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        Jean-Philippe Brucker <jean-philippe@linaro.com>,
        Robin Murphy <robin.murphy@arm.com>,
        Will Deacon <will@kernel.org>,
        David Woodhouse <dwmw2@infradead.org>,
        Raj Ashok <ashok.raj@intel.com>,
        "Tian, Kevin" <kevin.tian@intel.com>, Yi Liu <yi.l.liu@intel.com>,
        "Yu, Fenghua" <fenghua.yu@intel.com>,
        Dave Hansen <dave.hansen@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        X86 Kernel <x86@kernel.org>, Dave Jiang <dave.jiang@intel.com>
Subject: Re: [PATCH v3 2/5] iommu/sva: Move PASID helpers to sva code
Message-ID: <Y+7DJXWKI+qh1bg4@nvidia.com>
References: <20230216235951.3573059-1-jacob.jun.pan@linux.intel.com>
 <20230216235951.3573059-3-jacob.jun.pan@linux.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230216235951.3573059-3-jacob.jun.pan@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5e4hsuUglF1SLs2XDmp0eRz/R9qFjDMSsvurLe9u0C/t4rtZuEF2zyoUv82t?=
 =?us-ascii?Q?APgBfexBg/hFk5Q3+JPUHo0hv7j/HbIYokm6/72UDQ8uJ54aPZNH3yfGxaoy?=
 =?us-ascii?Q?qiSNRLhSXJkkaG2hk88O+6wP57K1j9Dk0fG5UXWpQKx+96ooN2puryZIjV7D?=
 =?us-ascii?Q?Q8VHg/nWiVq4+YvC08Tycnsl458Awcs/bQtGdw3sjglUT7MFDmGFZfLvmZom?=
 =?us-ascii?Q?oZZ1aJz4aKsYhUHHF6pYjP9tRvb7GPalJxDaytUSPV8VhxcjLtoP1KD/6wNd?=
 =?us-ascii?Q?U3a7SBL1s5R2TkxI2pbunKmeTFGYUj2GoKZTooXviQomO4TjFA8WjZG7+/l1?=
 =?us-ascii?Q?mOhD1hoQjt5pSaSuuX68uQZzuDmdQjq2/Z0opYEbFzj9LlwPioeaIFWUUt2q?=
 =?us-ascii?Q?cD28QLse0s7p2Mf3j1/fKVKe1Bp+LML5MMHXXvkcYp3aUwkVqiE4CnXuUGLy?=
 =?us-ascii?Q?dlImw7qbqOrwpgKd3cNks8ZjpjRz3kz2sUDFFfX7lhDeqDIMk12X2V4ODucr?=
 =?us-ascii?Q?cRdKf/+71hEriDYVkb7oKW6FN66U0dmTB5eeubHmEdPPvHFvUaSFSWQwrHTY?=
 =?us-ascii?Q?3Dz1lKlZkmUNlSdvIxhQz2YJHvLTQs9R2qVFF+k/jaF20FU4FyrooDf5awzK?=
 =?us-ascii?Q?qTWN5OTSedgVqGXRhemAiCmIVkmy6TpgmGonys+lOlXnfhW3HXy56jalX1rO?=
 =?us-ascii?Q?NfGzbrJ+hpacSCWbEE+5qDNBDDsWTeJRo1t7P98mV/dUkKvI4L+fkzBXATOB?=
 =?us-ascii?Q?g0iIbqDgAYoTYHtA1C/YqydZygz0NmqhwBvsmn4t17pe0EuoU+VexHeaMPMB?=
 =?us-ascii?Q?gArvWDiEXM17wBiQZn2zVSAn0bjTGu5s9DaSlho/ae4cWzOTe24wgGD4y0YD?=
 =?us-ascii?Q?Ln8/BPdw6c1a7rgbFA+qw55IzPmzuRVbhwQGAB+RgJTeGI6FcVMeWglCY4WU?=
 =?us-ascii?Q?BTtJMT66sCKzwCSusIV1aKHspFcmmMxie5ushudQC0m6dfVaRIjVS66PFQuF?=
 =?us-ascii?Q?PKG5UOJOxxtmWLtb89zWH8BaPNhJX/SoCuJwcLpJ0PrpTL9A0mYLqFNXhk0j?=
 =?us-ascii?Q?/ZJx1KboCW8SZyyxbo2n+GVzkBkUBKqVpaJdmFaCOTt1a0z3Vr9J2djrEJ9V?=
 =?us-ascii?Q?g/Ss1eHNlosKIopvQrRa5+2gkdKuiJyjDrTsVlEmMnBW8vGFWna8tsS51hEY?=
 =?us-ascii?Q?KrS6nIwTDAaGZ+zXdFx9hpRA/cAi+FJNxAP1S6i97HDCXQJxErKP+t/oGkS4?=
 =?us-ascii?Q?jcp7z0aI4uT1HWWpvH2MOXfQ4D1G59Nkv4dSmLBemz8lfH+8B30rc4sWvTp2?=
 =?us-ascii?Q?m51NTmFKbavE6vuIor6cJu3/E3ojKhPl8VwQM0MG0yIqrNvwA6h8LjHr6k+2?=
 =?us-ascii?Q?7HrXbUbnychMVd/ZHShFd0VaBvgQMDwd49VZ4tWOWurNsanp3dAzYmquBHpg?=
 =?us-ascii?Q?H1YyyyKcIqn/1pk/Eik5OgsxtW6vsChuPm7F8hJKO06l0elYJ8V4mW2nNfdJ?=
 =?us-ascii?Q?bDObDcSE9cldYhkGds8yzOrguVQgMOHkGL5/wLdpCB2X9nq0MWZpdgSxHWq0?=
 =?us-ascii?Q?Q4CzgFRNssJVLEFLBB/4NzXFCpzsBqEoG9g11ede?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 46563c6b-9b5c-46ab-cfd5-08db1079b7b6
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 23:58:36.4074
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jg7bPzMwO1knD9/XedWnJ0LSblmrw+U1M187NKIfwcxdBmVTB7WW15/AcwAm/Ld/
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB8558
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 16, 2023 at 03:59:48PM -0800, Jacob Pan wrote:
> Preparing to remove IOASID infrastructure, PASID management will be
> under SVA code.
> 
> Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
> ---
>  drivers/iommu/iommu-sva.c | 19 +++++++++++++++++++
>  include/linux/sched/mm.h  | 22 +++-------------------
>  2 files changed, 22 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/iommu/iommu-sva.c b/drivers/iommu/iommu-sva.c
> index 24bf9b2b58aa..a3ee258936f0 100644
> --- a/drivers/iommu/iommu-sva.c
> +++ b/drivers/iommu/iommu-sva.c
> @@ -71,6 +71,25 @@ struct mm_struct *iommu_sva_find(ioasid_t pasid)
>  }
>  EXPORT_SYMBOL_GPL(iommu_sva_find);
>  
> +void mm_pasid_init(struct mm_struct *mm)
> +{
> +	mm->pasid = INVALID_IOASID;
> +}
> +
> +/* Associate a PASID with an mm_struct: */
> +void mm_pasid_set(struct mm_struct *mm, u32 pasid)
> +{
> +	mm->pasid = pasid;
> +}

This is only called from this file, just get rid of it

It would be better if the other two could remain as inlines given
their impact on the fork path..

Jason