Date:   Fri, 17 Feb 2023 03:11:55 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Colin Foster <colin.foster@in-advantage.com>
Cc:     "Russell King (Oracle)" <linux@armlinux.org.uk>,
        linux-phy@lists.infradead.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Kishon Vijay Abraham I <kishon@kernel.org>,
        Vinod Koul <vkoul@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>, UNGLinuxDriver@microchip.com,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Lee Jones <lee@kernel.org>
Subject: Re: [RFC v1 net-next 0/7] add support for ocelot external ports
Message-ID: <20230217011155.4ztjsiqnzhvxvf3b@skbuf>
References: <20230216075321.2898003-1-colin.foster@in-advantage.com>
 <Y+4eLmpX9oX3JBVJ@shell.armlinux.org.uk>
 <Y+7NXoFTBYVG3/+b@colin-ia-desktop>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y+7NXoFTBYVG3/+b@colin-ia-desktop>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?invzcK0ImrdhGVqIMLvoJ9zw38z8VdPD9nRvh/WRqakAX+XF4ZHcELd/dlWC?=
 =?us-ascii?Q?aAEShTkR4tOsEi6uhRxTHR4wBhTo0OazQS9ey4n0BrTRNaWpXFBzTnRaN2EK?=
 =?us-ascii?Q?NoIaCiEeUDQrr+nG8H2h7kp32ujLvbWJIJzoIbolSNTrxW31/MYpmTyFZhMk?=
 =?us-ascii?Q?JvAv8JyxfHOUoQu2KOZ6alVxYBE5Ovsk7D1j1t7m3fKJJYfpPyASGKupRmAO?=
 =?us-ascii?Q?mVEA8rIb4sF/LNRjOLwGS0WJqrKmJhlSAaBkBP40TumedBMMTBO//9aH2k/x?=
 =?us-ascii?Q?mthtzZm8lN5VbTav2z+3q9uEQKPqOK6/jk05ze7Ho0n+m10qFwjxquDSLGsq?=
 =?us-ascii?Q?N8D3nrEo2ACPjKLydM5rex3BE2q7wWwakSsc29WBU2paCMrTozf+iTG25fiu?=
 =?us-ascii?Q?D+CHt8E2SgUk1VXQaMjzHuCCElKsIjY+XepRELmG0tKVyo4j1D5mI8a2zS2T?=
 =?us-ascii?Q?CS3F/6gncsVJj5aSACa8I5heV+7Wp7fKx5tpqmLxiObjsc3ur8nqa1+DPRy9?=
 =?us-ascii?Q?iPYQKUzrygdwvZ7sIxrjW+4X7oBKqIBpWNVswJD0ZTbEWiUyVxIs5LhSSFDJ?=
 =?us-ascii?Q?o0nadRAi0zd/Ux783klLfh9pIeQJG58BhAXGW/zNnOYsUhpnDbXxRjfIHE0F?=
 =?us-ascii?Q?bw37s/XSpd9juIbIIWUKgIEDAC36DeBMyKmPY2HC9BzT4lCjnIO7kMb/cyvo?=
 =?us-ascii?Q?TY31I51kTpyrhU3insd2SC7eLQC1rSYqIUnCGCSE4vAxGqBdOee5yrFYCvsu?=
 =?us-ascii?Q?5uBG/dW+/4zkhGz301rH3L8saYmf+y8R4YGqrGC5sykimn7cS91/iDV0+PeQ?=
 =?us-ascii?Q?KGSrrLuwhqLXjaY7SnXGufpbvH8yg3bSMiAUSMWzkXn+E2E6rrGP7I5STTkC?=
 =?us-ascii?Q?IGZjOaewuII63TKuTgzm/DDU5Dr6CyLhMregniclYNzI5eNp+RHpO5zpHPN6?=
 =?us-ascii?Q?5P//Lxu7brGf/OL2aT+5XSpy8eIbG+MZq+eTo9VGjUF/NQvv6VyBwZTe71Zs?=
 =?us-ascii?Q?CYvwpG2GI1rDyQIjN+MRrIu5hqyaNeGklzPVu6qWn1W47kIR+NeY4G2V+iqZ?=
 =?us-ascii?Q?fbIHvdZouQkVQqPi7wriHsZpTNPjaKor4szjkWR+cMUliImkNBKjIkmeIUdX?=
 =?us-ascii?Q?GBYej1kh6pBwDABktSsdHCuVAxD4R9kQwdx/kgG+3rDsvF/TP0wcZF51nHHO?=
 =?us-ascii?Q?OBqHIlWAXPlTwixYDBdVTCXzUCVQW8Xkv+eXaeUnHomIKCEOZJ7Pa+W4j1rt?=
 =?us-ascii?Q?5+B0z6ArwlmfdmSBGlRiyhH2SyGeSuVFRdOQGEfpCvBiXaSA2NakJRjAT2Pe?=
 =?us-ascii?Q?qO6cycAn9w9XpnkqA7XHTcpm3dTlIRM3rVS0IvHqxtOLyHrNiXcJXLJAZqlq?=
 =?us-ascii?Q?3Qsb6lcTAyAPKh0wJ+iviGuDoe9J0aNtVRPNDW0BUqxgSgYBOcL0+uwL7eeW?=
 =?us-ascii?Q?qSNUd4kKW9TA0le/8VkxGAKTvHhcrgq4dyzGIh58FVZ+6a2KKwN70D/crUyS?=
 =?us-ascii?Q?CA8at8pKyiZCThl2+MzvxR8MUJt1N8OHjbnUXRLPLKp2wS66ot4PbQzl/P/V?=
 =?us-ascii?Q?cS0NSIQ9m0k7cPqkI3vnY3vToDzYu4VIYARsEHY5Tvexm7XvA611E7nxNFBj?=
 =?us-ascii?Q?2g=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e5e360a9-dcfa-4dd8-6449-08db1083f746
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2023 01:11:58.0277
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vhRUME4BADmIZG+sYYJclsUVW9nwysOYohruqn5BGhsmDqzUtAJj/9EBzmfKj6xn7WYRCaLcqxTIB8dr/TpAEA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7380
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 16, 2023 at 04:42:06PM -0800, Colin Foster wrote:
> I believe the main gotcha was that control over the phy itself, by way
> of phy_set_mode_ext(). That needed the 'struct device_node *portnp'

DT parsing in felix_parse_dt() is not the only DT parsing that is done,
and certainly nothing depends on it in the way you describe.

dsa_switch_parse_of() also parses the device tree. felix_parse_dt() only
exists because the SERDES/PCS drivers from NXP LS1028A do not support
dynamic reconfiguration of the SERDES protocol. So we parse the device
tree to set the initial ocelot_port->phy_mode, and then (with the
current phylink API) we populate phylink's config->supported_interfaces
with just that one bit set, to prevent SERDES protocol changes.

Do not get too hung up on this parsing (unless you believe you could
simplify the code by removing it; case in which I'd be interested if you
had patches in this area). Each port's device_node is also available in
struct dsa_port :: dn.

> 
> .... Keeps looking ....
> 
> Ahh, yes. Regmaps and regfields aren't initialized at the time of
> dt parsing in felix. And the MDIO bus isn't allocated until after that.
> That's the reason for patch 6 parse_port_node() - I need the tree node
> to get MDIO access to the phy, which I don't have until I'm done parsing
> the tree...

Nope. Device tree parsing in DSA is done from dsa_register_switch(), and
dsa_switch_ops :: setup() (aka felix_setup()) is the first callback in
which the information is reliably available.

You can *easily* call phy_set_mode_ext() from the "setup()" callback.
In fact, you're already doing that. Not sure what the problem seems to be.
It doesn't seem to be an ordering problem between phy_set_mode_ext() and
phylink_create() either, because DSA calls phylink_create() after both
the dsa_switch_ops :: setup() as well as port_setup() callbacks.
So there should be plenty of opportunity for you to prepare.

> There might be a cleaner way for me to do that. I'm tiptoeing a little
> bit to avoid any regressions with the felix_vsc9959 or seville_vsc9953.

I can test those. I'd much prefer if you made an initial effort to keep
a relatively consistent code structure.