Message-ID: <04a598d8-eeee-9512-7db9-cfeae33999a7@intel.com>
Date:   Thu, 16 Feb 2023 17:42:43 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [RFC v2 PATCH 5/7] x86/resctrl: Introduce -o debug mount option
Content-Language: en-US
To:     Babu Moger <babu.moger@amd.com>, <reinette.chatre@intel.com>
CC:     <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <corbet@lwn.net>, <linux-kernel@vger.kernel.org>,
        <linux-doc@vger.kernel.org>, <eranian@google.com>,
        <peternewman@google.com>
References: <167537433143.647488.9641864719195184123.stgit@bmoger-ubuntu>
 <167537444491.647488.11815488030989406143.stgit@bmoger-ubuntu>
From:   Fenghua Yu <fenghua.yu@intel.com>
In-Reply-To: <167537444491.647488.11815488030989406143.stgit@bmoger-ubuntu>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dG9VTVFweU44UFlDOU9oeHVkblNsVU1lNzkzUjhod0p6aGZZbkRpTnZLcjdo?=
 =?utf-8?B?TlhiY2laNmxxaXBaWDJNSWltektaUkV6b096eEN4eEpOaWdPd2FBanZZaUNj?=
 =?utf-8?B?V2NVWVV0NEJjWWsxaEtTVnZwUDZOWVVMRWMyVEllZEtkaTFuRGlteGtVVjRr?=
 =?utf-8?B?a1N6c24rNHhRZXNCS3gwNjhqSThPTjNEdWloSkZrVEowSEFjVEl3VkFXejRV?=
 =?utf-8?B?bENISFpmNDZMbXZSN0dQQUJGL1VKMFczZXhrTU5tL0hPZUIvL09yRjI1Njdw?=
 =?utf-8?B?TWxXc041OU1yR3ZwajhaMisyNUtrZGJrYXV1VHJ6ai9iZUM0OFpXR3BxSEpl?=
 =?utf-8?B?ZjcvMDlQUDVqYjVpMHJQU2loTjAvODAyZy9IRnVQdWxmMk5vUGN5S1FMOUJY?=
 =?utf-8?B?TGtqMXNEWFUrQjFvWmsySkR2eGRaWEFibHlhUVhqcXhQaUZyOXFkZXFyNEtu?=
 =?utf-8?B?RnJhSmFsVWpuVzE1cGNxTXFHN0JHNG1aTFoyQUF1Q2Nkc2tXazVZaVVPU0R2?=
 =?utf-8?B?UmhMOTJUa2pINExLTStaeFhVaFhMOTFXSnVGY3cwbmNZVGRvYmtPcDVJUEZs?=
 =?utf-8?B?WTBueUpPTS80RGNEdUFHakJ1eEc2Qjg2c1V6VWVvRVE3OHFEQStEam91Q0oy?=
 =?utf-8?B?cWJmM3RjZXExanFMb09qMlc1YXBqb2E3MVk5dW1jRXgzRVdlbURvNjlIcWZO?=
 =?utf-8?B?WGhXMkJqYVhJNDhBblRiRUhkbXZhckZRbFZQNjlEazg5bG85TS9XVElIeUQ0?=
 =?utf-8?B?UGRSMTZVWGhnUU1ENVZ5MlVkc0RpMHNLZWlqSjcxeTNtdzlOY042cGIzeGFs?=
 =?utf-8?B?Uk42VnhNcDlRN3lybEpTZG5IT2I1SS9XdGxCRDVMNlZHUnBWYnVIOWVicXlk?=
 =?utf-8?B?TWU5cGttRUhyOHFjbmNQRjJORFZJT2FnQm9nWXoxQ3RaejNjOGlmU0FzTVoy?=
 =?utf-8?B?UnRmWFQ4VFBmNXFFa283MThhV2RIWlBMNFVOUkpYcHhiazNmK200TTVMSGov?=
 =?utf-8?B?by9OSTFPL3NKSkR4Z292YlNETW9hWEJMOE84Q3Vsb1Nod0U2T0hFUXNrSTlH?=
 =?utf-8?B?T2NJT0g0MzIyWUgyeEErTjZDMTNUUkVyK3A1QUdEdWdVWm4zRW0xMkYyNEpq?=
 =?utf-8?B?WTNESUR6ZTBCaXl6bUZrVFFYZm5GaVRKRThLMmhIZXhKbG55OVIxRTVhaTV2?=
 =?utf-8?B?RjJiRTZMS1YwcWlMZmdReURDRGR4Wi9wNlZGMEpZMGdPVG5SNUVrVjdkZ1d5?=
 =?utf-8?B?VEE4cjJJamlXb1NFSXJFa2hWWC9rSlJyY25hYzVsdlhsTU4rZmRaZzhWZldk?=
 =?utf-8?B?TlFWZ3hqVG9rRm9SazlCMVR2U3NPWHRlNFcyQlh6ZlBqQkVOVy9idFdFYytE?=
 =?utf-8?B?dlc4MFREL0F3Y00vaEdXclRvTFo3NmFYUDlrSWNvWVRPeDB0OU9WM29lQ2Nv?=
 =?utf-8?B?ZE5CQTVVeHFjaU9PclcyblpNMmk0QktMUFlpZ0JBak81UzJEc2YrYUZDTE1t?=
 =?utf-8?B?b0h5aUI0TUxxMWpxS1lJVGdoZ1FieTNLUXVveVIzVnI4ZUdVanRCU3BLRFdF?=
 =?utf-8?B?UUJ2TXcrc1o1QkVSVnM2eVFHa0dKMW5RbVB5RnhaakliRFhQQjRpYVBBYTFH?=
 =?utf-8?B?YjhaVHhsQittQjVnejdGeHhhRjVqKy9nWHRQanBIcy9BRU44VXI3TVNjbHZ5?=
 =?utf-8?B?akZmNGdMdEZqT1RzYXlVVVhucTI4cjBhQUJSU2VyTitNNW1uM0txZGRlc0sy?=
 =?utf-8?B?ZDgybmFxckpkUVo1VUdxQjhKelFJUU1URzg4cnYyaFZXeVVTWHErNTIzQ29Z?=
 =?utf-8?B?Z3RLbDd0VmtiaXhpNElkT3BoQ3FJQUs0a3dsODJPT2g5S0lYN2tmZCs4ZXk0?=
 =?utf-8?B?MGlsam5lMFZiVjNYS3F3V01LalVhbDltWXYrUlZtaitkTjhYeEdCQytsektP?=
 =?utf-8?B?aksrTXQwL0VMRUFTallJcGVBZHRvOGsxTlRFbVVZMlhYR2tSbWNtY2FwOW80?=
 =?utf-8?B?L1VXNnI2UGVCVlVBbzN6SENtUEN1WHEwMmJEL0F5S015bjkrUk9YRWtVeHRz?=
 =?utf-8?B?WTJocmdYSTUyUDNuT2l5ZTZzVUxEM0k1dDlVWGVFbzN3dHVSTngzallXTFZT?=
 =?utf-8?Q?DDGNy9u3YkLgWq3OjwiP8AyJX?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c1c953c4-6277-434a-07b2-08db10884453
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6097.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2023 01:42:45.3614
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CQrHdMyc8uhiqAw/qVFDWAKCWPRJ1tf2HjuqYDsaU1D/qlxvAgzedC1G5dX/4EKS6SOx66tA5BAwjzQzGzmBIQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4776
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi, Babu,

On 2/2/23 13:47, Babu Moger wrote:
> Add -o debug option to mount resctrl filesystem in debug mode. Debug
> option adds the files for debug purposes.
> 
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> ---
>   Documentation/x86/resctrl.rst          |    2 ++
>   arch/x86/kernel/cpu/resctrl/internal.h |    1 +
>   arch/x86/kernel/cpu/resctrl/rdtgroup.c |    7 +++++++
>   3 files changed, 10 insertions(+)
> 
> diff --git a/Documentation/x86/resctrl.rst b/Documentation/x86/resctrl.rst
> index 58b76fc75cb7..2c013c5d45fd 100644
> --- a/Documentation/x86/resctrl.rst
> +++ b/Documentation/x86/resctrl.rst
> @@ -46,6 +46,8 @@ mount options are:
>   "mba_MBps":
>   	Enable the MBA Software Controller(mba_sc) to specify MBA
>   	bandwidth in MBps
> +"debug":
> +	Lists the debug files in resctrl interface
>   
>   L2 and L3 CDP are controlled separately.
>   
> diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
> index 6767c85b9699..35a9ee343fe0 100644
> --- a/arch/x86/kernel/cpu/resctrl/internal.h
> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
> @@ -59,6 +59,7 @@ struct rdt_fs_context {
>   	bool				enable_cdpl2;
>   	bool				enable_cdpl3;
>   	bool				enable_mba_mbps;
> +	bool				debug;
>   };
>   
>   static inline struct rdt_fs_context *rdt_fc2context(struct fs_context *fc)
> diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> index 18d458a3cba6..9b7813aa6baf 100644
> --- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> +++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> @@ -2555,6 +2555,7 @@ enum rdt_param {
>   	Opt_cdp,
>   	Opt_cdpl2,
>   	Opt_mba_mbps,
> +	Opt_debug,
>   	nr__rdt_params
>   };
>   
> @@ -2562,6 +2563,7 @@ static const struct fs_parameter_spec rdt_fs_parameters[] = {
>   	fsparam_flag("cdp",		Opt_cdp),
>   	fsparam_flag("cdpl2",		Opt_cdpl2),
>   	fsparam_flag("mba_MBps",	Opt_mba_mbps),
> +	fsparam_flag("debug",		Opt_debug),
>   	{}
>   };
>   
> @@ -2587,6 +2589,9 @@ static int rdt_parse_param(struct fs_context *fc, struct fs_parameter *param)
>   			return -EINVAL;
>   		ctx->enable_mba_mbps = true;
>   		return 0;
> +	case Opt_debug:
> +		ctx->debug = true;
> +		return 0;
>   	}
>   
>   	return -EINVAL;
> @@ -3525,6 +3530,8 @@ static int rdtgroup_show_options(struct seq_file *seq, struct kernfs_root *kf)
>   	if (is_mba_sc(&rdt_resources_all[RDT_RESOURCE_MBA].r_resctrl))
>   		seq_puts(seq, ",mba_MBps");
>   
> +	seq_puts(seq, ",debug");

Need to add a check here otherwise ",debug" will be always shown 
regardless "-o debug" is given or not:
+	if (ctx->debug)
+		seq_puts(seq, ",debug");

But I don't know a good way to get ctx->debug in this function yet. I 
think somehow ctx can be retrieved from kf but not sure.

> +
>   	return 0;
>   }
>   
> 
> 
Thanks.

-Fenghua