Message-ID: <0b42ee96-32cf-b929-6033-7898821b54cb@intel.com>
Date:   Thu, 16 Feb 2023 17:46:33 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [RFC v2 PATCH 6/7] x86/resctrl: Display the RMID and COSID for
 resctrl groups
Content-Language: en-US
To:     Babu Moger <babu.moger@amd.com>, <reinette.chatre@intel.com>
CC:     <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <corbet@lwn.net>, <linux-kernel@vger.kernel.org>,
        <linux-doc@vger.kernel.org>, <eranian@google.com>,
        <peternewman@google.com>
References: <167537433143.647488.9641864719195184123.stgit@bmoger-ubuntu>
 <167537445137.647488.9039585071837467840.stgit@bmoger-ubuntu>
From:   Fenghua Yu <fenghua.yu@intel.com>
In-Reply-To: <167537445137.647488.9039585071837467840.stgit@bmoger-ubuntu>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UDhhTm9SR3pFb3J5Vmp0dk1NVFFWNHMvVUFuMmdEVHNGYy9XM1N3c1dOUGlZ?=
 =?utf-8?B?SzNTMUs1QTNuUVgvemZvQm1rN2dDUmVzbUw0OUg4YXM5NU80ZTZGeU9LNzdX?=
 =?utf-8?B?WFdPTjJ6bXFVNStxRDBEWlhDc2swUUNuVnJYZWt6Y3FwcnZ5RjROMDhKQmJv?=
 =?utf-8?B?eWRJaWNtUkNhWG9ET2tCNFprUlkrVzZqWnE1cUlianhENUw0Znd0M0tDeUVn?=
 =?utf-8?B?T3E3RFZlSVdFK0crcEpYY3MyK2laN0xWbFJiV2ZVNnBqSjZkbUIvMk1RWGRX?=
 =?utf-8?B?MjgyWFdmTkczTld1NytOeXpLWXk1TytJTzBmQ0F3NitFdDJBODdxcE1zWDhx?=
 =?utf-8?B?SnpRb3Bza1pjcWhSdG1SQ1BncXNUeXU3QTlzRW5GZUpzeU9DbEtXbDdsNm1r?=
 =?utf-8?B?RjYyemNmVTRBTVlhZDljdjZaR0hIY3ArMHVVQVZ2cjZXOHB0c24wanQxVytx?=
 =?utf-8?B?ZlFGQlM5Q256R0xoOXkwY2toMGlXMGpVWFpGV21Vbk9HWWQyRk03Njl5UGdP?=
 =?utf-8?B?dnY5UWRoWnRVcDRZcEFUa0tzRHJJNTh2U010ODdHaHI0MllLSHRRR3QrbEQv?=
 =?utf-8?B?RWJtbDVjRFd0ZlNSMXFodEdvbVhMUkpGRXNRVDhINCtEOW9lQ2s4Z2R5c1hQ?=
 =?utf-8?B?U3ZGS3Q1Sm5iN21jaGoxckZzRm1LZDhvVlorMmdYdTBSbkliL2V6NTFHY0NE?=
 =?utf-8?B?VlY0bzBhNmhwdkMxM2hLY2kxcUdGUGtKdkJ1ZU1sMEhISUpFRjFBUlRGN1hE?=
 =?utf-8?B?aDVodzdwTjRtODRRV3FjSVBtdnMrNzEyTzR2b254YzR4UndpUnpLNlBJUVlH?=
 =?utf-8?B?bytoUVl0T1NGMkIxQXQrVVFtQ2tWd2VsU25JdEtwOWx3V3hUK3Y5bXpOUGNm?=
 =?utf-8?B?cjZhV1FpM0RQZkJyN0hqcE1rV2hMOGZSUWZjRjJFcXNZNUdmRTVQQTFKa0Fk?=
 =?utf-8?B?Y0JsMkxIcE5KSlF6SEFCVms5eGhDbEg2RVNYQmlrUWtGZHhMbnJ6R3p3YTdK?=
 =?utf-8?B?RFgvRTZQank0ZG1WNDB4Wm1aN3NCWnE3V1JiU2Q0UWgvUHFVWlJQUktiMGRC?=
 =?utf-8?B?cVYxME8wSDFReUFISHhLYzZCbHRqd01UZFNhMTkvWFZEVy9xSHVaQ0JLZklx?=
 =?utf-8?B?elJKSFRUbzYxV0ZKbFVWNUlsbTNBK004RkVOSWtoNzEyaXExbUYwdG53blVi?=
 =?utf-8?B?ZkRJZ2lIbUJyVEJRbXNjTmRHOTRXb3VBc25VOUUwNnZJKy9NNnhrV3NTNnRm?=
 =?utf-8?B?QTZVUHNOOHFFQjZHa0lsSngvKzZ5cDdtdHQ2Z3NuNEVSTDF3OEtOUkp3aFFj?=
 =?utf-8?B?WGZOVVlpa1FCUHZGZndZZ2h5UE9hUmdUbDE1cTZMSkJ5ODNwTkRPY0JXVW5p?=
 =?utf-8?B?VzhveDVaRXdwd1dESHVTKzBVRW9vZ1FrNUU3OUxtWlhLWWhYeVo4eW5SS1Bv?=
 =?utf-8?B?eW5kU0YxWFRqT0hPMDNTSStJUDlNRUMwcXBpQVhudGVaKzZ0WFBSUGlISUVM?=
 =?utf-8?B?VjdxUTZvb0hVZmFEeTkzd2dseGV5L2VhWUdtVEVkZlRDdWNVdkpzU1dsWEVW?=
 =?utf-8?B?ejZKbnN0OFJQQXY4RS9xL2NmSDRqOXVpRm9SWklsdmE0UmNKU1EvUklwb3Bk?=
 =?utf-8?B?dU5kRVpDSnRwdGlBdVB1QXBjRExJYTVPWmQwNjVxYm8xTC9HMkZZMzdIYndV?=
 =?utf-8?B?RHhQSE1xZ3o5THVYN0RQbjYyNmMwcEJsZU5rakltQm8xcTJjUEhTd2VyWU9P?=
 =?utf-8?B?d1NoclF4N0hrUVl2OUFLSURQckN0VHovb0MzMEF2Y2NLZ2d2OTFKVmtJZWM4?=
 =?utf-8?B?YUpLSWMyV2ZKVUZzL21haGxMYVhFUDh2TlhMWTVyUUhwNUFTMXFUQ1F5bzBH?=
 =?utf-8?B?WWFPWTc4ZCtVcXlmQXl3Y2JHUkN1c1lKMk5VWDhWTHdOb3R2SUNlaDltMG4x?=
 =?utf-8?B?VmpuOFRsWUp2R0syb01qUUlsdjFnems2b1RZR2tZNkJqS3BHYkVzalE0dVVy?=
 =?utf-8?B?RXF2eFJtMUdibG5jUE52eXpiQ2pSTG9xNmowTTVySmZ4blpBT3poNjh4RmRp?=
 =?utf-8?B?WUxmaUdVREszdTJCZnBkV2R3NWFLUkx5Q3NCdzBsYnh3ZytGRjh0Wk5iZnJo?=
 =?utf-8?Q?xxgNuWrjevy77egRo2q/hNXH4?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c81e47ab-82a2-46fe-edea-08db1088cdcf
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6097.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2023 01:46:35.9640
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kCumGZhUPdHNQHhZxAAXb3Qr2gMNCOdtpceg8QhqHjzK+3zdBxB2OjGgSNA2G2o3QuKscfjbe5gBfHH5bN1ZqA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5244
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi, Babu,

On 2/2/23 13:47, Babu Moger wrote:
> When a user creates a control or monitor group, the CLOSID or RMID
> are not visible to the user. These are architecturally defined entities.
> There is no harm in displaying these in resctrl groups. Sometimes it
> can help to debug the issues.
> 
> Add CLOSID and RMID to the control/monitor groups display in resctrl
> interface.
> 
> $cat /sys/fs/resctrl/clos1/closid
> 1
> $cat /sys/fs/resctrl/mon_groups/mon1/rmid
> 3
> 
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> ---
>   Documentation/x86/resctrl.rst          |   17 ++++++++++++
>   arch/x86/kernel/cpu/resctrl/rdtgroup.c |   44 ++++++++++++++++++++++++++++++++
>   2 files changed, 61 insertions(+)
> 
> diff --git a/Documentation/x86/resctrl.rst b/Documentation/x86/resctrl.rst
> index 2c013c5d45fd..de332c242523 100644
> --- a/Documentation/x86/resctrl.rst
> +++ b/Documentation/x86/resctrl.rst
> @@ -321,6 +321,15 @@ All groups contain the following files:
>   	Just like "cpus", only using ranges of CPUs instead of bitmasks.
>   
>   
> +"rmid":
> +        Available only with debug option.Reading this file shows the
> +        resource monitoring id (RMID) for monitoring the resource

Capitals Resource Monitoring ID (RMID).

> +        utilization. Monitoring is performed by tagging each core(or
> +        thread) or process via a Resource Monitoring ID (RMID). Kernel

s/Resource Monitoring ID (RMID)/RMID/

> +        assigns a new RMID when a group is created depending on the
> +        available RMIDs. Multiple cores(or threads) or processes can
> +        share a same RMID in a resctrl domain.
> +
>   When control is enabled all CTRL_MON groups will also contain:
>   
>   "schemata":
> @@ -342,6 +351,14 @@ When control is enabled all CTRL_MON groups will also contain:
>   	file. On successful pseudo-locked region creation the mode will
>   	automatically change to "pseudo-locked".
>   
> +"closid":
> +        Available only with debug option. Reading this file shows the
> +        Class of Service (CLOS) id which acts as a resource control tag
> +        on which the resources can be throttled. Kernel assigns a new
> +        CLOSID a control group is created depending on the available
> +        CLOSIDs. Multiple cores(or threads) or processes can share a
> +        same CLOSID in a resctrl domain.
> +
>   When monitoring is enabled all MON groups will also contain:
>   
>   "mon_data":
> diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> index 9b7813aa6baf..c35d91b04de6 100644
> --- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> +++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> @@ -760,6 +760,38 @@ static int rdtgroup_tasks_show(struct kernfs_open_file *of,
>   	return ret;
>   }
>   
> +static int rdtgroup_closid_show(struct kernfs_open_file *of,
> +				struct seq_file *s, void *v)
> +{
> +	struct rdtgroup *rdtgrp;
> +	int ret = 0;
> +
> +	rdtgrp = rdtgroup_kn_lock_live(of->kn);
> +	if (rdtgrp)
> +		seq_printf(s, "%u\n", rdtgrp->closid);
> +	else
> +		ret = -ENOENT;
> +	rdtgroup_kn_unlock(of->kn);
> +
> +	return ret;
> +}
> +
> +static int rdtgroup_rmid_show(struct kernfs_open_file *of,
> +			      struct seq_file *s, void *v)
> +{
> +	struct rdtgroup *rdtgrp;
> +	int ret = 0;
> +
> +	rdtgrp = rdtgroup_kn_lock_live(of->kn);
> +	if (rdtgrp)
> +		seq_printf(s, "%u\n", rdtgrp->mon.rmid);
> +	else
> +		ret = -ENOENT;
> +	rdtgroup_kn_unlock(of->kn);
> +
> +	return ret;
> +}
> +
>   #ifdef CONFIG_PROC_CPU_RESCTRL
>   
>   /*
> @@ -1844,6 +1876,18 @@ static struct rftype res_common_files[] = {
>   		.seq_show	= rdtgroup_size_show,
>   		.fflags		= RFTYPE_BASE_CTRL,
>   	},
> +	{
> +		.name		= "closid",
> +		.mode		= 0444,
> +		.kf_ops		= &rdtgroup_kf_single_ops,
> +		.seq_show	= rdtgroup_closid_show,
> +	},
> +	{
> +		.name		= "rmid",
> +		.mode		= 0444,
> +		.kf_ops		= &rdtgroup_kf_single_ops,
> +		.seq_show	= rdtgroup_rmid_show,
> +	},
>   
>   };
>   
> 
> 
Thanks.

-Fenghua