Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F988C636CC for ; Fri, 17 Feb 2023 02:31:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230346AbjBQCbT (ORCPT ); Thu, 16 Feb 2023 21:31:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229460AbjBQCbR (ORCPT ); Thu, 16 Feb 2023 21:31:17 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F9774FCA1 for ; Thu, 16 Feb 2023 18:31:16 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2B8E9612C9 for ; Fri, 17 Feb 2023 02:31:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8139BC433D2; Fri, 17 Feb 2023 02:31:15 +0000 (UTC) Date: Thu, 16 Feb 2023 21:31:13 -0500 From: Steven Rostedt To: Jesper Juhl Cc: linux-kernel@vger.kernel.org Subject: Re: [Patch] [samples/trace_events] Remove unnecessary version.h include pointed out by 'make versioncheck' Message-ID: <20230216213113.6c4f59af@rorschach.local.home> In-Reply-To: <86718c8a-4a55-7254-f489-9c071588bc25@gmail.com> References: <86718c8a-4a55-7254-f489-9c071588bc25@gmail.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 16 Feb 2023 02:03:29 +0100 (CET) Jesper Juhl wrote: > >From 8917ba4246c3fa7344523a0c46b793c5dbb0400b Mon Sep 17 00:00:00 2001 > From: Jesper Juhl > Date: Mon, 13 Feb 2023 02:53:37 +0100 > Subject: [PATCH 07/12] [samples/trace_events] Remove unneeded version.h > include pointed out by 'make versioncheck' > The subject is not formatted correctly. There's no body to the commit. And the Signed-off-by tag is incorrect. Not to mention that the patch itself is corrupted. Please fix all of these. -- Steve > Signed-ogg-by: Jesper Juhl > --- > samples/trace_events/trace_custom_sched.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/samples/trace_events/trace_custom_sched.c b/samples/trace_events/trace_custom_sched.c > index b99d9ab7db85..dd409b704b35 100644 > --- a/samples/trace_events/trace_custom_sched.c > +++ b/samples/trace_events/trace_custom_sched.c > @@ -8,7 +8,6 @@ > #define pr_fmt(fmt) fmt > > #include > -#include > #include > #include >