Message-ID: <e887e0ee-b988-cd1f-d658-0667c69af1b8@os.amperecomputing.com>
Date:   Fri, 17 Feb 2023 09:36:10 +0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.6.1
Subject: Re: [PATCH 2/2] misc: smpro-errmon: Add dimm training failure
 syndrome
Content-Language: en-CA
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Paul Menzel <pmenzel@molgen.mpg.de>, Arnd Bergmann <arnd@arndb.de>,
        Joel Stanley <joel@jms.id.au>,
        Andrew Jeffery <andrew@aj.id.au>, linux-kernel@vger.kernel.org,
        openbmc@lists.ozlabs.org,
        Open Source Submission <patches@amperecomputing.com>,
        Thang Nguyen <thang@os.amperecomputing.com>,
        Phong Vo <phong@os.amperecomputing.com>
References: <20230214064509.3622044-1-quan@os.amperecomputing.com>
 <20230214064509.3622044-3-quan@os.amperecomputing.com>
 <866fe1b3-8044-6581-9711-452550f91198@molgen.mpg.de>
 <98b2a8d6-c5bf-a782-7fc1-8874f94edc25@os.amperecomputing.com>
 <Y+4h0V+LtaX8745A@kroah.com>
From:   Quan Nguyen <quan@os.amperecomputing.com>
In-Reply-To: <Y+4h0V+LtaX8745A@kroah.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VUlNcEI4NC9QalFCTjFEMFNKYWxVcWVNdGpOV3lqWitkejJIQTJQR0JUbzhU?=
 =?utf-8?B?dFVBbkRmSjQ0QjNoRXA3UDhCQ2JGcDRoUGhLdThvYmJOQll3Q05tNmxBNTVs?=
 =?utf-8?B?OGwrcmxMVmpNUFk2bEt5SGxiSzRFd1E2K0FHMXQzbndWdTVpYnAxQ3pFV0RH?=
 =?utf-8?B?VVFkV3ZqMjZ2OWd1ZDFrUWZHQTBqRWorYS9yL05LYlREZGhtTzJUemhKTkJ3?=
 =?utf-8?B?YVZmYzVTY2k5MHU1c3JTUDdJcm04MC9QYnFkV2RiR29Ta2xhOXowY1YxSXVu?=
 =?utf-8?B?a3JBTkNSRjBkWlBtd3Y5RFcxV1NCMVJoWVI4aGsrSC9McU5tdzBxaEJnWFJB?=
 =?utf-8?B?UU5XckxpQTRjU1RZWVc1UDJMVnJTOUxyZXNQV2NXTHowZVdkamJtM3Fpd1Z3?=
 =?utf-8?B?czI1S0RzNlNNbVBPWUZUOVdBMm1BbExiWERNZGRZRjF1SDJrVkZSbnB3Q1Qw?=
 =?utf-8?B?anRKaUd6N09uMmxsRTNVQWhIdE1ZbllNSWpxbFlDNUpSUWVmckcwMG9XdlY0?=
 =?utf-8?B?bUx3ckgwbDJJNnVKNW1xdE14cjhveXhEWTdVbmJtQmsrUk1EZXdOc09yNGNY?=
 =?utf-8?B?ejU3UFpYRkszVS85c3pjbHhsRDdHSHJWajFpODFmcmlSeDZQUFBKUWp4NUxs?=
 =?utf-8?B?VVNSWkxqUW5ialFXWE5mUlRKTGVId0wrSVFKZXcvSUFIUzhDRjVodGJlQ0FN?=
 =?utf-8?B?SWU1cG40eWZVNEhzbHNrTGNTcXU2WkNjN0JYTE5PZGZBa2lIb1VZaVdqcDZS?=
 =?utf-8?B?UnFLUjY0SHlIU2thZm9TekVuUEVQUjRRRlBKeVcyOHdxY3FuYmNDSTRWRjNX?=
 =?utf-8?B?RmpiUkxyTlJXT3JIVG13SSsyVW92blcwaXdvY1haQkpOR29VWUtvOE5XZ3lI?=
 =?utf-8?B?ajZxQ1VOUDl5TllPNkM3bkpWOG1hYmZFTS9LR0syL3hEUDhiR1NOUG5rVENr?=
 =?utf-8?B?Y0czcEFQYUxJNFFxNGFMeFpWWEVOamhNempOd29KTTQ1YWhWVlFiajJNY2gx?=
 =?utf-8?B?cUpxdG1BUVB4QkkvUEJoZHA5SHpITm42MUxvNnNoUzNCelIvTWF1RjlZY2FG?=
 =?utf-8?B?Szc5UUlRWE1GOEE4WEovZHJiaUNNK3FiRXBWQzBXeThQd1dFbHRYaGV5cXhs?=
 =?utf-8?B?bHNyT0x2cGV3WDFrVjRaZHNmbFc1UGNERFozVldVNTN2QU8zVHh4bCs2RlJ1?=
 =?utf-8?B?YVVXdDFKeXhJbFFnY0lmcG9uNjcxNlo3L3BJUHh6NFlzRnVSTjdRS2ZJT0ZN?=
 =?utf-8?B?Q1kvRnZxUlRBUmJrMDdMdlVMcEkxMzBsQ3U0L2pBUmhQdWNaTFJIV3orWDR6?=
 =?utf-8?B?QmU4TDlqbzJDei9qN3FnSWNBdW1wdWJsQ1RLVUxtV3o4UmxHWWp3b0NTVUk2?=
 =?utf-8?B?ZDNJMnpnNkVxNnMvNTVzalQ3ME9ZeTZNd1lHYTQxcE9kaWtYUzlRckFxUy9L?=
 =?utf-8?B?bzR0bVQ1clVjY01SMzQxZWkwQnlrOWJlYkpkUmJaRFNyVUdtd3BtOEFlRENh?=
 =?utf-8?B?S25hSGJOV0pPeDhpU0RqclFDTEY2MlkwSHhMUjkvZFV4UEU2MjFsUldZVnh3?=
 =?utf-8?B?dzJxYzlvemFwN3RuZVVycSs2WEE5Tm9xNjY2NmxnRjFyaUhHZ2x1ME0vbWxq?=
 =?utf-8?B?N2t5aHh2L0hkWjRSV2hBbU5BVzFqd0Y0ZnBRcGFXQVo4MTlBZWNrRGttbnpm?=
 =?utf-8?B?Qno5WG9XZG5jc0t5dGdTUnNRTCtOQmVNa1EwK3hCd2QwL1lyazV5NWNLdVpo?=
 =?utf-8?B?MjlKQWJETUtVYkRZWWVRUHptWWo4cnF1VHFlaXdDYlZSY2g0YTRVdnIrWGtL?=
 =?utf-8?B?ZVVXSXVmaEdTaFEvQmV4NjJLVFJmQVpJK2hUdHFVNnRXczdyaU1lVk5JY0VW?=
 =?utf-8?B?YkJHZHRjSmtQdy9IUWtscGRpSWlkakxtVjcvVEIvcHBscHhKcW52Zld1YUtF?=
 =?utf-8?B?bWpDbHlyejNHckEyT3Z6R1JnejNrdVJwWGsySHNrTlpqdldTWFRiOHgrSG5P?=
 =?utf-8?B?OTVkTUZ4UkN5RWpzQzUyWFFOZTAyVGlMekxUYkR1S2dSRWxXK2hrWjFYUHhn?=
 =?utf-8?B?N1UzKzVENW9WWmJGcHk2N0lqOEdRc0ZZeWpoMmx4aFp1WjI1NzlEZmZKVVJC?=
 =?utf-8?B?Smh6djNBL05OV295NGZYSndOWElENXdkcm1qMTBaRXQwVFBaMC9GM01sWUVF?=
 =?utf-8?Q?k3x7x4mkEqAUxjKvvWRTiNY=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c1beb10b-f43c-443c-9532-08db108fc3b8
X-MS-Exchange-CrossTenant-AuthSource: SN4PR01MB7455.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2023 02:36:25.7141
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ks9towLAHmRup8un/SAp4oSlK3W+CxbxGDORov4+R6MRBTS+jlbAzYZfmnjisCliCswhHKKM5m9lp5uoYaKuvRp9Z5cZfIxlNlRSsyc6428=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR01MB2418
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 16/02/2023 19:30, Greg Kroah-Hartman wrote:
> On Thu, Feb 16, 2023 at 10:22:14AM +0700, Quan Nguyen wrote:
>>
>>
>> On 15/02/2023 14:33, Paul Menzel wrote:
>>> Dear Quan,
>>>
>>>
>>> Thank you for your patch.
>>>
>>
>> Thanks Paul for the review.
>>
>>> Am 14.02.23 um 07:45 schrieb Quan Nguyen:
>>>> Adds event_dimm[0-15]_syndrome sysfs to report the failure syndrome
>>>> to BMC when DIMM training failed.
>>>
>>> Where you able to verify that it works? Out of curiosity, how?
>>>
>>
>> Yes, we verified it by injecting DIMM errors and confirm that errors was
>> reported correctly via sysfs.
>> For about how to do error injection, we may  need to refer to section 3.2
>> Memory Error Group in Altra Family RAS Error Injection User Manual. It is
>> shared in our Ampere Customer Connect [1]. The latest version is
>> v1.00_20220329.
>>
>> [1] https://connect.amperecomputing.com
>>
>>>> Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>
>>>> ---
>>>>    .../sysfs-bus-platform-devices-ampere-smpro   | 10 +++
>>>>    drivers/misc/smpro-errmon.c                   | 77 +++++++++++++++++++
>>>>    2 files changed, 87 insertions(+)
>>>>
>>>> diff --git
>>>> a/Documentation/ABI/testing/sysfs-bus-platform-devices-ampere-smpro
>>>> b/Documentation/ABI/testing/sysfs-bus-platform-devices-ampere-smpro
>>>> index d4e3f308c451..c35f1d45e656 100644
>>>> --- a/Documentation/ABI/testing/sysfs-bus-platform-devices-ampere-smpro
>>>> +++ b/Documentation/ABI/testing/sysfs-bus-platform-devices-ampere-smpro
>>>> @@ -265,6 +265,16 @@ Description:
>>>>            For more details, see section `5.7 GPI Status Registers
>>>> and 5.9 Memory Error Register Definitions,
>>>>            Altra Family Soc BMC Interface Specification`.
>>>> +What:
>>>> /sys/bus/platform/devices/smpro-errmon.*/event_dimm[0-15]_syndrome
>>>> +KernelVersion:    6.1
>>>
>>> Should it be 6.2, as it probably won’t make it into 6.1?
>>>
>>
>> Thanks for the catch. Will fix in next version.
> 
> Should be 6.3, it's missed the 6.2 merge window cycle, sorry.
> 
> thanks,
> 

Thanks Greg,
Will update to 6.3