MIME-Version: 1.0
References: <20230214134127.59273-1-angelogioacchino.delregno@collabora.com> <20230214134127.59273-35-angelogioacchino.delregno@collabora.com>
In-Reply-To: <20230214134127.59273-35-angelogioacchino.delregno@collabora.com>
From:   Chen-Yu Tsai <wenst@chromium.org>
Date:   Fri, 17 Feb 2023 12:19:44 +0800
Message-ID: <CAGXv+5E3KCRyaRpkYab0XmT8XDZQO21RYBpKVgCcGtWmZ+dv3g@mail.gmail.com>
Subject: Re: [PATCH v2 34/47] clk: mediatek: Switch to module_platform_driver()
 where possible
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>
Cc:     mturquette@baylibre.com, sboyd@kernel.org, matthias.bgg@gmail.com,
        johnson.wang@mediatek.com, miles.chen@mediatek.com,
        chun-jie.chen@mediatek.com, daniel@makrotopia.org,
        fparent@baylibre.com, msp@baylibre.com, nfraprado@collabora.com,
        rex-bc.chen@mediatek.com, zhaojh329@gmail.com,
        sam.shih@mediatek.com, edward-jw.yang@mediatek.com,
        yangyingliang@huawei.com, granquet@baylibre.com,
        pablo.sun@mediatek.com, sean.wang@mediatek.com,
        chen.zhong@mediatek.com, linux-kernel@vger.kernel.org,
        linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, kernel@collabora.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Feb 14, 2023 at 9:42 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> wrote:
>
> Lots of clock drivers have got both .probe() and a .remove() callbacks:
> switch from builtin_platform_driver() to module_platform_driver() so
> that we actually register the .remove() callback.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
>  drivers/clk/mediatek/clk-mt2701-aud.c          | 3 +--
>  drivers/clk/mediatek/clk-mt2701-bdp.c          | 3 +--
>  drivers/clk/mediatek/clk-mt2701-eth.c          | 3 +--
>  drivers/clk/mediatek/clk-mt2701-g3d.c          | 3 +--
>  drivers/clk/mediatek/clk-mt2701-hif.c          | 3 +--
>  drivers/clk/mediatek/clk-mt2701-img.c          | 3 +--
>  drivers/clk/mediatek/clk-mt2701-mm.c           | 3 +--
>  drivers/clk/mediatek/clk-mt2701-vdec.c         | 3 +--
>  drivers/clk/mediatek/clk-mt2712-bdp.c          | 3 +--
>  drivers/clk/mediatek/clk-mt2712-img.c          | 3 +--
>  drivers/clk/mediatek/clk-mt2712-jpgdec.c       | 3 +--
>  drivers/clk/mediatek/clk-mt2712-mfg.c          | 3 +--
>  drivers/clk/mediatek/clk-mt2712-mm.c           | 3 +--
>  drivers/clk/mediatek/clk-mt2712-vdec.c         | 3 +--
>  drivers/clk/mediatek/clk-mt2712-venc.c         | 3 +--
>  drivers/clk/mediatek/clk-mt6765-audio.c        | 3 +--
>  drivers/clk/mediatek/clk-mt6765-cam.c          | 3 +--
>  drivers/clk/mediatek/clk-mt6765-img.c          | 3 +--
>  drivers/clk/mediatek/clk-mt6765-mipi0a.c       | 3 +--
>  drivers/clk/mediatek/clk-mt6765-mm.c           | 3 +--
>  drivers/clk/mediatek/clk-mt6765-vcodec.c       | 3 +--
>  drivers/clk/mediatek/clk-mt6797-img.c          | 3 +--
>  drivers/clk/mediatek/clk-mt6797-mm.c           | 3 +--
>  drivers/clk/mediatek/clk-mt6797-vdec.c         | 3 +--
>  drivers/clk/mediatek/clk-mt6797-venc.c         | 3 +--
>  drivers/clk/mediatek/clk-mt7622-aud.c          | 3 +--
>  drivers/clk/mediatek/clk-mt7622-eth.c          | 3 +--
>  drivers/clk/mediatek/clk-mt7622-hif.c          | 3 +--
>  drivers/clk/mediatek/clk-mt7629-eth.c          | 1 -

This one looks fishy. It wasn't converted to the simple probe library.

Otherwise,

Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>