Message-ID: <767e4d8d-b691-1849-71ac-5d6cefbb8d6a@linaro.org>
Date:   Fri, 17 Feb 2023 09:07:43 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.0.2
Subject: Re: [PATCH v7 1/1] dma: qcom: bam_dma: Add support to initialize
 interconnect path
Content-Language: en-US
To:     Bhupesh Sharma <bhupesh.sharma@linaro.org>
Cc:     dmaengine@vger.kernel.org, agross@kernel.org,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, thara.gopinath@gmail.com,
        devicetree@vger.kernel.org, andersson@kernel.org,
        bhupesh.linux@gmail.com, vkoul@kernel.org,
        Rob Herring <robh@kernel.org>
References: <20220921030649.1436434-1-bhupesh.sharma@linaro.org>
 <20220921030649.1436434-2-bhupesh.sharma@linaro.org>
 <a5b6255c-7282-32ed-8031-a4b841a78db7@linaro.org>
 <CAH=2Ntw6XcyB2zy-cs35z3eOf8iTa28hGerhLndOgARrG05gJw@mail.gmail.com>
From:   Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
In-Reply-To: <CAH=2Ntw6XcyB2zy-cs35z3eOf8iTa28hGerhLndOgARrG05gJw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/17/23 06:00, Bhupesh Sharma wrote:
> On Thu, 16 Feb 2023 at 19:49, Vladimir Zapolskiy
> <vladimir.zapolskiy@linaro.org> wrote:
>>
>> On 9/21/22 06:06, Bhupesh Sharma wrote:
>>> From: Thara Gopinath <thara.gopinath@gmail.com>
>>>
>>> BAM dma engine associated with certain hardware blocks could require
>>> relevant interconnect pieces be initialized prior to the dma engine
>>> initialization. For e.g. crypto bam dma engine on sm8250. Such requirement
>>
>> Apparently it's proven that the change description is incorrect, Qualcomm
>> crypto engine is working fine on SM8250 and even more recent platforms,
>> so far there is no obvious necessity in this change.
> 
> Since your v9 patchset produces no entry in $ cat /proc/crypto on
> either RB5 (qrb5165) or (with an additional patch) on sm8150-mtp or
> sa8115p-adp with the default arm64 defconfig with linux-next, I am not
> sure we can conclude QCE is working with these changes.

Hopefully someone else can conclude it independently.

You may notice that v9 patchset series does not contain sm8150 specific
changes, but sm8250 one (v9 11/14) is present, testing on RB5 is valid.

> Please share more details on how you tested this.

I do compile linux-next with v9 QCE series applied on top of it and run the
kernel on RB5 board, there is nothing really complicated about it.

If you missed it, the 'cryptobench benchmark' test etc. have been already
described, please find it here:

   https://lore.kernel.org/linux-crypto/731af3cf-6f18-caf9-ef65-ec73b0744ad9@linaro.org/

--
Best wishes,
Vladimir

>>> is passed on to the bam dma driver from dt via the "interconnects"
>>> property. Add support in bam_dma driver to check whether the interconnect
>>> path is accessible/enabled prior to attempting driver intializations.
>>>
>>> If interconnects are not yet setup, defer the BAM DMA driver probe().
>>>
>>> Cc: Bjorn Andersson <andersson@kernel.org>
>>> Cc: Rob Herring <robh@kernel.org>
>>> Signed-off-by: Thara Gopinath <thara.gopinath@gmail.com>
>>> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
>>> [Bhupesh: Make header file inclusion alphabetical and use 'devm_of_icc_get()']
>>> ---
>>>    drivers/dma/qcom/bam_dma.c | 10 ++++++++++
>>>    1 file changed, 10 insertions(+)
>>>
>>> diff --git a/drivers/dma/qcom/bam_dma.c b/drivers/dma/qcom/bam_dma.c
>>> index 2ff787df513e..a5b0cf28ffb7 100644
>>> --- a/drivers/dma/qcom/bam_dma.c
>>> +++ b/drivers/dma/qcom/bam_dma.c
>>> @@ -26,6 +26,7 @@
>>>    #include <linux/kernel.h>
>>>    #include <linux/io.h>
>>>    #include <linux/init.h>
>>> +#include <linux/interconnect.h>
>>>    #include <linux/slab.h>
>>>    #include <linux/module.h>
>>>    #include <linux/interrupt.h>
>>> @@ -394,6 +395,7 @@ struct bam_device {
>>>        const struct reg_offset_data *layout;
>>>
>>>        struct clk *bamclk;
>>> +     struct icc_path *mem_path;
>>>        int irq;
>>>
>>>        /* dma start transaction tasklet */
>>> @@ -1294,6 +1296,14 @@ static int bam_dma_probe(struct platform_device *pdev)
>>>        if (IS_ERR(bdev->bamclk))
>>>                return PTR_ERR(bdev->bamclk);
>>>
>>> +     /* Ensure that interconnects are initialized */
>>> +     bdev->mem_path = devm_of_icc_get(bdev->dev, "memory");
>>> +     if (IS_ERR(bdev->mem_path)) {
>>> +             ret = dev_err_probe(bdev->dev, PTR_ERR(bdev->mem_path),
>>> +                                 "failed to acquire icc path\n");
>>> +             return ret;
>>> +     }
>>> +
>>>        ret = clk_prepare_enable(bdev->bamclk);
>>>        if (ret) {
>>>                dev_err(bdev->dev, "failed to prepare/enable clock\n");
>>
>> I'm resurrecting the comments on this change to emphasize the observation
>> that the change is not needed at all to run QCE.
>>
>> --
>> Best wishes,
>> Vladimir