From:   "Wu, Wentong" <wentong.wu@intel.com>
To:     Hillf Danton <hdanton@sina.com>
CC:     "mchehab@kernel.org" <mchehab@kernel.org>,
        "sakari.ailus@linux.intel.com" <sakari.ailus@linux.intel.com>,
        "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
        "Pandruvada, Srinivas" <srinivas.pandruvada@intel.com>,
        "pierre-louis.bossart@linux.intel.com" 
        <pierre-louis.bossart@linux.intel.com>,
        "Wang, Zhifeng" <zhifeng.wang@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 1/3] media: pci: intel: ivsc: Add CSI submodule
Thread-Topic: [PATCH v2 1/3] media: pci: intel: ivsc: Add CSI submodule
Thread-Index: AQHZP1HqpZLwLlRt00ml9e7fRXtKOq7MO6AAgAG4EjCAACxFgIAAM1HwgADNUYCAA4fWgIAACvWAgAANv1A=
Date:   Fri, 17 Feb 2023 07:37:31 +0000
Message-ID: <DM6PR11MB4316365C6A210BC728B5C4948DA19@DM6PR11MB4316.namprd11.prod.outlook.com>
References: <20230213022347.2480307-1-wentong.wu@intel.com>
 <20230213034202.2926-1-hdanton@sina.com>
 <20230214083533.3410-1-hdanton@sina.com>
 <20230214235405.3587-1-hdanton@sina.com>
 <20230217062815.1682-1-hdanton@sina.com>
In-Reply-To: <20230217062815.1682-1-hdanton@sina.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?db8dEevQqCp+wqlrOJ+eO0cmCwo2LrTl2+1xioo5xhuveAsrgLiC1Z45EH+T?=
 =?us-ascii?Q?LCRC2enntn4nwikkaVIuOal2ilytdt8h1fxAlofCuVc6FY75Dm35MKqDJrkr?=
 =?us-ascii?Q?Y3psZPE4PhBOztFlPjltwc67QmmCJQNIWHfKU0wSC2AQL0wBUidm1mdo2h3F?=
 =?us-ascii?Q?4ZQR90Zka4lWsGBMSYBe1xFEcyNsQb0Uw686KFIO8sxZzQTYsIXNmo1Q0oTj?=
 =?us-ascii?Q?HwKrnD6xvpfhmlmm3PsQRr08hymdo5eTVupfTEay4qAcazi2Wlj9wPv+qo42?=
 =?us-ascii?Q?KRxSnOA1Tok248TBogcEcfmD1gu/Ral3Fd96dRmm0/9okp4YLT/iMCdz3gXK?=
 =?us-ascii?Q?H/LKIGdtm5FjSJZvWbp+zWaP/C3V2DAafEJysiQoSrAdMoFyZUzoG7t18hTh?=
 =?us-ascii?Q?sLVg9R49fPncNdPMS2bTfAtCzdC5nFLG3f7meKBkiczJycgmTythhZDy1J3z?=
 =?us-ascii?Q?9vv0BFoNWYVxvlL4YDgRHwwoQbQvDZyRQlIJi/UGPJD5dznR+eNajfFg7fEZ?=
 =?us-ascii?Q?zujuWAs05HmJ8mAhqEkIlJ5C+SbzqTHwxcKWDmsItwaGTfGlC3pNwiPAgBwQ?=
 =?us-ascii?Q?pOXoyfm2HVdq4uiFK/1n9jYpVWM5J+mwrtAjwoDUQyDJ+pB+OpCffPNeZYe4?=
 =?us-ascii?Q?4W2hAv8VjdEc2k3RNLsP/82eOdNE/lBn+qR/ppKFRTxGnfq2RyC8NIHBgfEE?=
 =?us-ascii?Q?VblnoXZLmlhuhu2x2hnRcnlKBSPBsPne5Eucp+23k4BdoPP3kEzDqzTrxnUp?=
 =?us-ascii?Q?fSDHGFfo9gRFWq7dcgkBPYuIxwvfFPWEi3xxGuh4t45J1c4soQPrXnc1OuS2?=
 =?us-ascii?Q?LPOPgx17kSMEo9EWVVgl1fYPcuF7Pf2QctjW0TsAfiuNWj+ZumefQPNK3Qif?=
 =?us-ascii?Q?ouMvLe6k5YQQnffX9LAk1o/MN5IvCWNlZzC9nWVPYn9aN6qdo295xlN7hfIO?=
 =?us-ascii?Q?rjy/ukpS34Geu/856UyRyRhTFjTyJeULLfibTe6w9MKFJT8r1hjN4FnNZKm6?=
 =?us-ascii?Q?uzKWG4N0tPTsSjvSnrbqiZlJwmqEV4NkKAI421NmFuyEK5iC8jL+W7yl4TxT?=
 =?us-ascii?Q?XWyuov2x5UsiXkhGcHwnGJHPbJxYYEZlGT+EzSWqglsZLTETsnm65iNPTBq6?=
 =?us-ascii?Q?VHT5+IY1Rha9MlVxPnzKzX8NQ9nGQd8TySojugLEy58A2LB4ug6i+EJQZujT?=
 =?us-ascii?Q?XeMcVcB7NSeRBXi5TJBeu9Dlo4mUHVYKl1P2JBgN8ctztBdIL4Ja0F8+pJqo?=
 =?us-ascii?Q?qlM2s8lN4gawyTWjbpjGImFc2OHfafLX1SpCJ9hNn0d+hNr0Swa5o1FaMCKb?=
 =?us-ascii?Q?CJkzYfkfdqZXHsMf48hV465LzPdU8o2Mhc09sJyVY1tHA46t9jNv9repfCIO?=
 =?us-ascii?Q?LAg0xRypYUXhiH2L6Szoru1rsH0C3ZX5sctK7U8Cu+Sb0/ibffg8VOFGX4kk?=
 =?us-ascii?Q?7a2P8oZZOzNiXyVarSkSGCUjJWbCDrnGhYyxhzsUpU6U/qtDKDa7zNfFxZYk?=
 =?us-ascii?Q?3nK97RhPaO/637o0SFeavqUvDFgLJhMA71NmtsRBLAn1Zfosr6Q5ItntX6ac?=
 =?us-ascii?Q?fJ+JKphRrd8JuJIXSN7vfx67S4zofIDwrnG3acpV?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4316.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e4ba3b5-8695-4d83-dbcf-08db10b9d3e3
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Feb 2023 07:37:31.2820
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Xx9dydLNLn1fIN4/CoiLjvwTfDwfbTKy22ESYoty+sB9QFq9IypqGQjmUf1bzEAasJFFRX95WqRp3AUlWUa5pw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7246
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Hillf Danton <hdanton@sina.com>
> Sent: Friday, February 17, 2023 2:28 PM
>=20
> On Fri, 17 Feb 2023 05:52:38 +0000 Wentong Wu <wentong.wu@intel.com>
> >
> > Thanks, but what do you mean "emulated"?=3D20
> >
> Construct a scenario that ensures wakeup comes late because of no wait fo=
r
> completion. And we can see what will happen with the current test cases.

Thanks, I will remove reinit_completion

>=20
> > static int mei_csi_send(u8 *buf, size_t len)
> > +{
> > +	struct csi_cmd *cmd =3D (struct csi_cmd *)buf;
> > +	int ret;
> > +
> > +	reinit_completion(&csi->cmd_completion);
> > +
> > +	ret =3D mei_cldev_send(csi->cldev, buf, len);
> > +	if (ret < 0)
> > +		goto out;
>=20
> 	return  -ETIMEDOUT;
>=20
> > +
> > +	ret =3D wait_for_completion_killable_timeout(&csi->cmd_completion,
> > +						   CSI_CMD_TIMEOUT);
> > +	if (ret < 0) {
> > +		goto out;
> > +	} else if (!ret) {
> > +		ret =3D -ETIMEDOUT;
> > +		goto out;
> > +	}
> > +
> > +	/* command response status */
> > +	ret =3D csi->cmd_response.status;
> > +	if (ret) {
> > +		ret =3D -EINVAL;
> > +		goto out;
> > +	}
> > +
> > +	if (csi->cmd_response.cmd_id !=3D cmd->cmd_id)
> > +		ret =3D -EINVAL;
> > +
> > +out:
> > +	return ret;
> > +}