Subject: Re: [PATCH v5 4/5] LoongArch: Add support for kernel relocation
To:     Xi Ruoyao <xry111@xry111.site>
References: <1676618789-20485-1-git-send-email-tangyouling@loongson.cn>
 <1676618789-20485-5-git-send-email-tangyouling@loongson.cn>
 <5ac82f53aeb6a040be90eac2be7c64055e62f0ef.camel@xry111.site>
Cc:     Huacai Chen <chenhuacai@kernel.org>,
        Jinyang He <hejinyang@loongson.cn>,
        Xuerui Wang <kernel@xen0n.name>, loongarch@lists.linux.dev,
        linux-kernel@vger.kernel.org
From:   Youling Tang <tangyouling@loongson.cn>
Message-ID: <fc5b0403-ed2f-2dcf-11b9-e3be4642ddda@loongson.cn>
Date:   Fri, 17 Feb 2023 16:13:42 +0800
User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <5ac82f53aeb6a040be90eac2be7c64055e62f0ef.camel@xry111.site>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 02/17/2023 04:02 PM, Xi Ruoyao wrote:
> On Fri, 2023-02-17 at 15:26 +0800, Youling Tang wrote:
>
>> This config allows to compile kernel as PIE and to relocate it at
>> any virtual address at runtime: this paves the way to KASLR.
>> Runtime relocation is possible since relocation metadata are embedded
>> into the kernel.
>>
>> Signed-off-by: Youling Tang <tangyouling@loongson.cn>
>> Signed-off-by: Xi Ruoyao <xry111@xry111.site> # Use arch_initcall
>> Signed-off-by: Jinyang He <hejinyang@loongson.cn> # Provide la_abs idea
>
> Use Suggested-by if only "idea" is provided.
In addition to the idea, the first draft code of la_abs is also
provided.

Maybe change it to the following,
   Signed-off-by: Jinyang He <hejinyang@loongson.cn> # Provide la_abs 
relocation draft code

>
>> +struct rela_la_abs {
>> +               long offset;
>> +               long symvalue;
>> +};
>
> Use one tab instead of two for the indent.
My mistake.

Also the missing do_kaslr declaration will be added.

Youling.
> Otherwise LGTM.
>