Date:   Fri, 17 Feb 2023 09:14:52 +0100
From:   Daniel Vetter <daniel@ffwll.ch>
To:     Sam Ravnborg <sam@ravnborg.org>
Cc:     Daniel Vetter <daniel@ffwll.ch>, neil.armstrong@linaro.org,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        linux-arm-msm@vger.kernel.org, andersson@kernel.org,
        agross@kernel.org, krzysztof.kozlowski@linaro.org,
        marijn.suijten@somainline.org,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        David Airlie <airlied@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] gpu/drm/panel: Add Sony TD4353 JDI panel driver
Message-ID: <Y+83fOHFK2qPXP1S@phenom.ffwll.local>
Mail-Followup-To: Sam Ravnborg <sam@ravnborg.org>,
        neil.armstrong@linaro.org, Konrad Dybcio <konrad.dybcio@linaro.org>,
        linux-arm-msm@vger.kernel.org, andersson@kernel.org,
        agross@kernel.org, krzysztof.kozlowski@linaro.org,
        marijn.suijten@somainline.org,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        David Airlie <airlied@gmail.com>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230119163201.580858-1-konrad.dybcio@linaro.org>
 <20230119163201.580858-2-konrad.dybcio@linaro.org>
 <725a5727-fdde-e3ae-a448-2679c5c4c7f4@linaro.org>
 <CAKMK7uFpc3Kg=Ym6ee_JTZo-0h2ig7Twtf2uwE7oV-1c6YRP=Q@mail.gmail.com>
 <8ab061aa-a2fa-3070-a756-5682eb40a425@linaro.org>
 <CAKMK7uHd7Lefc+ZjvuHtrttkQFYDF8XSsKUV2gfGs9=cw1GTKw@mail.gmail.com>
 <Y+6UHxHaiF6Aw4du@ravnborg.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y+6UHxHaiF6Aw4du@ravnborg.org>
Precedence: bulk

On Thu, Feb 16, 2023 at 09:37:51PM +0100, Sam Ravnborg wrote:
> On Thu, Feb 16, 2023 at 01:49:23PM +0100, Daniel Vetter wrote:
> > On Thu, 16 Feb 2023 at 13:47, Neil Armstrong <neil.armstrong@linaro.org> wrote:
> > >
> > > On 16/02/2023 13:32, Daniel Vetter wrote:
> > > > On Thu, 16 Feb 2023 at 12:59, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
> > > >>
> > > >>
> > > >>
> > > >> On 19.01.2023 17:32, Konrad Dybcio wrote:
> > > >>> From: Konrad Dybcio <konrad.dybcio@somainline.org>
> > > >>>
> > > >>> Add support for the Sony TD4353 JDI 2160x1080 display panel used in
> > > >>> some Sony Xperia XZ2 and XZ2 Compact smartphones. Due to the specifics
> > > >>> of smartphone manufacturing, it is impossible to retrieve a better name
> > > >>> for this panel.
> > > >>>
> > > >>> This revision adds support for the default 60 Hz configuration, however
> > > >>> there could possibly be some room for expansion, as the display panels
> > > >>> used on Sony devices have historically been capable of >2x refresh rate
> > > >>> overclocking.
> > > >>>
> > > >>> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> > > >>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> > > >>> Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org>
> > > >>> ---
> > > >> Are there any outstanding issues with this driver, or perhaps I did
> > > >> not CC some important list? It has gotten very little activity ever
> > > >> since its initial submission around Sept'22..
> > > >
> > > > Sam is usually picking up panel drivers these days, but maybe we need
> > > > a bit more help in this area? If anyone from linaro has a handful of
> > > > drm patches landed in upstream they could apply for drm-misc commit
> > > > rights and help push these. I think linaro has lost a few of the
> > > > drm-misc committers so things tend to be stuck a bit more :-/
> > >
> > > I usually wait for Sam to comment before applying my panel patches drivers to drm-misc-next,
> > > but yeah panels would need some more help...
> > >
> > > If needed I can add myself to the panel drivers maintainance aswell.
> > 
> > I think that would be great, maybe just send out the MAINTAINERS patch
> > and ask Sam to ack?
> 
> That would be great, and I am more than happy to ack it.
> According to MAINTAINERS Thierry is the panel maintainer and I am reviewer.
> So you should ask Thierry to ack it too.

Tbh with the commit right model the difference between reviewer/maintainer
is kinda not there, and I think Thierry's entry simply goes back to the
time drm-panel was still a separate git tree. But yeah more acks doesn't
hurt.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch