From:   Veerasenareddy Burru <vburru@marvell.com>
To:     Maciej Fijalkowski <maciej.fijalkowski@intel.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Abhijit Ayarekar <aayarekar@marvell.com>,
        Sathesh B Edara <sedara@marvell.com>,
        Satananda Burla <sburla@marvell.com>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
Subject: RE: [EXT] Re: [PATCH net-next v3 1/7] octeon_ep: defer probe if
 firmware not ready
Thread-Topic: [EXT] Re: [PATCH net-next v3 1/7] octeon_ep: defer probe if
 firmware not ready
Thread-Index: AQHZQDM4vC2nRdjWY0CmFFUwRXoMBq7OtByAgAQcW6A=
Date:   Fri, 17 Feb 2023 08:21:11 +0000
Message-ID: <BYAPR18MB24237CF1F92E27DB6C127BF0CCA19@BYAPR18MB2423.namprd18.prod.outlook.com>
References: <20230214051422.13705-1-vburru@marvell.com>
 <20230214051422.13705-2-vburru@marvell.com> <Y+vFlfakHj33DEkt@boxer>
In-Reply-To: <Y+vFlfakHj33DEkt@boxer>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NhsT2tx9nhUb4C8OR5sujmrldkprqEQxmIzDjiU9KCfbFRlzSPRr66EAM1Ts?=
 =?us-ascii?Q?shGeBDetiemm2oYJAo/w3nvGQKzAgQnjEtAbcAI+85rkyvBab9jC1QvAh9De?=
 =?us-ascii?Q?ADlRJrBaNzJ0R3bmPWx0xJM+awHYHHU4ELVQ3XmbAhiuQEq/WFcFip3+pnwj?=
 =?us-ascii?Q?alFKvozpsffo7jiZfdlwsYmecIQVGshbHMWEF5fbJuFRkVCWGZO40wH0ujzR?=
 =?us-ascii?Q?LKLNYIDkfpknZMNboRbzhkSzYAV5wyhRYHIgo3CgFrbegubvJA9+1xU6UGsz?=
 =?us-ascii?Q?vFI7cojjgSO4/JTkHAIHcI7DU3oA9+Xr853J7O/UCQRGQdO1/gYmGlzBA/9C?=
 =?us-ascii?Q?Zx2UEKRBMUS0+8WvCwsrJmuVty8dKtEEkiEq/JntSeHl2pwtVGOYwd70zmP6?=
 =?us-ascii?Q?iI52z4q5KoZiBRx1ZyqWrpq9tbJLZ9GnhkrewrpE7JMGwifLByFTmdQuKRhi?=
 =?us-ascii?Q?aLH7uukOaR5zlq/r4V/s2Whm39cebYe6YPvOwHiehiWs9fhjjPEu3RHVod74?=
 =?us-ascii?Q?2ClXzqI+FXzopHAM2Dt11YOE4VAEE7tUfQ3C0FnsD/F+J3pSTyFexHt/X045?=
 =?us-ascii?Q?goL6xe4ulFVyJUrPYyy9PsSnaltyKQkiYvf7QiGSf35ZSE0I0is/h4W/71Le?=
 =?us-ascii?Q?sGCe5xj1F8BRGjoF0JFcOSLT9n2O2CsSIdOYcKIC9ZNPkYRyadBcUungc7JQ?=
 =?us-ascii?Q?QwvCGxgqVSRLxYIeBt1FzF6v9zSkAcJJLLbB8JcWm3MWEoCHlBU9mGQ4o+ZO?=
 =?us-ascii?Q?36HrjopLYYpixZNwz89MLOP0qyFvA5gaPqyVDC9OoEDZo6ge0sjVWZ3Q+40p?=
 =?us-ascii?Q?hv5nhr4YZ0g7A+tM8aykbvS6eGGieqRaUVduYpEkGMN8+3OueVzOfnQKYbW5?=
 =?us-ascii?Q?GJ5+qAO0Nb21M3VGArDKooUtWg8hTz7iU+IWzWyqyRSTGh+GLha9iw76Bm0R?=
 =?us-ascii?Q?MpIrDEkjA/pBDYxeongO01LJqtLbZg+Gp2/NN9PXaA9l6w3wMKgPk67LTNoK?=
 =?us-ascii?Q?aVfr5vTB6TdmOorw3Zq6qqLefvkt/I0M30KjWu5o5cPvAnjLeXu3vZni1j6R?=
 =?us-ascii?Q?zIHrJA6/yBR5OKDo6m4RS8aSB9Jg/BLS1Jri1Ke4hHBbr6nCfRGuJeZbp1Eh?=
 =?us-ascii?Q?F/fKu5pFRfbmFtReETv9rfv9S5iX6stqrdnHvKJ3YST/6hgvs6WXPORxq7Ub?=
 =?us-ascii?Q?eSRx1znduHqg+OCjvH02PNmB6OCR9Pp5IIHBrDsVoWXl99zj61NM0MyxFB6D?=
 =?us-ascii?Q?olabvcjdLmbc94bwGdlq3rlOCULkEOVyKyc+d8Sn5DIv1YDTcXkcb9jN4gjK?=
 =?us-ascii?Q?q/z7/Csi5W0REpQiEiy0GvcIlvZQQ/sQRAtfdr3ylAb4MfsbkgrGkh8r55Z0?=
 =?us-ascii?Q?uSttofKPh5q/+EegmWVNXavieQ6z8i5wWQIHeVgYXF07BN/9cQ6VSnvI/H2u?=
 =?us-ascii?Q?L4pWQtIOhdYGcSkYzcMgRNVyHKp4aOEuZEyzedWg0EGGed7TaPlaECuE/XXA?=
 =?us-ascii?Q?wxa5NCcGqzhrsM00WkP6gQ5ew0pbXJwR1JyZqLs+ayD0hDIr10E1UIMHTt2Q?=
 =?us-ascii?Q?gsINn4M55ZDOGu7DoTo+9kDyy/V/pGekYBCCn3kP?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR18MB2423.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3c4e2b06-28a6-4edc-e528-08db10bfedd2
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Feb 2023 08:21:11.7407
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bN3kGQEP27pYI07o7R/KNstN9Uf5QhiNooD0U+2VKsa++wk9weGR4Okp+EEw7clnh1tZZvOxVEd4uIONYSTp7g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR18MB3596
X-Proofpoint-ORIG-GUID: ymgRQRV7VyzQiF9Rx64JjPUN9XNkrU_R
X-Proofpoint-GUID: ymgRQRV7VyzQiF9Rx64JjPUN9XNkrU_R
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22
 definitions=2023-02-17_04,2023-02-16_01,2023-02-09_01
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> Sent: Tuesday, February 14, 2023 9:32 AM
> To: Veerasenareddy Burru <vburru@marvell.com>
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Abhijit Ayareka=
r
> <aayarekar@marvell.com>; Sathesh B Edara <sedara@marvell.com>;
> Satananda Burla <sburla@marvell.com>; linux-doc@vger.kernel.org; David S.
> Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>;
> Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>
> Subject: [EXT] Re: [PATCH net-next v3 1/7] octeon_ep: defer probe if
> firmware not ready
>=20
> External Email
>=20
> ----------------------------------------------------------------------
> On Mon, Feb 13, 2023 at 09:14:16PM -0800, Veerasenareddy Burru wrote:
> > Defer probe if firmware is not ready for device usage.
> >
> > Signed-off-by: Veerasenareddy Burru <vburru@marvell.com>
> > Signed-off-by: Abhijit Ayarekar <aayarekar@marvell.com>
> > Signed-off-by: Satananda Burla <sburla@marvell.com>
> > ---
> > v2 -> v3:
> >  * fix review comments
> >    https://urldefense.proofpoint.com/v2/url?u=3Dhttps-
> 3A__lore.kernel.org_all_Y4chWyR6qTlptkTE-
> 40unreal_&d=3DDwIBAg&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DXkP_75lnbPIeeucsP
> X36ZgjiMqEKttwZfwNyWMCLjT0&m=3D4b7d0RrdHBeSeuVxcgazZ-
> kuSb9u5rGArB5Mio0glbruzVrVD25vZP2M2f1jPteh&s=3DJhMZ44LA1ICu-
> gf3_8cI2F_pN7OFsWMNHp2Od7u26Gk&e=3D
> >    - change get_fw_ready_status() to return bool
> >    - fix the success oriented flow while looking for
> >      PCI extended capability
> >
> > v1 -> v2:
> >  * was scheduling workqueue task to wait for firmware ready,
> >    to probe/initialize the device.
> >  * now, removed the workqueue task; the probe returns EPROBE_DEFER,
> >    if firmware is not ready.
> >  * removed device status oct->status, as it is not required with the
> >    modified implementation.
> >
> >  .../ethernet/marvell/octeon_ep/octep_main.c   | 26
> +++++++++++++++++++
> >  1 file changed, 26 insertions(+)
> >
> > diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
> > b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
> > index 5a898fb88e37..5620df4c6d55 100644
> > --- a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
> > +++ b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
> > @@ -1017,6 +1017,26 @@ static void octep_device_cleanup(struct
> octep_device *oct)
> >  	oct->conf =3D NULL;
> >  }
> >
> > +static bool get_fw_ready_status(struct pci_dev *pdev) {
> > +	u32 pos =3D 0;
> > +	u16 vsec_id;
> > +	u8 status;
> > +
> > +	while ((pos =3D pci_find_next_ext_capability(pdev, pos,
> > +						   PCI_EXT_CAP_ID_VNDR))) {
> > +		pci_read_config_word(pdev, pos + 4, &vsec_id); #define
> > +FW_STATUS_VSEC_ID  0xA3
> > +		if (vsec_id !=3D FW_STATUS_VSEC_ID)
> > +			continue;
> > +
> > +		pci_read_config_byte(pdev, (pos + 8), &status);
> > +		dev_info(&pdev->dev, "Firmware ready status =3D %u\n",
> status);
> > +		return status ? true : false;
>=20
> nit:
>=20
> return !!status;
>=20
> ?
>=20

Thank you for the feedback. Will update in next revision.

> > +	}
> > +	return false;
> > +}
> > +
> >  /**
> >   * octep_probe() - Octeon PCI device probe handler.
> >   *
> > @@ -1053,6 +1073,12 @@ static int octep_probe(struct pci_dev *pdev,
> const struct pci_device_id *ent)
> >  	pci_enable_pcie_error_reporting(pdev);
> >  	pci_set_master(pdev);
> >
> > +	if (!get_fw_ready_status(pdev)) {
> > +		dev_notice(&pdev->dev, "Firmware not ready; defer
> probe.\n");
> > +		err =3D -EPROBE_DEFER;
> > +		goto err_alloc_netdev;
> > +	}
> > +
> >  	netdev =3D alloc_etherdev_mq(sizeof(struct octep_device),
> >  				   OCTEP_MAX_QUEUES);
> >  	if (!netdev) {
> > --
> > 2.36.0
> >