Subject: Re: [PATCH v4 5/5] LoongArch: Add support for kernel address space
 layout randomization (KASLR)
To:     Xi Ruoyao <xry111@xry111.site>
References: <1676018856-26520-1-git-send-email-tangyouling@loongson.cn>
 <1676018856-26520-6-git-send-email-tangyouling@loongson.cn>
 <41b6c7b779c1c4d33c644c406f337e27e124adaa.camel@xry111.site>
Cc:     Huacai Chen <chenhuacai@kernel.org>,
        Jinyang He <hejinyang@loongson.cn>,
        Xuerui Wang <kernel@xen0n.name>, loongarch@lists.linux.dev,
        linux-kernel@vger.kernel.org
From:   Youling Tang <tangyouling@loongson.cn>
Message-ID: <f3cf8395-b4fa-4530-0702-2d5a01dd06f4@loongson.cn>
Date:   Fri, 17 Feb 2023 16:24:32 +0800
User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <41b6c7b779c1c4d33c644c406f337e27e124adaa.camel@xry111.site>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 02/17/2023 04:09 PM, Xi Ruoyao wrote:
> On Fri, 2023-02-10 at 16:47 +0800, Youling Tang wrote:
>
>> +               /* Sync the caches ready for execution of new kernel
>> */
>> +               __asm__ __volatile__ (
>> +                       "ibar 0 \t\n"
>> +                       "dbar 0 \t\n");
>
> I think we should add ::: "memory" here to prevent a future compiler
> from being too smart.
Got it.

Thanks,
Youling

>
> Otherwise LGTM.
>