From:   Veerasenareddy Burru <vburru@marvell.com>
To:     Maciej Fijalkowski <maciej.fijalkowski@intel.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Abhijit Ayarekar <aayarekar@marvell.com>,
        Sathesh B Edara <sedara@marvell.com>,
        Satananda Burla <sburla@marvell.com>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
Subject: RE: [EXT] Re: [PATCH net-next v3 2/7] octeon_ep: poll for control
 messages
Thread-Topic: [EXT] Re: [PATCH net-next v3 2/7] octeon_ep: poll for control
 messages
Thread-Index: AQHZQDM5h0Aeoej/jU2wTxnc9Hydo67OtyEAgAQaWGA=
Date:   Fri, 17 Feb 2023 08:25:56 +0000
Message-ID: <BYAPR18MB242341D4F41C972AA520AF39CCA19@BYAPR18MB2423.namprd18.prod.outlook.com>
References: <20230214051422.13705-1-vburru@marvell.com>
 <20230214051422.13705-3-vburru@marvell.com> <Y+vIHjaUvkWXw55x@boxer>
In-Reply-To: <Y+vIHjaUvkWXw55x@boxer>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?g3EpW5AZlFVigHcfFr3/BxMxkQ5HRAENdKMF2p4q7wTdw9CRti1S+6Mm5i+H?=
 =?us-ascii?Q?x9hZPzJQL7+IbyG4En5AgLgiETGCR+rFHQBXW7Hn6/n+3woXKBm0E+7YYuPX?=
 =?us-ascii?Q?+DWwYhs1YbdqmTGzndSLzsFethy2rRxbGsAxER8ExTtbCdBelnfyzLsgvDYu?=
 =?us-ascii?Q?+MZpd92mSoZbpiXeERVyEKwjGI2kCJYWCgozmZ6tq0K+bzEk009Xt740++wx?=
 =?us-ascii?Q?UD/U3YPIZOPPZGM7THjtCflACMMASU+jIf0eS/hEQHIVNzJwtk4i10MoKCdQ?=
 =?us-ascii?Q?oaydVuUQWokwIpoXEBkBdzOTLSk2Wci8dzTsyaZtW+FTf9WKuis6BPUChzIl?=
 =?us-ascii?Q?hfx3wT4oKWkmG6o5oBSGHlx4GSbaKYPj59Mqkoxvdb7qsbScV9Nt2czVj/rZ?=
 =?us-ascii?Q?8kxrF9QFka3o8ipRdiLO6Qw6IXwCfatuuUkKliXdR8jHnlpGgjXL4muo3CCv?=
 =?us-ascii?Q?70MiGmHK4s4E3/Y2zlc+TRDL+GDouGqZjX3+jXp911j1mvkRo8gQ4K9wmdck?=
 =?us-ascii?Q?u3l1SOsc5NiMz1qKxGAcGkqCXoQAQ+aCnu+DCVLk30gm18r4KBYm+K/f4Ss/?=
 =?us-ascii?Q?hFpNQ3K0vQpyuxGDI9aYiA/BXYyrM39UEAAuJ655suFZTcI6vXhu5u/p72AK?=
 =?us-ascii?Q?uiMNmnfZYcleOKIVq0o9xZOGlQL82OoTR6WuLlW5Z0l6RMgMtZ3zY83t0788?=
 =?us-ascii?Q?9Ex1AF3W9xyC7cASdWFecIEd2RmgSwgeGNE6CpoZ4PWk0+Kx3zyNh9/9FnQk?=
 =?us-ascii?Q?S9CxrtkEatfBlATD/PJgnWDdVCUieSVtlU3bUJFjp4cx5nO3G/A/BYm2JEqg?=
 =?us-ascii?Q?6dwl1sD96iCerBxqTXBgp9zTKqNOLZ/TiBD7wqhZ8vtPfFcVFlPoHQBIoWte?=
 =?us-ascii?Q?Sbug2nrxoto5TLV+oPyKPf1WDurQ3WMIBj9fFkJrKE/sAUze82xqkyoO21Zc?=
 =?us-ascii?Q?ORv6uxkVhdUSl5Rqd6caSd7x8A+Ume2HEKKPitcHy52h9+qtkwuIeMa1PZCO?=
 =?us-ascii?Q?3GuEkKF3m/XYW4eX8FYjoLSnIbi++kzKduwUS5vo0b+0PQU5nUyGJE4Byl2I?=
 =?us-ascii?Q?aJ09U+WyxJb1Lpkj8WHcfdAvzUl56SeD5tpmERWptHIUfcJ16/lMci6L1hyk?=
 =?us-ascii?Q?HWj5TEHgo4E6VGKbGW4ubHc27VlG17uIN5IBkNcrM0N5K4OSHCI3/9ymBgsX?=
 =?us-ascii?Q?8WURv+GJsyk+Z7Ufjbq1G+57WHy/vPUv43cLpUi5OQmmFsS4gB+AqMHjvE8W?=
 =?us-ascii?Q?f8w0MsvzEhOZn9/Ku/CsrOMxqg+ca2DOv2lkH8n3YUPZiI/gDs+3kf+lXpOj?=
 =?us-ascii?Q?psAuSpDGT1QRvTwBWnyE3qYmsIIU9seXg1vu0XW4diDhFUmGgLx0xktbxa5l?=
 =?us-ascii?Q?hcGw0xwibcYmUvdaxav99Z5vuyQzKUHgrEzMrwid79qfFT6Y40kR6OwSi/hd?=
 =?us-ascii?Q?FeHeoEIUH7k9zceobUQ6qajF5TdALHXBN3rPeeHD95NbStwkdpnyZdvimRxw?=
 =?us-ascii?Q?aNv4MhXnhiAKO/Jv8smeDpZ+IuJqeNTtViPg3K4hSswRAAjX/WBxTEPLZJWl?=
 =?us-ascii?Q?8mwGJx+YBPssenIUAldzuf19/4hIkpsGd6FNrwvS?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR18MB2423.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 88fe2f0a-c5df-460a-3339-08db10c0977b
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Feb 2023 08:25:56.4099
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wN8KqyZd0c0OG37ti1FH4h4eFwrbBBWxLFeXEFWAvXMeeLGn1gagI0cT4OjNknwFIq0IcgTRncestp3P01SYkQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR18MB3565
X-Proofpoint-ORIG-GUID: ReM--AVlQ-5pE0WXKg8kHb6OvDXO3Ibq
X-Proofpoint-GUID: ReM--AVlQ-5pE0WXKg8kHb6OvDXO3Ibq
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22
 definitions=2023-02-17_04,2023-02-16_01,2023-02-09_01
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> Sent: Tuesday, February 14, 2023 9:43 AM
> To: Veerasenareddy Burru <vburru@marvell.com>
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Abhijit Ayareka=
r
> <aayarekar@marvell.com>; Sathesh B Edara <sedara@marvell.com>;
> Satananda Burla <sburla@marvell.com>; linux-doc@vger.kernel.org; David S.
> Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>;
> Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>
> Subject: [EXT] Re: [PATCH net-next v3 2/7] octeon_ep: poll for control
> messages
>=20
> External Email
>=20
> ----------------------------------------------------------------------
> On Mon, Feb 13, 2023 at 09:14:17PM -0800, Veerasenareddy Burru wrote:
> > Poll for control messages until interrupts are enabled.
> > All the interrupts are enabled in ndo_open().
> > Add ability to listen for notifications from firmware before ndo_open()=
.
> > Once interrupts are enabled, this polling is disabled and all the
> > messages are processed by bottom half of interrupt handler.
> >
> > Signed-off-by: Veerasenareddy Burru <vburru@marvell.com>
> > Signed-off-by: Abhijit Ayarekar <aayarekar@marvell.com>
>=20
> small two nits
>=20
> > ---
> > v2-> v3:
> >  * resovled review comment; fixed reverse christmas tree.
> >
> > v1 -> v2:
> >  * removed device status oct->status, as it is not required with the
> >    modified implementation in 0001-xxxx.patch
> >
> >  .../marvell/octeon_ep/octep_cn9k_pf.c         | 49 +++++++++----------
> >  .../ethernet/marvell/octeon_ep/octep_main.c   | 35 +++++++++++++
> >  .../ethernet/marvell/octeon_ep/octep_main.h   | 11 ++++-
> >  .../marvell/octeon_ep/octep_regs_cn9k_pf.h    |  4 ++
> >  4 files changed, 71 insertions(+), 28 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_cn9k_pf.c
> > b/drivers/net/ethernet/marvell/octeon_ep/octep_cn9k_pf.c
> > index 6ad88d0fe43f..f40ebac15a79 100644
> > --- a/drivers/net/ethernet/marvell/octeon_ep/octep_cn9k_pf.c
> > +++ b/drivers/net/ethernet/marvell/octeon_ep/octep_cn9k_pf.c
> > @@ -352,27 +352,36 @@ static void
> octep_setup_mbox_regs_cn93_pf(struct octep_device *oct, int q_no)
> >  	mbox->mbox_read_reg =3D oct->mmio[0].hw_addr +
> > CN93_SDP_R_MBOX_VF_PF_DATA(q_no);  }
> >
> > -/* Mailbox Interrupt handler */
> > -static void cn93_handle_pf_mbox_intr(struct octep_device *oct)
> > +/* Process non-ioq interrupts required to keep pf interface running.
> > + * OEI_RINT is needed for control mailbox  */ static int
> > +octep_poll_non_ioq_interrupts_cn93_pf(struct octep_device *oct)
>=20
> return bool?
>=20

Yes, bool is sufficient. Will make the change in next revision.

> >  {
> > -	u64 mbox_int_val =3D 0ULL, val =3D 0ULL, qno =3D 0ULL;
> > +	int handled =3D 0;
> > +	u64 reg0;
> >
> > -	mbox_int_val =3D readq(oct->mbox[0]->mbox_int_reg);
> > -	for (qno =3D 0; qno < OCTEP_MAX_VF; qno++) {
> > -		val =3D readq(oct->mbox[qno]->mbox_read_reg);
> > -		dev_dbg(&oct->pdev->dev,
> > -			"PF MBOX READ: val:%llx from VF:%llx\n", val, qno);
> > +	/* Check for OEI INTR */
> > +	reg0 =3D octep_read_csr64(oct, CN93_SDP_EPF_OEI_RINT);
> > +	if (reg0) {
> > +		dev_info(&oct->pdev->dev,
> > +			 "Received OEI_RINT intr: 0x%llx\n",
> > +			 reg0);
> > +		octep_write_csr64(oct, CN93_SDP_EPF_OEI_RINT, reg0);
> > +		if (reg0 & CN93_SDP_EPF_OEI_RINT_DATA_BIT_MBOX)
> > +			queue_work(octep_wq, &oct->ctrl_mbox_task);
> > +
> > +		handled =3D 1;
> >  	}
> >
> > -	writeq(mbox_int_val, oct->mbox[0]->mbox_int_reg);
> > +	return handled;
> >  }
> >
> >  /* Interrupts handler for all non-queue generic interrupts. */
> > static irqreturn_t octep_non_ioq_intr_handler_cn93_pf(void *dev)  {
> >  	struct octep_device *oct =3D (struct octep_device *)dev;
> > -	struct pci_dev *pdev =3D oct->pdev;
> >  	u64 reg_val =3D 0;
> > +	struct pci_dev *pdev =3D oct->pdev;
>=20
> why this move of var and rct breakage?
>=20

Thank you for the feedback. This change was not necessary. Will revert this=
 change.
I will recheck whole patchset for RCT breakage and fix it in next revision.

> >  	int i =3D 0;
> >
> >  	/* Check for IRERR INTR */
> > @@ -434,24 +443,9 @@ static irqreturn_t
> octep_non_ioq_intr_handler_cn93_pf(void *dev)
> >  		goto irq_handled;
> >  	}
> >
> > -	/* Check for MBOX INTR */
> > -	reg_val =3D octep_read_csr64(oct, CN93_SDP_EPF_MBOX_RINT(0));
> > -	if (reg_val) {
> > -		dev_info(&pdev->dev,
> > -			 "Received MBOX_RINT intr: 0x%llx\n", reg_val);
> > -		cn93_handle_pf_mbox_intr(oct);
> > +	/* Check for MBOX INTR and OEI INTR */
> > +	if (octep_poll_non_ioq_interrupts_cn93_pf(oct))
> >  		goto irq_handled;
> > -	}
> > -
> > -	/* Check for OEI INTR */
> > -	reg_val =3D octep_read_csr64(oct, CN93_SDP_EPF_OEI_RINT);
> > -	if (reg_val) {
> > -		dev_info(&pdev->dev,
> > -			 "Received OEI_EINT intr: 0x%llx\n", reg_val);
> > -		octep_write_csr64(oct, CN93_SDP_EPF_OEI_RINT, reg_val);
> > -		queue_work(octep_wq, &oct->ctrl_mbox_task);
> > -		goto irq_handled;
> > -	}
> >
> >  	/* Check for DMA INTR */
> >  	reg_val =3D octep_read_csr64(oct, CN93_SDP_EPF_DMA_RINT);
> > @@ -712,6 +706,7 @@ void octep_device_setup_cn93_pf(struct
> octep_device *oct)
> >
> >  	oct->hw_ops.enable_interrupts =3D
> octep_enable_interrupts_cn93_pf;
> >  	oct->hw_ops.disable_interrupts =3D
> octep_disable_interrupts_cn93_pf;
> > +	oct->hw_ops.poll_non_ioq_interrupts =3D
> octep_poll_non_ioq_interrupts_cn93_pf;
> >
> >  	oct->hw_ops.update_iq_read_idx =3D
> octep_update_iq_read_index_cn93_pf;