Message-ID: <74818031-0a0f-bdcb-3a04-434203f7c99a@nvidia.com>
Date:   Fri, 17 Feb 2023 09:39:29 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [Patch] [tegra] Remove unneeded version.h includes pointed out by
 'make versioncheck'
Content-Language: en-US
From:   Jon Hunter <jonathanh@nvidia.com>
To:     Jesper Juhl <jesperjuhl76@gmail.com>, linux-kernel@vger.kernel.org
Cc:     linux-tegra@vger.kernel.org,
        Thierry Reding <thierry.reding@gmail.com>
References: <8611b610-a21b-6037-52ad-9439c4f44995@gmail.com>
 <f1b1c2df-b88d-e668-fade-ca0ef74e7b07@nvidia.com>
In-Reply-To: <f1b1c2df-b88d-e668-fade-ca0ef74e7b07@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QlRRNEt0KzhiMDF5cUFyOENkU2dESE1tcHFFV1BIUzBzYlVzbGtINzF5a3VQ?=
 =?utf-8?B?emt1WmliSjNpU1NnK3FndTdEcS94RklYZGdyMUM2UnNyOG1RUjlhOTJXR0NY?=
 =?utf-8?B?R1pvbktMQ3gzejI0UDAxM3JESzRxRHZLcnE2bnA0VWNtZ2VBV2YxVXVFa2V0?=
 =?utf-8?B?NGt5b3NGdmNBaE5pa0pUY3RZWGdaTUdyM3pKaXlUVmFackI4K0U1SjVoV1lq?=
 =?utf-8?B?V08zWkJ1TkRDWC84QVFIQ21PYktnZU4vSDhIL2dOd043VTJ3QTJqbGNvNTRl?=
 =?utf-8?B?dFJ4OXZ5K2FoemkwT2ZZQWk0VHgwSVJQQ3pqamRKNUFZVU9UZERVM2x2cHRp?=
 =?utf-8?B?OXlhYkxrWDFrbTZIUUxQcXZxdUhWR21mRmRVcGRPMTZlWXZ1R0NvU0M3SVpl?=
 =?utf-8?B?YU9NT3BINk5GQlB6eGNRQmNMSHA4VDUwclhwaCtGZW45Qi9Ld1AxQ0NvZysx?=
 =?utf-8?B?NzVlVUxmMERraFQ0OFpnam4vS3FqLzNYL0tXN0JoUnFERmdlRXphK2VxdUVO?=
 =?utf-8?B?R01XM1Mzc0hLaDVaWDNBL0d6SnhTd0J3YUZhdmRsdlFsSkd3cm9RR3grdklK?=
 =?utf-8?B?a3pDTjNJbFlONVdTZitFMzhmUk80R0YyZE5CUTUzT2NmS2NSOTdlTG85MktG?=
 =?utf-8?B?WGNHSXQwcmh4U3ZqUWhWTmt2Y052VUFQdmZuL0Z3YmM4Vit2bTBTSlJNblVY?=
 =?utf-8?B?RFZKLzJkVVNNTnRPSFJqNlBRSFFMY2VEa2VoVmxwazcwTTVNWGZpb0RLWng0?=
 =?utf-8?B?NnM2NkFUMWdobmtyTHhBWDJqRm44ODNEMFNIZjhycjhRN0NOcTQ4VTBiTXZM?=
 =?utf-8?B?S0lUdUZmaWtlUWxXSnFEZlZkcExPRzM0K1JCNmxTUHh5TmJ2K1U3ZmFjblB2?=
 =?utf-8?B?NnZSTUxFVHlhVWtDUTFjeTBnQ1oxVWYrS1lHaS9TamFKZFBsZjd5NzJwM2ln?=
 =?utf-8?B?SXAzVGllZ3UvTFBlSjFlWWhydDdkRFNJNVpmaGRIeVl3MWdwWnZiV1ZvSXFx?=
 =?utf-8?B?WXJJZ01Ba0J4bW1YTElzTks2Y0ZWdFljNHZheXdsUC9ZRmNadjhuY1FKODlk?=
 =?utf-8?B?cm9CWkU3d0Q0Tk5taE0zd09KU3laR0piUTlqYWY3TlM4NjhoWkowK0ZuUThR?=
 =?utf-8?B?ZXd4RGp5d3k1REpIWStrbCtrYlhZMzN1TjlWQVVzTnYyRmEwUVNFdkkreWhL?=
 =?utf-8?B?bEs3YTkxWjdYRVljY0tiMnJ6dVZFeElwT1lzR0UxeEczbjhMbjMxbkVYeFpt?=
 =?utf-8?B?aGFkZDVjWkh4dmxJMFBGdmppTVNVOGtkK1ZOc29ZQUxYU2FMcTkrNnFDZnJK?=
 =?utf-8?B?TEkyUklqeTZnR1FFVG8yWGRNNGcwQ3R4cDlFcno3Lzk1dFhwRkxiYkdlRHJP?=
 =?utf-8?B?N3ZmU1VJY1BydWp0R2RnbU16OEEyUDAzcWRxZ09TQnpxbzQxTmZkMzdlMnFJ?=
 =?utf-8?B?NHJhelJIL0I1NmE4dkVqNlAwdkdoRkErL1QwTmMzaDRaOCs1L0xmWWE1QVRI?=
 =?utf-8?B?Y3ZScnJwcmxSZmlUSmRsTnRCY2xPZlVLZHlPSDJWM21mTUxCeHpDRzd0TzRh?=
 =?utf-8?B?bGtmVThKKzNSalRsUzRkZ3JaVFVXOEFFaUN5VkxBZ2cyRDRKaWRUYVRXeUIr?=
 =?utf-8?B?eUc5N2YvcnozcnorcXZ3RzRqMG1uam1KUmEvTDdGUGp0THJjZWRUVVNYbVFC?=
 =?utf-8?B?ZEF6THQyNHZVUXN6Yk9obnd2YnN1YWJaN2t2ZUlsU0FRYUNYQzlWbHpLZDda?=
 =?utf-8?B?NmJtWGJnK3Fnbkhudm9UMHh0UkJiQ2FmRkpFWnYzeW5YWGcvZ2swY1p2NXRX?=
 =?utf-8?B?eTBnY1FGeG5ra095bFI4ZGJVMndiOGlnaG1PTkZFNXpTWld5R0UvUXlNSzRi?=
 =?utf-8?B?bThEc3VNMmpIYjZ2Mi9NR3FKbHpjRWZBZit5a214MkJhbjVNcDc0OFpuYjgr?=
 =?utf-8?B?MUNFQ29qYkwzVU16V2RnaU5mb3U0UDFRZDdoYzZEanUzZzVRSW1wZ1dVSCth?=
 =?utf-8?B?cDNBb1AwZER1OG9ZWTFpU3lPTUJiVlFlWk9zWjVUTmdpVXdJVVh0VitUZG5q?=
 =?utf-8?B?eG9VTHJnb3o5dEpLdWFGVGQ2bVZhdVgwSit0MXBhQlZHS1pUSS8rS1A2SlVm?=
 =?utf-8?B?cDV2eEEvQ2Q2RkhtNVA3ZnhacXJ5SzdwbVZWeHM0VDdyKzdTbit2Ykl2M0dW?=
 =?utf-8?B?TDVBTzRJNXNxeDVyRlhnaWxQZ0FDMjRmbzlIaGZGdkZMTld3ODc1SUc3dzNT?=
 =?utf-8?B?L3RLVzlaNW5xVVlmeXBkMjRyWCtRPT0=?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f210efbb-083d-4b5c-a8e3-08db10cae178
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2023 09:39:35.8088
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HYOgo+0N/TOnQUiw0X240utUKb38lIsfYD3thKaTTJ0ozfRNcJCxgVa3i8IWyPk6+6FSUkKui8WGt24zzSJ4hw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4965
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 17/02/2023 09:30, Jon Hunter wrote:
> 
> On 16/02/2023 00:53, Jesper Juhl wrote:
>>  From 7264ec7d00ece4b56fe9fafa3237d4870cbe6785 Mon Sep 17 00:00:00 2001
>> From: Jesper Juhl <jesperjuhl76@gmail.com>
>> Date: Mon, 13 Feb 2023 02:49:50 +0100
>> Subject: [PATCH 04/12] [tegra] Remove unneeded version.h includes 
>> pointed out
>>   by 'make versioncheck'
>>
>> Signed-off-by: Jesper Juhl <jesperjuhl76@gmail.com>
> 
> 
> The patch looks correct, but there is no commit message and I am not 
> sure why the header is in the body of the message. Make sure you use git 
> send-email to send patches.

Also the patch $subject prefix should match subsystem you are patching.
You can check this by looking at the git history ...

$ git log --oneline drivers/soc/tegra/cbb/
b6c6bbfc65f5 soc/tegra: cbb: Remove redundant dev_err call
fa9b5246e260 soc/tegra: cbb: Use DEFINE_SHOW_ATTRIBUTE to simplify tegra_cbb_err
2927cf85f487 soc/tegra: cbb: Check firewall before enabling error reporting
55084947d6b4 soc/tegra: cbb: Add checks for potential out of bound errors

So you want some like "soc/tegra: cbb: Remove unneeded version.h header"

Jon

-- 
nvpublic