Message-ID: <9efa30b4-5a6d-91b3-617c-853f0ac0b22e@amd.com>
Date:   Fri, 17 Feb 2023 10:47:20 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH] dma-buf: make kobj_type structure constant
Content-Language: en-US
To:     =?UTF-8?Q?Thomas_Wei=c3=9fschuh?= <linux@weissschuh.net>,
        Sumit Semwal <sumit.semwal@linaro.org>
Cc:     linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org
References: <20230217-kobj_type-dma-buf-v1-1-b84a3616522c@weissschuh.net>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20230217-kobj_type-dma-buf-v1-1-b84a3616522c@weissschuh.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?My9MV3R1aWlOMi9hTlpRYU1iWVE3U0pKN2dMNTlzZ1VlZmFyY3o0Zk9TV1g2?=
 =?utf-8?B?K3QveU5CMXNCRElYNmQyVkJCYVI1K1hpTUhpWnNtL3JYb2J3TDRROGZqTUox?=
 =?utf-8?B?NHkvVFJiUk1oZGJ4cFk1ODhNZ2o0UFB0NHZucTBCNU9EOC84ZGRueEtaN3J3?=
 =?utf-8?B?cHF5R0pUa0tlbjdWMTFXMkpyRlo2dml6RnVHam9TRUliTlBxNStKQUlmSWVo?=
 =?utf-8?B?ejhkM09DVGprNnBqNHBZK1p4eHQyYWVPZjZGZ0JldlJodVZoSjc5Y2VicFpC?=
 =?utf-8?B?N0x0NkVCRDg3NVIvRTduQlBkWG5MZURrTmRQa0xuS0FIcmU0Z0xEOEZ5Wlo1?=
 =?utf-8?B?ckVXS1M5cHRIZnZSL0ZmWVl2UDk2TVpwL2FyclBUb0RPQk51RkQwd3Z1TGR1?=
 =?utf-8?B?OUtjUUJ3bjBZbjNGSmd6a2srWjRhV2hEbmNUaHhuVzhnS0FkMGdPMkRSSkNM?=
 =?utf-8?B?bUtBTGI0ZEJNa0JEMGRCdUorVGlTQ0o5dFVGbGtCazQrcWtUckhsdDVWeXpN?=
 =?utf-8?B?ZFhqWElaQzVpcEVwMEZpS2ZsTGV4TlIxeHliL0liK3dtYmRHUG02YXd6dXRk?=
 =?utf-8?B?SUJSN1hZWnkxR1RML2ErdFlyNkU5bDJTcTU5OXV2L09EKytHWUwrd2tyQ25E?=
 =?utf-8?B?YmQ0OEJuSHpoRXczc3g0b292V0gzS0wyd25tMm91MklRMnhTeGtqMTZYMk03?=
 =?utf-8?B?V1VybVYrbzBUMGlzcUxUQ0VWajh3MGthK0xjbzB1czlWbjFMMnMrMUJjOU9I?=
 =?utf-8?B?a3VMbHh4OGZTUDgrdDFtTmFIdC9xVUs1aDEyaWh6dTAvWGRoZkVJM0hVUFhM?=
 =?utf-8?B?OUFraXY1cUxuZi9MWUNRVk00NzFYdHQ2MmQwU3NOTFVkY0RGSHQwUU5MZGJy?=
 =?utf-8?B?SkluRDl2R1hsRkxXbml5dU10K0dSQmtyaWJHQy9qa0Jya05PNWdkQ21GRXY5?=
 =?utf-8?B?Y2o1YS9QR2Z4bHVpemFtc0tGandNRndaMXdEQzNyenhYczFQNXgyTGxvWVhK?=
 =?utf-8?B?aDFDY2hxLzZrc0l5VnNYV1FIb0tWeFNUci9MQTM1MXkzWHFlVjI4QkdvVWdE?=
 =?utf-8?B?M0VhMHNQWlp0dDR3VCtOYkhHODh3em1MODRFNXFoY1NJQnVDWU0yaWpWeGFH?=
 =?utf-8?B?WmhoYWdFdkpmdjBWZy82dGFvdGNOMGhsSTNSQkcvWmFwU0xIT1RvZ3VuYXhE?=
 =?utf-8?B?bzljL3FHTHY0VlFSVERNMVFzbmpzNkFlR3FoVUpYcHllUVVNakwyZ1ZURFFq?=
 =?utf-8?B?RmNneU9uZzJ4Sm9WNXI5eUlWSVFJbXo4aGNEZTM2bTBrc1JqSHpGR05vRjVq?=
 =?utf-8?B?Wlg0eHpkSWJuWjRUNW9CU3ZlOWJLK25pcG4zdGRZS2laUWNsRHpCazNWdG5l?=
 =?utf-8?B?KzFsdVFhMmd6OGovSm1hUnJyYlhZSG9TYU55MWRWNm15RzJiT3BlVE1ydnZu?=
 =?utf-8?B?V3lYcktHbjV4ZDF3ampET2ZuUm10ZTE1c2VxdC9UOHREclhPRFhJQ3Y3bTVa?=
 =?utf-8?B?QTVPZlBBYit2Szlhc2tpOGpSNFluV1YwUEFab2VVaFZlV1Fpa2hvSGFoS1pY?=
 =?utf-8?B?RzFML3dnaVJvVXFjV0s2bVA5TVc4aXU0VkoycWdka1BYWEdCdlBmaU4zOEhM?=
 =?utf-8?B?T0RCYU16K3I5TWRrQ0JWQlUxZWJ0UnlKbkd1UHBwQlN3d2FRbTNaRndCWGNm?=
 =?utf-8?B?ZUFqRVc0TzQrNkZDcmUzK1VhaTNOU1B1ZFQxSWZKV0ZockwrdEN5K2NlaHlJ?=
 =?utf-8?B?dHhLanVvaHdOSEdGV3FaMERxcVNDb2ZMNi9YTEpPR25xcExvc05SaVZxN2NS?=
 =?utf-8?B?Y0lhenZwU0liWE1DUGl5cEFhSmNmMVE5OHEyVFRubnFxUVlKRDQ4YitGTVpp?=
 =?utf-8?B?ZVRpRjFBNGhZYTBXV3RyaHl5NGpkWGRYWE5POG5SY1VxTThmaElKUDkrV3U5?=
 =?utf-8?B?RCswbkNNTjllcHdrcTJYblFzekY2MHU5SitJTVdydTdEcXhXZWJHZFJZbDQ3?=
 =?utf-8?B?M0tiMXFucjNqOE4rNlo0YnQ3d2hwb0xWUmhJVDlVOERCUVRiY29Wdml2anFM?=
 =?utf-8?B?M2pLZG1MYzNhdDFYL2lZa2hnM2Y0RUFGVWxMK0J4UXV6L0pXcVBVbkNMbjJx?=
 =?utf-8?B?bnlVVFg4UUhLcXBpWnlZS25MSkFBMUlvL1A4aUkxNXB6Ui8vVzdyS3NKSisr?=
 =?utf-8?Q?tYcki4r2bbt+qgP39Y/qvB9uvujY80Uygfw8UihmHF9m?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a91e2dea-3241-45f1-e361-08db10cbf97d
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2023 09:47:25.5583
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BgEiSPYFuZkpqQ5n1eLFRCL6WzPcbBW7nkoKlPIU3Dbh9BaLF28zcPEe2cvwMFIK
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7956
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 17.02.23 um 04:13 schrieb Thomas Weißschuh:
> Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
> the driver core allows the usage of const struct kobj_type.
>
> Take advantage of this to constify the structure definition to prevent
> modification at runtime.
>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>

Reviewed-by: Christian König <christian.koenig@amd.com>

I will pick this up for upstreaming through drm-misc-next.

Thanks,
Christian.

> ---
>   drivers/dma-buf/dma-buf-sysfs-stats.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma-buf/dma-buf-sysfs-stats.c b/drivers/dma-buf/dma-buf-sysfs-stats.c
> index fbf725fae7c1..6cfbbf0720bd 100644
> --- a/drivers/dma-buf/dma-buf-sysfs-stats.c
> +++ b/drivers/dma-buf/dma-buf-sysfs-stats.c
> @@ -112,7 +112,7 @@ static void dma_buf_sysfs_release(struct kobject *kobj)
>   	kfree(sysfs_entry);
>   }
>   
> -static struct kobj_type dma_buf_ktype = {
> +static const struct kobj_type dma_buf_ktype = {
>   	.sysfs_ops = &dma_buf_stats_sysfs_ops,
>   	.release = dma_buf_sysfs_release,
>   	.default_groups = dma_buf_stats_default_groups,
>
> ---
> base-commit: 3ac88fa4605ec98e545fb3ad0154f575fda2de5f
> change-id: 20230217-kobj_type-dma-buf-a2ea6a8a1de3
>
> Best regards,