From:   Michael Walle <michael@walle.cc>
To:     kumaravel.thiagarajan@microchip.com
Cc:     UNGLinuxDriver@microchip.com, arnd@arndb.de,
        derek.kiernan@xilinx.com, dragan.cvetic@xilinx.com,
        gregkh@linuxfoundation.org, linux-gpio@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        Michael Walle <michael@walle.cc>
Subject: Re: [PATCH v1 char-misc-next 2/5] misc: microchip: pci1xxxx: load gpio driver for the gpio controller auxiliary device enumerated by the auxiliary bus driver.
Date:   Fri, 17 Feb 2023 11:31:16 +0100
Message-Id: <20230217103116.2126311-1-michael@walle.cc>
In-Reply-To: <20220824200047.150308-3-kumaravel.thiagarajan@microchip.com>
References: <20220824200047.150308-3-kumaravel.thiagarajan@microchip.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

[+ GPIO maintainers]

> PIO function's auxiliary bus driver enumerates separate child devices for
> GPIO controller and OTP/EEPROM interface. This gpio driver implemented
> based on the gpio framework is loaded for the gpio auxiliary device.
> 
> Signed-off-by: Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com>
> ---
>  MAINTAINERS                                   |   1 +
>  drivers/misc/mchp_pci1xxxx/Makefile           |   2 +-
>  .../misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c   | 163 ++++++++++++++++++

Why doesn't this file live in the GPIO subsystem? Seems like this haven't
got a proper review from the GPIO people (probably due to the "misc:"
subject). Maybe even GPIO_REGMAP could be used.

-michael