Message-ID: <4a5c8cecb87735a6d697b3ff0da724cc73015669.camel@gmail.com>
Subject: Re: [PATCH v4 0/3] mm/khugepaged: fix khugepaged+shmem races
From:   Miko Larsson <mikoxyzzz@gmail.com>
To:     David Stevens <stevensd@chromium.org>, linux-mm@kvack.org,
        Peter Xu <peterx@redhat.com>,
        Matthew Wilcox <willy@infradead.org>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        "Kirill A . Shutemov" <kirill@shutemov.name>,
        Yang Shi <shy828301@gmail.com>,
        David Hildenbrand <david@redhat.com>,
        Hugh Dickins <hughd@google.com>, linux-kernel@vger.kernel.org
Date:   Fri, 17 Feb 2023 11:37:17 +0100
In-Reply-To: <20230217085439.2826375-1-stevensd@google.com>
References: <20230217085439.2826375-1-stevensd@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.3 (3.46.3-1.module_f37+15877+cf3308f9) 
MIME-Version: 1.0
Precedence: bulk

On Fri, 2023-02-17 at 17:54 +0900, David Stevens wrote:
> From: David Stevens <stevensd@chromium.org>
>=20
> Fix two races in khugepaged+shmem that cause issues with userfaultfd
> and
> lseek, respectively.
>=20
> v3 -> v4:
> =C2=A0- Base changes on mm-everything (fba720cb4dc0)
> =C2=A0- Add patch to refactor error handling control flow in collapse_fil=
e
> =C2=A0- Rebase userfaultfd patch with no significant logic changes
> =C2=A0- Different approach for fixing lseek race
> v2 -> v3:
> =C2=A0- Use XA_RETRY_ENTRY to synchronize with reads from the page cache
> =C2=A0=C2=A0 under the RCU read lock in userfaultfd fix
> =C2=A0- Add patch to fix lseek race
> v1 -> v2:
> =C2=A0- Different approach for userfaultfd fix
>=20
> David Stevens (3):
> =C2=A0 mm/khugepaged: refactor collapse_file control flow
> =C2=A0 mm/khugepaged: skip shmem with userfaultfd
> =C2=A0 mm/khugepaged: maintain page cache uptodate flag
>=20
> =C2=A0include/trace/events/huge_memory.h |=C2=A0=C2=A0 3 +-
> =C2=A0mm/khugepaged.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 263 +++++=
+++++++++++-----------
> --
> =C2=A02 files changed, 144 insertions(+), 122 deletions(-)
>=20

Might want to Cc this to the stable mailing list.
--=20
~miko