Date:   Fri, 17 Feb 2023 15:00:34 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     netdev@vger.kernel.org
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Gerhard Engleder <gerhard@engleder-embedded.com>,
        Amritha Nambiar <amritha.nambiar@intel.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Ferenc Fejes <ferenc.fejes@ericsson.com>,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 05/12] net: ethtool: create and export
 ethtool_dev_mm_supported()
Message-ID: <20230217130034.azg4syteitf72vgl@skbuf>
References: <20230216232126.3402975-1-vladimir.oltean@nxp.com>
 <20230216232126.3402975-6-vladimir.oltean@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230216232126.3402975-6-vladimir.oltean@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hhPErJprI6uM46Scd+mGpRZONL+AZ2XIsPh40B/nqJMb5PLeg97BcXOxX7f+?=
 =?us-ascii?Q?zVIRyJ8DUaw9Sny5Lz4Nn6Whl9odvCcK9RELRUqDGDev/uf6zLsZOMo+XyAq?=
 =?us-ascii?Q?XHa/6lOAiXRXBkCleDJJXENmFlmGwD2G3N12n8k7TxdLfN5eA7Njr6Pil1xd?=
 =?us-ascii?Q?mmQ4zqiaSH8/Z/NYbKPvUfB1JpuPwW5tOX2cw6fQJ27L2yjz9Ww1XvYm76Um?=
 =?us-ascii?Q?SvNbWGNczQaAB4akigPRcOyPNjUQFzCExbWV4k8fB41khGUr2F8DjwwFV2hR?=
 =?us-ascii?Q?mjkTxlzxDOvtM0b3lMH7l3TxB7B1zshlFeI+MtDkUNcsJUbDhH5RplY8sEsm?=
 =?us-ascii?Q?+6wTVnuYlH+A0QgcKvZnN8EtqY/FTqphCN0MfRNV9BYoQZwgwI0FbbmdYqXF?=
 =?us-ascii?Q?4SD+DAsgImTCiXQxZaB+1SdRYXfKu2QhN8wqbON1imCvKWCDV1PLT+iDlWlS?=
 =?us-ascii?Q?jOF/Ru8CSUuVL2FjnERZvx23EZfpKqjZfUc5Hqirla5ph6VcNXTK5JQK0J2M?=
 =?us-ascii?Q?aOfZnO7C8F9wPWbLv+vN+b9++coYdK9fdqJ7tDigdublYRl1dEdJwZQcDTiP?=
 =?us-ascii?Q?HqqqN5kCEnkJknSb8e1bQtGiUEaXMWvU4z+QMvcVUQq44jrPC31jehc8Ksfy?=
 =?us-ascii?Q?pyR9hNsycwJoylsRd7w470Nst/gwfr6ZAwjdopuYzVfH5vymjkFGfjw6CIFW?=
 =?us-ascii?Q?VWrjYhrlWWGcIBBwSmi6COFj89R+SR3pMg73daFXfPeO7kF5gAmHbM0LWcr6?=
 =?us-ascii?Q?M2MQ4kzpu+YSVjPhELk1yl2B+WJMVhtt+xMGK0xJbHjbOe4OFKBT2boBMj+t?=
 =?us-ascii?Q?/Vz4c6UvzRjctjNp/doN+FO23OCoQwLTGW9Gls+/LojisKWmN+9wd+NsvCz0?=
 =?us-ascii?Q?d7fSVLqWdLUbZTU0j+EJMs5NjBJhHRyYbDBgzci3Tt4hod16xZhHyvezWiKN?=
 =?us-ascii?Q?5XwJcXSN7EDXvOBoEVEhW0I/QvL/POGWqQf0iyrwsKac3FSxNmiotLZZ2Jdp?=
 =?us-ascii?Q?r9MBWty/Uqf/X76sCO1uTvXDYbzHkORyznw9L09RiIBUOpzaJ5pHLMA9yv2u?=
 =?us-ascii?Q?S6s7luigYK+Vt2VVi/5noDZUliQINBm2BGBn9ZG5FmeeQwpImw6QP1tPWAz1?=
 =?us-ascii?Q?Z2VGnFH4+VX8VvzbKkBV75eSXdG9yiweQ01dsZeL9ojoSnxnlEw+DfcHp7f7?=
 =?us-ascii?Q?JixJvq8ZPbwZX4GBPZFYK68/FMvluijHaEveNRv0rHEqc8fsmF1N75uOujts?=
 =?us-ascii?Q?8spb97+YNtkuaRN2/A4qaLin01A7C9oDK/iCbtchB9l2HVWFNB3UQYahvQG+?=
 =?us-ascii?Q?ykSp4R1vjp1M51rGm9FDWw7CGbgc1XTdez+cbRstrbgH9e1ZlFFxjPG2t3Nr?=
 =?us-ascii?Q?kODiDvLkvEsGyCvbRr2EJnnc1w7X9ZaEIFEATe8YKpy6Oy2MgOLR8u8y4Wqw?=
 =?us-ascii?Q?A9SBG93h84LfAXJuohpdYhppLPmCAVITXKj7sYaThWL/G2bQcV2cuFf+BXoz?=
 =?us-ascii?Q?Mw5gvYOnBva/r7TU0R4I5Ab7SeNyhhyBbDgy/VPtad2twAS7oxZXjarSr33t?=
 =?us-ascii?Q?ZhVZBDkOvqNU1i76I57jS5yyk65Xx5Jl4vBV6xHf2f4K+Smzvt3W2NlkqGb0?=
 =?us-ascii?Q?hw=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b9d587f6-f4ca-4eaf-cb21-08db10e6f72a
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2023 13:00:38.8043
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PshAqs0ZEyJzSG81flLqnW+/nNgYBSLgacc8LRrvwAQExspo8J8OLpQ12XN9hxoy4MzSPrWlhmQ9XnGV8a22ug==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8649
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Feb 17, 2023 at 01:21:19AM +0200, Vladimir Oltean wrote:
> +bool ethtool_dev_mm_supported(struct net_device *dev)
> +{
> +	const struct ethtool_ops *ops = dev->ethtool_ops;
> +	bool supported;
> +	int ret;
> +
> +	ASSERT_RTNL();
> +
> +	if (!ops)
> +		return false;
> +
> +	ret = ethnl_ops_begin(dev);
> +	if (ret < 0)
> +		return false;
> +
> +	supported = __ethtool_dev_mm_supported(dev);
> +
> +	ethnl_ops_complete(dev);
> +
> +	return supported;
> +}

In the first patch that uses this:

ERROR: modpost: "ethtool_dev_mm_supported" [net/sched/sch_mqprio.ko] undefined!

due to a missing EXPORT_SYMBOL_GPL(). Sorry.