Subject: Re: [PATCH] net: myri10ge: force select inet_lro
From: Daniel Walker <dwalker@mvista.com>
To: David Miller <davem@davemloft.net>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
In-Reply-To: <20070908.012214.41650322.davem@davemloft.net>
References: <20070907202625.702755508@mvista.com>
	 <20070908.012214.41650322.davem@davemloft.net>
Content-Type: text/plain
Date: Sat, 08 Sep 2007 09:03:06 -0700
Message-Id: <1189267386.9688.28.camel@imap.mvista.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1378
Lines: 38

On Sat, 2007-09-08 at 01:22 -0700, David Miller wrote:
> From: Daniel Walker <dwalker@mvista.com>
> Date: Fri, 07 Sep 2007 13:26:25 -0700
> 
> > This driver uses the inet_lro facilities , but it doesn't force it
> > to be enabled .. Someone would have to know to enable inet_lro if
> > they select the driver .. 
> > 
> > Instead, just force INET_LRO if this driver is selected..
> > 
> > Signed-off-by: Daniel Walker <dwalker@mvista.com>
> 
> I put this exact fix into the net-2.6.24 tree several days ago
> already, it's not nice that you didn't even bother checking.

Sorry..

> When I saw the response to the help@ address, I could almost predict
> that the myri10ge developers would not even check if net-2.6.24 had
> the issue cured already.
> 
> Therefore, your patch doesn't even apply to the tree where it is
> relevant.  That sucks.

Not sure what the help@ address is ? I'm just trying to fix problems I
find .. This problem is in -mm which is what I was using. The driver is
pretty obscure, and I just assumed not many people would be building it.
So I didn't check for fixes in git ..

Did your fix go to LKML ?

Daniel

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/