Received-SPF: Pass (protection.outlook.com: domain of topicproducts.com
 designates 13.93.42.39 as permitted sender) receiver=protection.outlook.com;
 client-ip=13.93.42.39; helo=westeu12-emailsignatures-cloud.codetwo.com; pr=C
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=topic.nl;
Message-ID: <5b90a794-b09f-0785-ac9a-ce375b59a3f0@topic.nl>
Date:   Fri, 17 Feb 2023 15:17:51 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
From:   Mike Looijmans <mike.looijmans@topic.nl>
Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: Add driver for TI ADS1100 and
 ADS1000
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        devicetree@vger.kernel.org, linux-iio@vger.kernel.org
CC:     Jonathan Cameron <jic23@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Rob Herring <robh+dt@kernel.org>, linux-kernel@vger.kernel.org
References: <20230217093128.8344-1-mike.looijmans@topic.nl>
 <cec5a521-bf3a-7cd3-4516-4f4a1b9e1661@linaro.org>
 <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.f5b3563c-3030-4c7b-8162-00135fd9d2e4@emailsignatures365.codetwo.com>
Organization: Topic
In-Reply-To: <cec5a521-bf3a-7cd3-4516-4f4a1b9e1661@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Microsoft-Antispam-Message-Info-Original: zaMvkPO1iZnK/EiNXZPKzzzFEjqHJDbhghZIakEN33HFgWziLfxZGanQMy9KS3CHJiK4in/CcvkAsdztLZhWGEf4PojZAYKklApbGjMnwXJ01WSe0B3mfvc8jEt7VvysH6bJttXxMnTBpQGqfZvcZcJLXtokwZQU71V4JoCcV2L25tRHw/Vluc+RaT1XY5cvFQAenbcZq2rexGbf8IUhN6UHFFPosseK+G4xBc78jaaqOXkAysgP87MNPhO1UmxrSOKpK4G8DrN2VFmHVsugL78vKFeVR6lmuJFhQqNE/0nfISGHbDCsSUOJy9gViCz2CUSBXPtx2t6FcbFpVYBHvfPHy7xktcdnQNrNxmZ3rk7yCF+d/E98MXG9zeXcljwQfKW2AJhcml8DN3WpJYo6tp2qnJPwQRh9URg8lBvJvtmw4nqpKnfGBOP85IPugKeot/lqD40aKj0NJVbUODcf5baQaq1olBteVlc3NpGbi9hTEiLAJd6sgf3+ts0el3ZOdw52mCBSKuoYc7/godoHM9bV6CCzysSHvHqstdmZsHo7MkNuYvJjJiTZFlJMg6BG0/3ho5aelObrHgjcigO6Jmc1NPBPw3A+/cIRI37u7gxNRR3jeqbnmjKCKV+DiT1ILPI4wmwsKg9kK6bMkuyke/66MefAtuc5NfiRkN0teiSSpm8hcdDsAkaPB2ldMplb3hRQ5VN/nfYiyvJro7jaHJQSWsNgH22fZHMLblzdb/aEK6OGR+Sd3jNLWri94Y+n
X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR04MB6523.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(366004)(39840400004)(376002)(346002)(396003)(451199018)(31686004)(478600001)(31696002)(42882007)(2616005)(44832011)(2906002)(36756003)(36916002)(966005)(52116002)(6486002)(6512007)(53546011)(6506007)(26005)(186003)(38350700002)(83170400001)(38100700002)(5660300002)(4326008)(8936002)(41300700001)(8676002)(66946007)(66476007)(316002)(66556008)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8618
X-CodeTwo-MessageID: be85ee36-27d7-4d4e-a0e6-ee850e5d6bfb.20230217141755@westeu12-emailsignatures-cloud.codetwo.com
X-CodeTwoProcessed: true
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: HE1EUR01FT062.eop-EUR01.prod.protection.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs: 66dce267-4539-41ee-6691-08db10f1c1de
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: C7smhRrdFTtF5anvGvjRBpVcYQqs3/J+Tf6T/9af9EdFz2eMbQyOSFgOf4EKJwO/VNldfgwYNuEHn16UIvA0VY+rcDvfHwZwGs+dNls+lqFASN8zFXtCdebN8N2k8w9QHfx+O1T59HRhRyOTmEQjXo2vfQ8bgqXgE2GvhjvkzjNfE6e6prqcQF3Ts2g2DOU11N7T3QPNBunZUI+Ft3u1nFZoIPKQ1xxiFeiN+t/dsDQ85dxNXO9vnufE3Zd5SPG4HRCd15TppgaN81or7C3ZuWbttn7nMxACZtkn1ww7OT2c6bCY6FE8sktXMo1f31grPYYAozHNA3fRVRKzvYqCwU283b7yKtVtl6HI5ixpraWT3ExJnLtW4Ag+U54wSF9CGOGPiXhVIWOvw62VyCuKNAUzqCgMwmJz6fLPn/JsnHBJcibRPkZvDgq81BrY9ccXjV0+mDWWfkSb04ZEZdJJVr0k1cL+uGwu/6lCphYZk+0WI0AwhsGzyYbWsHLX/qp5v+ghwmXgvqh0ZYkp76yu6YHa1s5n/zfGOSUag16JFlV2XHo7uYnvo9tHWTsluN7Bf1Snoyhb1HdG/DlttxgklyuJfw7vL7LCrYQp/qecX70riupGYP8jmgW86a6vVYVfotsGDZ8S/ubBa0HqP/z2lptDt0gpIa45ux/mzgod9v9n4gvJkIA17QXOSpjfB7zF
X-Forefront-Antispam-Report: CIP:13.93.42.39;CTRY:NL;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:westeu12-emailsignatures-cloud.codetwo.com;PTR:westeu12-emailsignatures-cloud.codetwo.com;CAT:NONE;SFS:(13230025)(4636009)(136003)(39840400004)(346002)(396003)(376002)(451199018)(46966006)(36840700001)(53546011)(36916002)(5660300002)(2616005)(6506007)(44832011)(36756003)(26005)(186003)(6512007)(7596003)(83170400001)(356005)(36860700001)(41300700001)(316002)(7636003)(54906003)(4326008)(70586007)(70206006)(8676002)(42882007)(8936002)(15974865002)(336012)(47076005)(40480700001)(82310400005)(31696002)(966005)(31686004)(6486002)(2906002)(478600001)(43740500002);DIR:OUT;SFP:1101;
X-OriginatorOrg: topic.nl
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2023 14:17:56.4859
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: f15f67c3-c14a-4222-cf72-08db10f1c42a
X-MS-Exchange-CrossTenant-Id: 449607a5-3517-482d-8d16-41dd868cbda3
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=449607a5-3517-482d-8d16-41dd868cbda3;Ip=[13.93.42.39];Helo=[westeu12-emailsignatures-cloud.codetwo.com]
X-MS-Exchange-CrossTenant-AuthSource: HE1EUR01FT062.eop-EUR01.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB8061
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Thanks I've fixed the issues and will send a v2 soon.

PS: Sorry for top-posting, it's to avoid our mail server messing things up.


Met vriendelijke groet / kind regards,=0A=
=0A=
Mike Looijmans=0A=
System Expert=0A=
=0A=
=0A=
TOPIC Embedded Products B.V.=0A=
Materiaalweg 4, 5681 RJ Best=0A=
The Netherlands=0A=
=0A=
T: +31 (0) 499 33 69 69=0A=
E: mike.looijmans@topicproducts.com=0A=
W: www.topic.nl=0A=
=0A=
Please consider the environment before printing this e-mail=0A=
On 17-02-2023 10:36, Krzysztof Kozlowski wrote:
> On 17/02/2023 10:31, Mike Looijmans wrote:
>> The ADS1100 is a 16-bit ADC (at 8 samples per second).
>> The ADS1000 is similar, but has a fixed data rate.
> Subject: Drop "driver for"
>
>> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
>>
>> ---
>>
>>   .../bindings/iio/adc/ti,ads1100.yaml          | 37 +++++++++++++++++++
>>   1 file changed, 37 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,ads110=
0.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads1100.yaml b=
/Documentation/devicetree/bindings/iio/adc/ti,ads1100.yaml
>> new file mode 100644
>> index 000000000000..ad30af8453a1
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads1100.yaml
>> @@ -0,0 +1,37 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/iio/adc/ti,ads1100.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: TI ADS1100/ADS1000 single channel I2C analog to digital converte=
r
>> +
>> +maintainers:
>> +  - Mike Looijmans <mike.looijmans@topic.nl>
>> +
>> +description: |
>> +  Datasheet at: https://www.ti.com/lit/gpn/ads1100
>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - ti,ads1100
>> +      - ti,ads1000
> Does not look like you tested the bindings. Please run `make
> dt_binding_check` (see
> Documentation/devicetree/bindings/writing-schema.rst for instructions).
>
> Best regards,
> Krzysztof
>

--=20
Mike Looijmans