Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D8E3C64EC4 for ; Fri, 17 Feb 2023 14:20:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229702AbjBQOU4 (ORCPT ); Fri, 17 Feb 2023 09:20:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229539AbjBQOUx (ORCPT ); Fri, 17 Feb 2023 09:20:53 -0500 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6610D72B5 for ; Fri, 17 Feb 2023 06:20:52 -0800 (PST) Received: by mail-ed1-x52b.google.com with SMTP id j20so6355594edw.0 for ; Fri, 17 Feb 2023 06:20:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DepS95Xiv6tzBVf9W0DYPpboAHnjdejp3hM9TEZ9nSc=; b=Yp2ODLUktl1oQf6nksGQtZHVM8M5TW/tSP4Ywbb/s9ExrHvtB5Hb52c5I4gmsNRf7Z e5IZaQdDxc08Gai6InENBwbflRS5VqZLnuiEXDzvTGyg0vPfSqUEHg7ObsHuJVrlaKIB roiJvsk3GiuBxXfK7g9c2EGSPco1aWl1bqkkSK4k3iY7PVWkP3B2LkNuA0QbtKz2BJNz OwSaIWQ/5Zv0JB1O2F77QiLiGAdMnS6sD7iyIMsCd7CSa9Jv+nPzE0NreulSBacCPVCL AzjfSWDq4xOgtNFbVfKjqVoQYUCFoRqPX6R6LoABF9tG1HnAcPIG8CxCRvgxvlQuAyi8 mFtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DepS95Xiv6tzBVf9W0DYPpboAHnjdejp3hM9TEZ9nSc=; b=rDAL3iz8us1m2OyHhXFQMKE7rxSdQ7r57638GKvf0nFavBG3re7PARM1a7FJQP+rxS grfoFgqjsbmr+Dkuos7oLa6fajjx6+xQkn1KUG2hkgJEqNcsrM4eANsndMdqziFFmcic BUrkq5z81tkxyOZIrE/tc4MUn4W/50YB5QwhDpB3IoOOYK1ycw+7SldRxIIQ6zmt3dht fgqa566RoV27KakvxvOVhgWfDYLDj0keF0DNWu+xyRxp8vSFXv9oCxMq6sEmVDvCUpo9 vdM+SnT5PgzJwW48bNK4FAfdz9iCaRLHRuOy8/f6G7J63shOLCrT23IpBvzAoMG+ofM9 Etxg== X-Gm-Message-State: AO0yUKVdo8CTwxJ2BjxKqMzgPTj7wvV1Pe2aU0ze1l420dHmbW0yOcAH D9Kq5BuessVRviGA2HDx0RCqAWFzlLnwRwVC X-Google-Smtp-Source: AK7set9rX7c55oN2r+fSDrfkxl+GHz0jcsU7INVi4Un1Ho2Dh46EQcbo0Bir57Bi89khR4O46oJc+Q== X-Received: by 2002:a17:907:6b8a:b0:879:43d5:3832 with SMTP id rg10-20020a1709076b8a00b0087943d53832mr5075230ejc.14.1676643650875; Fri, 17 Feb 2023 06:20:50 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id t1-20020a17090616c100b008b13a1abadasm2162597ejd.75.2023.02.17.06.20.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Feb 2023 06:20:50 -0800 (PST) Message-ID: <19c80f85-a1c5-3897-b592-6e9cd0579657@linaro.org> Date: Fri, 17 Feb 2023 15:20:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 22/24] kbuild, dmaengine: s3c24xx: remove MODULE_LICENSE in non-modules To: Nick Alcock , mcgrof@kernel.org Cc: linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, Hitomi Hasegawa , Vinod Koul , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, dmaengine@vger.kernel.org References: <20230217141059.392471-1-nick.alcock@oracle.com> <20230217141059.392471-23-nick.alcock@oracle.com> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <20230217141059.392471-23-nick.alcock@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/02/2023 15:10, Nick Alcock wrote: > Since commit 8b41fc4454e ("kbuild: create modules.builtin without > Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations > are used to identify modules. As a consequence, uses of the macro > in non-modules will cause modprobe to misidentify their containing > object file as a module when it is not (false positives), and modprobe > might succeed rather than failing with a suitable error message. > > So remove it in the files in this commit, none of which can be built as > modules. I think you need to base your tree-wide patches on next. The driver was removed. Please drop the patch. Best regards, Krzysztof