Date:   Fri, 17 Feb 2023 15:41:43 +0100
From:   Jan Kara <jack@suse.cz>
To:     Li zeming <zeming@nfschina.com>
Cc:     viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs-writeback: remove unnecessary =?utf-8?B?4oCYZmFs?=
 =?utf-8?B?c2XigJk=?= values from wakeup_bdi
Message-ID: <20230217144143.wikkdw44jkdcgdm2@quack3>
References: <20230208011742.5183-1-zeming@nfschina.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230208011742.5183-1-zeming@nfschina.com>
Precedence: bulk

On Wed 08-02-23 09:17:42, Li zeming wrote:
> wakeup_bdi does not need to be initialized. It is used after being
> assigned.
> 
> Signed-off-by: Li zeming <zeming@nfschina.com>

Looks good to me. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  fs/fs-writeback.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> index 6fba5a52127b..2d3191d9c736 100644
> --- a/fs/fs-writeback.c
> +++ b/fs/fs-writeback.c
> @@ -2486,7 +2486,7 @@ void __mark_inode_dirty(struct inode *inode, int flags)
>  		 */
>  		if (!was_dirty) {
>  			struct list_head *dirty_list;
> -			bool wakeup_bdi = false;
> +			bool wakeup_bdi;
>  
>  			inode->dirtied_when = jiffies;
>  			if (dirtytime)
> -- 
> 2.18.2
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR